From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2730C3F2D2 for ; Fri, 28 Feb 2020 11:30:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 849DB2469F for ; Fri, 28 Feb 2020 11:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="UwLKK6xz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 849DB2469F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BF676B0005; Fri, 28 Feb 2020 06:30:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16FB16B0006; Fri, 28 Feb 2020 06:30:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05BF56B0007; Fri, 28 Feb 2020 06:30:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id E0B386B0005 for ; Fri, 28 Feb 2020 06:30:30 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A2ECB181AEF2A for ; Fri, 28 Feb 2020 11:30:30 +0000 (UTC) X-FDA: 76539317820.04.stove13_3e99951d54f36 X-HE-Tag: stove13_3e99951d54f36 X-Filterd-Recvd-Size: 4014 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 11:30:30 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id t13so1747859qto.3 for ; Fri, 28 Feb 2020 03:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:date:subject:message-id :cc:to; bh=TyGvF4gDQhRWGSQu6uFitGsvvO6sV6I67VJLT7zuiLc=; b=UwLKK6xzIQfHkJ5u+SoYL3T1cU+Axozkd75UgiioAa1uAyWTULsnVt4eoa1/bqHrN3 bq3HPwd4rKijx3Pt2Jtx08kyTrAJtJWp5pALmdV2/wtCVWIy3nR6MLPWgHqDlxbNlqZa L7iq3V8ur2vI8JWArFuO5eD5zqSenHPRtdkHOZEoH4rU4po2jUtMBFJqtkhHTHC1H3DR MlPYHOeKKdx6W7yBEN9ivOwFNZTZhU4WUjsXU/ZWy5tO84ca/vH/s7J5ooA5OBHCac+Z 9Z+t/IthYEfFA3BPLAFFFIP58WltJ2fEHPdacpQpXXxgsezTjO327DX1TfOBPQN7xEcM FQ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version:date :subject:message-id:cc:to; bh=TyGvF4gDQhRWGSQu6uFitGsvvO6sV6I67VJLT7zuiLc=; b=JHtDx61tyLmRa+uG+sMipDj9l4/q1FKmb3HQbpfBkZAQaxsdSmRPCX7Rx8Yl8vIbDZ FEDJXm0tk7/mHPxGqH3JBjCVrAEHxM2X5HskaaQLPYUbbfMcAXPL8/4erBFRcPVco71R dzaEfy+aTngRXAh1NjNtIbaK036WcAKugtnLRbEOml12IsZ3Aw13Mu9e01iiI5UaLPnX F0yNNLZG7vF2R57IuFolvYVFXeFCmN3fUiP9JOoOnOCOQXh7KRDXh3AB1lxD+p+rJgrL IspyWS+LuE5Nh7Mravn6OP4zxSMoiHHH0PK18mYtUFEGcpF3ta62IUgMFS+FLyQgKMDg M93g== X-Gm-Message-State: APjAAAU/ejBYiJqVdR475ppZh0QBdF0cXTKvCH8+OXVeGPEfok97xVCZ aRkyEoGUNFcMcJ/dK9/zEuxiN4qDQvY58w== X-Google-Smtp-Source: APXvYqwJcrooKjN0GU6+b+NXsZ6xnHvQo/OCzxdp13t+dJETeObi56ivSf5q5BJftKIGvimMix1W6w== X-Received: by 2002:ac8:9e:: with SMTP id c30mr3800792qtg.359.1582889428464; Fri, 28 Feb 2020 03:30:28 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id a6sm3438231qkn.104.2020.02.28.03.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2020 03:30:27 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Date: Fri, 28 Feb 2020 06:30:26 -0500 Subject: Re: [PATCH] mm/swap: annotate data races for lru_rotate_pvecs Message-Id: <463BBB2A-8F9A-4CF1-80AE-677ACD21A3C6@lca.pw> Cc: Andrew Morton , Linux Memory Management List , LKML , kasan-dev To: Marco Elver X-Mailer: iPhone Mail (17D50) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Feb 28, 2020, at 5:49 AM, Marco Elver wrote: >=20 > Note that, the fact that the writer has local interrupts disabled for > the write is irrelevant because it's the interrupt that triggered > while the read was happening that led to the concurrent write. I was just to explain that concurrent writers are rather unlikely as people m= ay ask. >=20 > I assume you ran this with CONFIG_KCSAN_INTERRUPT_WATCHER=3Dy? The > option is disabled by default (see its help-text). I don't know if we > want to deal with data races due to interrupts right now, especially > those that just result in 'data_race' annotations. Thoughts? Yes, I somehow got quite a bit clean runs lately thanks to the fix/annotatio= ns efforts for the last a few weeks (still struggling with the flags things a= bit), so I am naturally expanding the testing coverage here. Right now the bottleneck is rather some subsystem maintainers are not so kee= n to deal with data races (looking forward to seeing more education opportun= ities for all), but the MM subsystem is not one of them.=