From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57238108E1E8 for ; Thu, 19 Mar 2026 11:30:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9A436B0480; Thu, 19 Mar 2026 07:30:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4AFC6B0482; Thu, 19 Mar 2026 07:30:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A61366B0483; Thu, 19 Mar 2026 07:30:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 952036B0480 for ; Thu, 19 Mar 2026 07:30:38 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6182F8BA93 for ; Thu, 19 Mar 2026 11:30:38 +0000 (UTC) X-FDA: 84562594956.13.64676AF Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf18.hostedemail.com (Postfix) with ESMTP id A12671C0014 for ; Thu, 19 Mar 2026 11:30:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q7VsKY4O; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1773919836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UP7TiCWvQpD323l4z4xkeXVFws6aOD8BsLx4HR/DrhU=; b=OgT8BvMHCRIVdVwVwXrpHT68KyKNEgxggBCuRctwHjmaoEdQBJIkqZFOKD+BUvTwO3pYux Tnzy37uDsS1vM2HWOHAadVi5KQFT0Y1EfJ2ilPaNqj5NvjXFsXWqGRUtkKsXtWjIeAXXLR Y6RylXQZhaoygO3GC3acFva0Vk9XiDc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q7VsKY4O; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1773919836; a=rsa-sha256; cv=none; b=B+X7b9Tw9Tys3bGOCVyefA+EzIhikhUdV+crR+t09U0qdM0qC/HltNfGFoZP/oaM4S0ojL MPa2WgoX1yYnujrgp4nfqIvxO6EkdEfdFN9+gq1vRLeKCQeuwH4j25oBbdD2ge78/HIY/d geI8GDxGNSJAtVltfDkY1B43N7W42gw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A3C8E4189B; Thu, 19 Mar 2026 11:30:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0F07C19424; Thu, 19 Mar 2026 11:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773919835; bh=EpdXKKIdceMmTkZAXX5Ct8/xuQwjfbKs6OQeG4vR4ns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q7VsKY4OW+OA5toO0Yg1z30nmYdRMMobJ+Sz2EiXd59TQTcCcVuapUD2aMFFx+zLK btV61rr7n55v0DLTJJJQMLBXbdyFkc0x+F1rltfGN7szXnrrFt96shj5aU27gna8OP CORJQfk4Yh0leuCXiiIyFj5WIuAMIsX5DTRGhJNfuIrWz7dJAZhChDzpGAcum8kvoa 5gA72TII+P5JN9Z91Tr6YFnNr6ySRHxDFftQ4lQTkVE+W9MWOjiPavaHOHica3MPTA NsUr90L4xA4A2KGhQxlvi6+CVZnOVp6mUHBBuk5hKbjnJpbGPLqCs3e3sYGyBdKIHa bdPgxwSo0keCw== Date: Thu, 19 Mar 2026 11:30:29 +0000 From: "Lorenzo Stoakes (Oracle)" To: Baolin Wang Cc: akpm@linux-foundation.org, david@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, open , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] mm: change to return bool for ptep_clear_flush_young()/clear_flush_young_ptes() Message-ID: <46390a7c-164c-4ffb-a1b2-fad21e3829df@lucifer.local> References: <5d24b34d8b7860dc2188408b3fa530193bcc5caa.1773890510.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d24b34d8b7860dc2188408b3fa530193bcc5caa.1773890510.git.baolin.wang@linux.alibaba.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A12671C0014 X-Stat-Signature: 9niux9qibwujkdzmy4bf4idfbr3rbq73 X-Rspam-User: X-HE-Tag: 1773919836-900275 X-HE-Meta: U2FsdGVkX18X+a7rdqjjM5O0K3U4I+Gwd4SZXwhed1TpFk+zVVB0hm/vDBpgnAAqitLRFVY0WOJXpdGSsUkyEIBuGZMLxOQjVJGLQp8nKGfauZXLHJX5xYWlGQvicEqpofRN1qRGb68BOC4/NdvFmF8ZERYQTNxiQKsKvTTsR0fNAwvKltsWtLTmQ6sh0I9+NaCAA3KKeDunPfLHhIepEf6PO6d9x+vY6HE0Jpd8xFPJ6AOY9pPxjEbF3GvdXTUkOb10L+MeINyr+B8J/m8mpFOjmYlS92Jqjiz092WTvhJkgU465NkD1JrjyTDCMRF68hry+J06IquhRhxJvG3NF1qGUwby2UUPCe/jingYTctbYt6Si24BZpebZcoYuTj/nuPtcvqhXvoqayLn5FAB7TR+E0vMsuCLq0DdTLgj3dDWlyyAkJirYHuAXWisFwxP/qAX9H7FYl/Ct0jQYHY7iCGJaMYaBVzMT7XPqRjdoDmpZxsU3tQp1r58e6RiFQVjpJRyViv7QAmm6ncQILlf7itpZgNDCJdxwClw+MFa8O0od7Sqnv9bRognWZacemCnal8VJ9ZKBa6bQURyMhAB4AlVUQ8MinDr4Ud4ZjMnjgCEFH4xAWi0SoUbmIoxsXkklFMQJEz0XSmMu4rJrYMvwuj6ESOn7KT15sSJ6UXEWdEDxmlp8Lmr4G7TyDl0gftCj/5LqQyv/g7rUah6PoSgiA6KQqJCca44Vz6hX0BrRaoAXDk42qfyVyA6rhpn2qow2M/9aDFUbWXfalYnzYZ90U3VMaGVL0hfO+P3MptwF1ursmP9GwtCoOIrouz3gO4nW1JaOPnLWS49w8u9Wjj2MNXHMRpLXuaOfNGSlTYuh//ZwNiM/9g8C2sO8H1aZMecUglfF7ywc9ebjFEEWGHVGKJT/2LBmwLbx6l34Xm3M1Cmbh/+c2f76cY7RZheBJ6DV/05fZSavsgLXuGRKMG mtU7FAAz nQOGVu2dVJ8spDTDSMoP6cEVeFIOZCeEpWsJe8tEdKcENI2e66JNkn8D/KRdabHNv2pnak1qfrOrI2NCA9znp11aJ3nzRSoVIwI68Sbr38oqCmLj+mPwgmTTFiCvw/ir9kSiKcKp0rW2hYc51Y6arNx55AJYzc6eospEePvUybxgKKqtG7ysRbU8za8GaJ9Rsj7aCPpby43URCSiEnpsx2DasQy2Dph5zQFiwchse0D6mJudYGjDjspI25sb1OP7a2LCN74zHxS9DJI9cYqPVtuvnkVARkud/nXhLyVwPseEqeY3ME4mXUFTWLQ== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 19, 2026 at 11:24:01AM +0800, Baolin Wang wrote: > The ptep_clear_flush_young() and clear_flush_young_ptes() are used to clear > the young flag and flush the TLB, returning whether the young flag was set. > Change the return type to bool to make the intention clearer. > > Signed-off-by: Baolin Wang Couple nits but LGTM, so: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > arch/arm64/include/asm/pgtable.h | 15 +++++++-------- > arch/arm64/mm/contpte.c | 4 ++-- > arch/parisc/include/asm/pgtable.h | 2 +- > arch/parisc/kernel/cache.c | 8 ++++---- > arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +- > arch/riscv/include/asm/pgtable.h | 4 ++-- > arch/s390/include/asm/pgtable.h | 4 ++-- > arch/x86/include/asm/pgtable.h | 4 ++-- > arch/x86/mm/pgtable.c | 4 ++-- > include/linux/pgtable.h | 8 ++++---- > mm/pgtable-generic.c | 7 ++++--- > 11 files changed, 31 insertions(+), 31 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 8c651695204c..393a9d1873f6 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -1299,10 +1299,10 @@ static inline bool __ptep_test_and_clear_young(struct vm_area_struct *vma, > return pte_young(pte); > } > > -static inline int __ptep_clear_flush_young(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep) > +static inline bool __ptep_clear_flush_young(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep) I mean this is subjective stuff but can we just put 2nd line 2 tabs indented underneath? Makes it easier for changes like this to not propagate. Same comment for all of these! > { > - int young = __ptep_test_and_clear_young(vma, address, ptep); > + bool young = __ptep_test_and_clear_young(vma, address, ptep); > > if (young) { > /* > @@ -1648,7 +1648,7 @@ extern pte_t contpte_get_and_clear_full_ptes(struct mm_struct *mm, > unsigned int nr, int full); > bool contpte_test_and_clear_young_ptes(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep, unsigned int nr); > -int contpte_clear_flush_young_ptes(struct vm_area_struct *vma, > +bool contpte_clear_flush_young_ptes(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep, unsigned int nr); > extern void contpte_wrprotect_ptes(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, unsigned int nr); > @@ -1831,7 +1831,7 @@ static inline bool ptep_test_and_clear_young(struct vm_area_struct *vma, > } > > #define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH > -static inline int ptep_clear_flush_young(struct vm_area_struct *vma, > +static inline bool ptep_clear_flush_young(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep) > { > pte_t orig_pte = __ptep_get(ptep); > @@ -1843,9 +1843,8 @@ static inline int ptep_clear_flush_young(struct vm_area_struct *vma, > } > > #define clear_flush_young_ptes clear_flush_young_ptes > -static inline int clear_flush_young_ptes(struct vm_area_struct *vma, > - unsigned long addr, pte_t *ptep, > - unsigned int nr) > +static inline bool clear_flush_young_ptes(struct vm_area_struct *vma, > + unsigned long addr, pte_t *ptep, unsigned int nr) > { > if (likely(nr == 1 && !pte_cont(__ptep_get(ptep)))) > return __ptep_clear_flush_young(vma, addr, ptep); > diff --git a/arch/arm64/mm/contpte.c b/arch/arm64/mm/contpte.c > index 0b88278927a4..2ef4bff3b998 100644 > --- a/arch/arm64/mm/contpte.c > +++ b/arch/arm64/mm/contpte.c > @@ -535,11 +535,11 @@ bool contpte_test_and_clear_young_ptes(struct vm_area_struct *vma, > } > EXPORT_SYMBOL_GPL(contpte_test_and_clear_young_ptes); > > -int contpte_clear_flush_young_ptes(struct vm_area_struct *vma, > +bool contpte_clear_flush_young_ptes(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep, > unsigned int nr) > { > - int young; > + bool young; > > young = contpte_test_and_clear_young_ptes(vma, addr, ptep, nr); > > diff --git a/arch/parisc/include/asm/pgtable.h b/arch/parisc/include/asm/pgtable.h > index d5e39f2eb415..f6984b3ba531 100644 > --- a/arch/parisc/include/asm/pgtable.h > +++ b/arch/parisc/include/asm/pgtable.h > @@ -450,7 +450,7 @@ static inline bool ptep_test_and_clear_young(struct vm_area_struct *vma, unsigne > return true; > } > > -int ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep); > +bool ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep); > pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep); > > struct mm_struct; > diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c > index 4c5240d3a3c7..268530eb107d 100644 > --- a/arch/parisc/kernel/cache.c > +++ b/arch/parisc/kernel/cache.c > @@ -781,18 +781,18 @@ void flush_anon_page(struct vm_area_struct *vma, struct page *page, unsigned lon > __flush_cache_page(vma, vmaddr, PFN_PHYS(page_to_pfn(page))); > } > > -int ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long addr, > - pte_t *ptep) > +bool ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long addr, > + pte_t *ptep) > { > pte_t pte = ptep_get(ptep); > > if (!pte_young(pte)) > - return 0; > + return false; > set_pte(ptep, pte_mkold(pte)); > #if CONFIG_FLUSH_PAGE_ACCESSED > __flush_cache_page(vma, addr, PFN_PHYS(pte_pfn(pte))); > #endif > - return 1; > + return true; > } > > /* > diff --git a/arch/powerpc/include/asm/nohash/64/pgtable.h b/arch/powerpc/include/asm/nohash/64/pgtable.h > index 2deb955b7bc8..661eb3820d12 100644 > --- a/arch/powerpc/include/asm/nohash/64/pgtable.h > +++ b/arch/powerpc/include/asm/nohash/64/pgtable.h > @@ -155,7 +155,7 @@ static inline void huge_ptep_set_wrprotect(struct mm_struct *mm, > #define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH > #define ptep_clear_flush_young(__vma, __address, __ptep) \ > ({ \ > - int __young = ptep_test_and_clear_young(__vma, __address, __ptep);\ > + bool __young = ptep_test_and_clear_young(__vma, __address, __ptep);\ > __young; \ > }) > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index fb010dcdf343..11f57ccf6dc9 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -695,8 +695,8 @@ static inline void ptep_set_wrprotect(struct mm_struct *mm, > } > > #define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH > -static inline int ptep_clear_flush_young(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep) > +static inline bool ptep_clear_flush_young(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep) > { > /* > * This comment is borrowed from x86, but applies equally to RISC-V: > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index da1a7a31fa22..c9ab81caaf75 100644 > --- a/arch/s390/include/asm/pgtable.h > +++ b/arch/s390/include/asm/pgtable.h > @@ -1174,8 +1174,8 @@ static inline bool ptep_test_and_clear_young(struct vm_area_struct *vma, > } > > #define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH > -static inline int ptep_clear_flush_young(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep) > +static inline bool ptep_clear_flush_young(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep) > { > return ptep_test_and_clear_young(vma, address, ptep); > } > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 563a6289ea44..554dea93eb99 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -1236,8 +1236,8 @@ extern bool ptep_test_and_clear_young(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep); > > #define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH > -extern int ptep_clear_flush_young(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep); > +extern bool ptep_clear_flush_young(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep); Drop extern please! > > #define __HAVE_ARCH_PTEP_GET_AND_CLEAR > static inline pte_t ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, > diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c > index c594976afc5c..0007dc3d739e 100644 > --- a/arch/x86/mm/pgtable.c > +++ b/arch/x86/mm/pgtable.c > @@ -483,8 +483,8 @@ int pudp_test_and_clear_young(struct vm_area_struct *vma, > } > #endif > > -int ptep_clear_flush_young(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep) > +bool ptep_clear_flush_young(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep) > { > /* > * On x86 CPUs, clearing the accessed bit without a TLB flush > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 8e75dc9f7932..1198e216fde3 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -531,8 +531,8 @@ static inline int pmdp_test_and_clear_young(struct vm_area_struct *vma, > #endif > > #ifndef __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH > -int ptep_clear_flush_young(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep); > +bool ptep_clear_flush_young(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep); > #endif > > #ifndef __HAVE_ARCH_PMDP_CLEAR_YOUNG_FLUSH > @@ -1086,10 +1086,10 @@ static inline void wrprotect_ptes(struct mm_struct *mm, unsigned long addr, > * Context: The caller holds the page table lock. The PTEs map consecutive > * pages that belong to the same folio. The PTEs are all in the same PMD. > */ > -static inline int clear_flush_young_ptes(struct vm_area_struct *vma, > +static inline bool clear_flush_young_ptes(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep, unsigned int nr) > { > - int young = 0; > + bool young = false; > > for (;;) { > young |= ptep_clear_flush_young(vma, addr, ptep); > diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c > index af7966169d69..db0ee918b08a 100644 > --- a/mm/pgtable-generic.c > +++ b/mm/pgtable-generic.c > @@ -81,10 +81,11 @@ int ptep_set_access_flags(struct vm_area_struct *vma, > #endif > > #ifndef __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH > -int ptep_clear_flush_young(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep) > +bool ptep_clear_flush_young(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep) > { > - int young; > + bool young; > + > young = ptep_test_and_clear_young(vma, address, ptep); > if (young) > flush_tlb_page(vma, address); > -- > 2.47.3 >