From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <462F0F90.3070600@shadowen.org> Date: Wed, 25 Apr 2007 09:21:36 +0100 From: Andy Whitcroft MIME-Version: 1.0 Subject: Re: 2.6.21-rc7-mm1 on test.kernel.org References: <20070424130601.4ab89d54.akpm@linux-foundation.org> <20070424132740.e4bdf391.akpm@linux-foundation.org> <20070424134325.f71460af.akpm@linux-foundation.org> <20070424141826.952d2d32.akpm@linux-foundation.org> <20070424143635.cdff71de.akpm@linux-foundation.org> <462E7AB6.8000502@shadowen.org> <462E9DDC.40700@shadowen.org> <1177461251.1281.7.camel@dyn9047017100.beaverton.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Badari Pulavarty , Andrew Morton , linux-mm List-ID: Christoph Lameter wrote: > On Tue, 24 Apr 2007, Badari Pulavarty wrote: > >> quicklists-for-page-table-pages-avoid-useless-virt_to_page- >> conversion.patch >> >> Andy, can you try backing out only this and enable QUICK_LIST >> on your machine ? > > Ahh. Right..... The free that we switched to there to avoid the > virt_to_page conversion does not decrement the refcount and thus > is not equivalent. > > Does this patch fix it? > > --- > include/linux/quicklist.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.21-rc7-mm1/include/linux/quicklist.h > =================================================================== > --- linux-2.6.21-rc7-mm1.orig/include/linux/quicklist.h 2007-04-24 23:35:11.000000000 -0700 > +++ linux-2.6.21-rc7-mm1/include/linux/quicklist.h 2007-04-24 23:35:59.000000000 -0700 > @@ -61,7 +61,7 @@ static inline void __quicklist_free(int > if (unlikely(nid != numa_node_id())) { > if (dtor) > dtor(p); > - free_hot_page(page); > + __free_page(page); > return; > } Confirmed, this fixes the machine. -apw -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org