linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ethan Solomita <solo@google.com>
To: linux-mm@kvack.org
Subject: [RFC 5/7] cpuset write vm writeout
Date: Mon, 23 Apr 2007 16:32:42 -0700	[thread overview]
Message-ID: <462D421A.3070309@google.com> (raw)
In-Reply-To: <462D3F4C.2040007@google.com>

Throttle VM writeout in a cpuset aware way

This bases the vm throttling from the reclaim path on the dirty ratio
of the cpuset. Note that a cpuset is only effective if shrink_zone is called
from direct reclaim.

kswapd has a cpuset context that includes the whole machine. VM throttling
will only work during synchrononous reclaim and not  from kswapd.

Originally by Christoph Lameter <clameter@sgi.com>

Signed-off-by: Ethan Solomita <solo@google.com>

---

diff -uprN -X linux-2.6.21-rc4-mm1/Documentation/dontdiff 4/include/linux/writeback.h 5/include/linux/writeback.h
--- 4/include/linux/writeback.h	2007-04-23 14:37:31.000000000 -0700
+++ 5/include/linux/writeback.h	2007-04-23 14:37:51.000000000 -0700
@@ -85,7 +85,7 @@ static inline void wait_on_inode(struct 
 int wakeup_pdflush(long nr_pages, nodemask_t *nodes);
 void laptop_io_completion(void);
 void laptop_sync_completion(void);
-void throttle_vm_writeout(gfp_t gfp_mask);
+void throttle_vm_writeout(nodemask_t *nodes,gfp_t gfp_mask);
 
 extern struct timer_list laptop_mode_wb_timer;
 static inline int laptop_spinned_down(void)
diff -uprN -X linux-2.6.21-rc4-mm1/Documentation/dontdiff 4/mm/page-writeback.c 5/mm/page-writeback.c
--- 4/mm/page-writeback.c	2007-04-23 15:12:27.000000000 -0700
+++ 5/mm/page-writeback.c	2007-04-23 15:13:15.000000000 -0700
@@ -384,7 +384,7 @@ void balance_dirty_pages_ratelimited_nr(
 }
 EXPORT_SYMBOL(balance_dirty_pages_ratelimited_nr);
 
-void throttle_vm_writeout(gfp_t gfp_mask)
+void throttle_vm_writeout(nodemask_t *nodes, gfp_t gfp_mask)
 {
 	struct dirty_limits dl;
 
@@ -399,7 +399,7 @@ void throttle_vm_writeout(gfp_t gfp_mask
 	}
 
 	for ( ; ; ) {
-		get_dirty_limits(&dl, NULL, &node_online_map);
+		get_dirty_limits(&dl, NULL, nodes);
 
 		/*
 		 * Boost the allowable dirty threshold a bit for page
diff -uprN -X linux-2.6.21-rc4-mm1/Documentation/dontdiff 4/mm/vmscan.c 5/mm/vmscan.c
--- 4/mm/vmscan.c	2007-04-23 14:37:32.000000000 -0700
+++ 5/mm/vmscan.c	2007-04-23 14:37:51.000000000 -0700
@@ -1055,7 +1055,7 @@ static unsigned long shrink_zone(int pri
 		}
 	}
 
-	throttle_vm_writeout(sc->gfp_mask);
+	throttle_vm_writeout(&cpuset_current_mems_allowed, sc->gfp_mask);
 
 	atomic_dec(&zone->reclaim_in_progress);
 	return nr_reclaimed;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-04-23 23:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-23 23:20 [RFC 1/7] cpuset write dirty map Ethan Solomita
2007-04-23 23:30 ` [RFC 2/7] cpuset write pdflush nodemask Ethan Solomita
2007-04-23 23:31 ` [RFC 3/7] cpuset write throttle Ethan Solomita
2007-04-23 23:31 ` [RFC 4/7] cpuset write vmscan Ethan Solomita
2007-04-23 23:35   ` [Corrected] " Ethan Solomita
2007-04-23 23:32 ` Ethan Solomita [this message]
2007-04-23 23:33 ` [RFC 6/7] cpuset write fixes Ethan Solomita
2007-04-23 23:33 ` [RFC 7/7] cpuset dirty limits Ethan Solomita
2007-06-01  6:03 [RFC 1/7] cpuset write dirty map Ethan Solomita
2007-06-01  6:15 ` [RFC 5/7] cpuset write vm writeout Ethan Solomita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462D421A.3070309@google.com \
    --to=solo@google.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox