From: Ethan Solomita <solo@google.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org
Subject: Re: meminfo returns inaccurate NR_FILE_PAGES
Date: Wed, 18 Apr 2007 12:39:29 -0700 [thread overview]
Message-ID: <462673F1.7070808@google.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704181235090.7234@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Tue, 17 Apr 2007, Ethan Solomita wrote:
>
>
>> While you're busy correcting me, look in swap_state.c at
>> __add_to_swap_cache(). Note how, when it inserts a page into
>> swapper_space.page_tree, it then does an __inc_zone_page_state(NR_FILE_PAGES).
>>
>
> Correct. So a page is accounted for both as anonymous and a file pages.
> That is surprising. So this patch should indeed work. Added some comments
> to clarify the situation.
>
Given that it's exactly what I suggested in my first post, clearly I
second your patch.
-- Ethan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-18 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 23:12 Ethan Solomita
2007-04-17 23:56 ` Christoph Lameter
2007-04-18 4:06 ` Ethan Solomita
2007-04-18 5:12 ` Christoph Lameter
2007-04-18 5:31 ` Ethan Solomita
2007-04-18 5:39 ` Christoph Lameter
2007-04-18 6:13 ` Ethan Solomita
2007-04-18 19:36 ` Christoph Lameter
2007-04-18 19:39 ` Ethan Solomita [this message]
2007-04-18 21:02 ` Christoph Lameter
2007-04-18 4:49 ` Ethan Solomita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462673F1.7070808@google.com \
--to=solo@google.com \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox