From: Pavel Emelianov <xemul@sw.ru>
To: Dave Hansen <hansendc@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Eric Dumazet <dada1@cosmosbay.com>, Linux MM <linux-mm@kvack.org>,
devel@openvz.org, Kirill Korotaev <dev@openvz.org>
Subject: Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2)
Date: Wed, 18 Apr 2007 10:41:45 +0400 [thread overview]
Message-ID: <4625BDA9.7080106@sw.ru> (raw)
In-Reply-To: <1176831473.12599.30.camel@localhost.localdomain>
Dave Hansen wrote:
> On Tue, 2007-04-17 at 19:34 +0400, Pavel Emelianov wrote:
>> +#define SHOW_TOP_SLABS 10
>
> Real minor nit on this one: SHOW_TOP_SLABS sounds like a bool. "Should
> I show the top slabs?"
>
> This might be a bit more clear:
>
> #define TOP_NR_SLABS_TO_SHOW 10
>
> or
>
> #define NR_SLABS_TO_SHOW 10
Agree :) Will fix in a moment.
>
> -- Dave
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-18 6:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 15:34 Pavel Emelianov
2007-04-17 17:37 ` Dave Hansen
2007-04-18 6:12 ` Pekka J Enberg
2007-04-18 6:41 ` Pavel Emelianov [this message]
2007-04-18 6:24 ` Pekka Enberg
2007-04-18 7:03 ` Pavel Emelianov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4625BDA9.7080106@sw.ru \
--to=xemul@sw.ru \
--cc=akpm@osdl.org \
--cc=dada1@cosmosbay.com \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=hansendc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox