From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6809DC3ABC0 for ; Wed, 7 May 2025 13:18:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCCFA6B0085; Wed, 7 May 2025 09:18:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7C866B008A; Wed, 7 May 2025 09:18:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C01DC6B0085; Wed, 7 May 2025 09:18:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9FDA36B0085 for ; Wed, 7 May 2025 09:18:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0D0BE1A02EB for ; Wed, 7 May 2025 13:18:21 +0000 (UTC) X-FDA: 83416165602.04.1A8978D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 94CC4A0008 for ; Wed, 7 May 2025 13:18:18 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hsn6A1Kz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746623898; a=rsa-sha256; cv=none; b=Vuj4R5G2hXeTepJML0ZjY+8293UlXwJPGZW9Zi1zCtvZ8y99SKgPVADtNIDFLX/ispQCk2 1TUhzVxfmbjXu+HvInXdmIu4H6WlPjeha8v7VN9Bn8Ko8w+C8mpXYq5NiXuiMn8BsujGF7 6dmAXRtzMKWC8VVzixFGM6LIYAON4is= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hsn6A1Kz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746623898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FG3kNlYcb8YUhDo9rxNXddcYreagTVa77SB8lGY4MHs=; b=7x3n8wwlkVJdPinZKCQa9ZBeUrQlzFnAVUTq2vQIDM64E47XKwSrWdd3BLbQyVnkpI1cU3 ioj8qYkAKeTs/TndRE60N5DdaeXmV65XbHNoRiIa2NdvZC1C4PkWSAA5iAI4S49kRn5IIK JLuh4OzYoyX+gtQJz3rgd0Uh3Y+0dbk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746623897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FG3kNlYcb8YUhDo9rxNXddcYreagTVa77SB8lGY4MHs=; b=hsn6A1KzV8X0JCnvA0cpyyGxJBi/RlJWILJreLpgWweFg9+hjC1+gslqAzf30awb4yTWNy M/Az2grMxksyM4JN6+PcLVlSpx3O2FgKTB0tUO91tV/nmxexdqbTbVKOru5S/OA9LdDs92 idSvxUa5aFFZLZtwtlCIjSJIJ/O3NLo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-BD4420icM3uGYvg6VFy4cw-1; Wed, 07 May 2025 09:18:16 -0400 X-MC-Unique: BD4420icM3uGYvg6VFy4cw-1 X-Mimecast-MFC-AGG-ID: BD4420icM3uGYvg6VFy4cw_1746623895 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d0a037f97so37605995e9.2 for ; Wed, 07 May 2025 06:18:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746623895; x=1747228695; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FG3kNlYcb8YUhDo9rxNXddcYreagTVa77SB8lGY4MHs=; b=lTFcfopdc1NLWdbDJ71IH7DST2SlPLSpNstZ/s6hUnuUCiVet7i78U30vxPSYdefNX iCiUzZT3ZDD/mIR2kiRQy+vdKP2QQ4tHySSZdTOOYUo7jaoTdGGPEvPkqwvz6/sy8j0/ jcR82IghxViFQ+M2MJNuzMIH0ERR8Y0SjGL8FjRZnh5KdogHVjzoS8ct6rrY/nNPIsa7 xuVOUHPl6lJHDbkPZqF8zaqreC8Jtdw0X6r45mE5mi2u21viAmZMjEw5Bp1EgyFg9ggL mcOVBH/bhCuuY7+aPRj8HN2CByUNyCjqpLcf0Npzzp58GOueeQlOuYljNJwB02FQ1C0+ 7zNA== X-Forwarded-Encrypted: i=1; AJvYcCXx44i9u90sbdvh5iS9MLc3HbMyfaaZU5K+0Ks6ANbnh9oWK5TVtLDFg7ZX9RjoatVD1kmGGjOPXw==@kvack.org X-Gm-Message-State: AOJu0YwFgq/DtT/bQkN8X97bwNoZN2VXbJrli+8rsXnI+bW8HHMmX9V9 uAldO94g9HeXFPEbwJeRaU2AauzTsv3OBJAfXpgq+fs3unC67PoyDSmS1bC3MSQs3iDGZCgXd9k CI9vMId0gmonvXihcd3aginP7APfjpCE/jnqGEdl/aCb1t8wQ X-Gm-Gg: ASbGnctGTafDd3cGInL81abuITQuvqzc36oE04F/FIJZDcHyX3TqeZO6CINRzcGAuOD vvXTclomS9hwYtDN+YAp9K1B6fNxIW+u760t5sK/BVGCl7HtClLqf2sy2MeXwfI3576ClyEZkYb eoGwkrr0PWiyJnnvNmds86Hw4hx6f+bxcUkAulMNntKF8tje7GsgJBzB5WB41xBeVAQsMoweeX2 xVBHSwGjXZm+gDsDWmfe0Of1B9SC64q3Qf3j9VFslYt0PV5MG3ddm3sbhk8+YazH5Ivk/IW1qMt o4GKQZSqQrhPg9kr0PrcVd9bJTDsvg45L8V+C2lDcbhwYvKc/b7CUBhbGO+CW+CIsyCKPECtK/t 5ktEirSpUR2XGzcyHinmEcb8gOUzd7XY/4UtNsg== X-Received: by 2002:a05:600c:1d8f:b0:43b:ce36:7574 with SMTP id 5b1f17b1804b1-441d44c315fmr27666475e9.11.1746623895297; Wed, 07 May 2025 06:18:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGAGKlUk1CojooV02HZaxfdY4EaPWUbdBSLkYEiYIxrFTs1AdessNfp5hENPaPv8+VicTrpg== X-Received: by 2002:a05:600c:1d8f:b0:43b:ce36:7574 with SMTP id 5b1f17b1804b1-441d44c315fmr27666305e9.11.1746623894962; Wed, 07 May 2025 06:18:14 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628? (p200300d82f12d400ed3cfb0c1ec0c628.dip0.t-ipconnect.de. [2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae0c5esm16644012f8f.1.2025.05.07.06.18.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 06:18:14 -0700 (PDT) Message-ID: <4610064f-04f0-47c5-aff9-2584958f71fb@redhat.com> Date: Wed, 7 May 2025 15:18:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled To: Ignacio.MorenoGonzalez@kuka.com, lorenzo.stoakes@oracle.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250507-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v4-1-4837c932c2a3@kuka.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250507-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v4-1-4837c932c2a3@kuka.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fOIHAf-DZq92Ha4LY5wpLe7lQpcvHGm3N03ExEJOISQ_1746623895 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 94CC4A0008 X-Stat-Signature: fauymke1ryyiod8wtf1gbokpmcxr76yx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746623898-886579 X-HE-Meta: U2FsdGVkX19EesuH9Qh1DmJEJsgcNVHS8vS9ZPBRCPOJplg73LO6PhMhjbDW6kFhffbwtmjV2oNSLdftQ299RD69r5bzIPauuNw91py6OFnnQyqooUDwejFuYyKXaYn9yaXY+eXU6HfVUgZpTTRghvmGwBtAWO1GnQtGqw7gPHwiO6qTVNpq97bSORo5pt9S0ypTfo9oGgovfd8+2fOHP9kYPR9YtcgbZs4eWxFKJ4ElTx2vCwllhskI7Rlb+8aCe5bWaYpV4lr5T10CqaQ/ZchzYQ00mhP44Ww8iRYsvgdfVGDFHlGJSjpUFm1GE016Tt7QhXY7M8UrLMQu9E4NyXratwztnnxZUpL2kuLU5y85r//IGdqAnF+z4+Q5HmvfXq74JPD95dEov5ldGKmdTb4i1OJtqFl8fiOtKeFOb6MZVCA0l2TzzUPRQeF2071TT5VG7j64BH9Rdt3s4XWPyptlHhNzDQmqmxN9KzAvwvujsJBnahNWk2AuKeWP8h6EExIKXnaxQ09e7f3gaVusbzbTX6ioCXZkBxFbFvISXUlh3TkZihwWWvSXIEUoKNzqBhA7HsKnAdlsnlJHiNzCdJzA8FtTEznBm8wuphY878XODcw8NGiUXY7wh39kiDf+xx0KIWU5J9uKEfb/tY87Rf9O+FwJOdpLC2a2ewqGZxNNrQ3uIOvnYooUxXiOS5SURtWU+wS5O7y0BAQhOWsLvcT7Yvi7oGqBu3b4FSvTFC3X/sULDTutPN5T+hWj1KCxs3d6CV7ThpVSWgb7kaEFnsjDGyn2UlNwnY5rkwnW77+BXKQEMX1lbJRZcKqgQNWCnAnctfRZAZVnCmEeUXCnXcYVW35W1WbqR0QU9cb3pHlSF0sMeG6akIZfa9Bkrob0YFzF8cb+VfXnUVZaxmI3F0mL0T26rYCYMEaPb8WzdTrccK0zoAHCizL21I77cejSoSyqp3vUWYVz35xtwIO N8vFuNpy MG0qo2xpYoxlWIOzNfmZkBWdlXKz18jPKt+ZCNRWxJmLYkNEzuYBo+1k6IhwoJFlA+imWyW4ug4bz6yN+I9TNRKFpwc9AdSdWpKlpw4BxeCi5l7ruJGdCsq1TjWuA3+qcIahek0N/myR6L5XdYaVi4F9xky3bfOLpvm49SA6iQ170v5t5uy/BzTbNuK12G0Y+u7Q/H5WXl82dBaogOP3VwmJM4FcFESNxh8ajxsYZMho32gy0sr8CSmXSqRwiNiIC16V6XGdFcWfJ1Sx5gy7q7evOE549TomSEAaDGThhFw+jaasfM/NmW8l+N/6OlCX4kYiFzbGzClGNJdytktVl0IAfXwvcueCquvg5GOhcCirOcZI4Y/EDApXSlkDIyWX1sYeg8I1xn2PcxqnlhXlIcGlizj7hoe42Af1zEULgI0FDX3KynoFL46m41okuu8CrYBe/t+tVjIHspeqVjeChW//NsaTNXmGgaot/Xh3fdtQGqshfavUWdTS463yzEo23872z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.25 15:13, Ignacio Moreno Gonzalez via B4 Relay wrote: > From: Ignacio Moreno Gonzalez > > commit c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") maps > the mmap option MAP_STACK to VM_NOHUGEPAGE. This is also done if > CONFIG_TRANSPARENT_HUGETABLES is not defined. But in that case, the > VM_NOHUGEPAGE does not make sense. > > I discovered this issue when trying to use the tool CRIU to checkpoint > and restore a container. Our running kernel is compiled without > CONFIG_TRANSPARENT_HUGETABLES. Like very kernel out there, because this config option does not exist. :) You only fixed it in the comment below the --- -- Cheers, David / dhildenb