From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D7ADC71136 for ; Tue, 17 Jun 2025 13:45:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E6626B0092; Tue, 17 Jun 2025 09:45:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 997706B0093; Tue, 17 Jun 2025 09:45:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8860C6B0095; Tue, 17 Jun 2025 09:45:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 70C046B0092 for ; Tue, 17 Jun 2025 09:45:37 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F39D11A02A8 for ; Tue, 17 Jun 2025 13:45:36 +0000 (UTC) X-FDA: 83565015072.30.4E5D1A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 93099A0006 for ; Tue, 17 Jun 2025 13:45:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CGO5gPQb; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750167934; a=rsa-sha256; cv=none; b=lD8zZWuj+mDBfETsggHo3kjERyzvt+0NCJyaEgJIpDMAS6zuMFCbjzuINAlSssTKUpiWQK 8Zkgx3yduVhoXXnVCJgkksbAcOJIRH+vTCGvwGl9mKn6cdGqszkZOdbXbtUpgbtPeNneax T2Ac820MuKh5JAGh7xX3lo5QF/Bbg4M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CGO5gPQb; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750167934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2wJZWv7tce/7bX9eEyOCO+Maxcn57Hdvffo3J3KjQro=; b=vbNFhNwftRl55i/oRnCjKD4bvj3Rz1MIqZJ99+vCkSTutzggFPqqmEblB6rtiXAtqKqWN1 JFR297LEt8HlAe+ARIQvlfGUGdMZQaUrnDeHIkx3ZsA7/dhGA/Xr1DvN5AvlbKDG1w35kK vlTzbjtXOByWCBJQ2EEzvFtGlYQcs1w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750167934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2wJZWv7tce/7bX9eEyOCO+Maxcn57Hdvffo3J3KjQro=; b=CGO5gPQbo6L1HM7kFbaRxXFWjJkXTqcVbh1KnMpxtGE7h916dZY8uF0Ck6+atYEXaL2CII 9auu3jM7erodDTaMvz2DZtTBDcTGnVKXCKVPvqPK3axYqtZGdFkun/iO79b0jOo1+cgEzX 1wqXU2GnYDyxIMq/2Hwtked816+diQU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487--YNrJAPOMriZenChzG5G0A-1; Tue, 17 Jun 2025 09:45:32 -0400 X-MC-Unique: -YNrJAPOMriZenChzG5G0A-1 X-Mimecast-MFC-AGG-ID: -YNrJAPOMriZenChzG5G0A_1750167931 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a56b3dee17so2150834f8f.0 for ; Tue, 17 Jun 2025 06:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750167931; x=1750772731; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2wJZWv7tce/7bX9eEyOCO+Maxcn57Hdvffo3J3KjQro=; b=a0vRkRveQmrVpS6GQGG38DIag+6WIn5fWH1NFMt2ugOHpHjpQoTdrO1qwje/crpM1R ePaGkd/lIKSnN0uK+sZYlVA0IQd+xUxCyIjBB476+Jews0iqvFPGNXABzR8uPfGYowxz 8u9zOPAKDUiJ+8t0hnzEgJdOenmr9DV9DfumyF246/ZFHEV4vRt8Cs4+p5PCqwlx4Hgf I+LXmyt0sZYqclKN3kii6uax6dguXe3S5ikjaVXrDe3asp3nm+xCsHpjEIDvChw7s28n wXLupRW4N8Ervdg+sBjX70pc0+8ewGwqdLqDML/kfY4xhHC/RQgFcN9uXgIlDxxobV1j NCBw== X-Forwarded-Encrypted: i=1; AJvYcCXf/bUq+WmzcAfQczmVpvNihbMZUROCa0966jfpRn6TAtDXWpWHakwJiUm8lsUU05IjY95g05W7jg==@kvack.org X-Gm-Message-State: AOJu0YzXMxznnGVfgSOe+jZf4fdtYJLtA4XbIfHAzOi4kPJrPdiWlLfp nCnspGBwDvJaJSxu165j7OvNJmcbwY2jz5kWxJkZLiI48FfP+bJDLT2ZeyW9ZJ2BEEmlATIKnxz 6AqwzEjB6NDAZ0v5i7uhLkZ5Wgzvze07LUqZWi2eK/kbOt+QrvZK0 X-Gm-Gg: ASbGncsw0DheXFPamUwR+6VzlyOsJNXyEi6v+3YIFg4gHr7gqB2TF+/mmLOL3mIqcGs yq53Fa5UcRVYqRA3VVFJwCkHk3Rw1zYHi0AR33TKnqEmY6mR4TCV3Fs1lTut3S/ey3OtRQHt7zv XfBbimMcLtdAM9scn7BzILTI+uo/xm9ny7eu8HytYLV/WFP+I+AR2MY8YqD7x2/SUF2LDZib0++ BH9ghbc3xBtq12+mw1SxQnPw/nO9jRTm4/T5Sl+y3b+bDSSfg60ss4Nyr5qicna+SKcILgMWPXl sNftglxxy43Jdy8ExrSSTFOCcgBK1sBZU2o2olNCK5mpT7Y9VCNFutR63ddd46Tx685IfqHX5sr dbIa9QaX4ZJRC9k9MJfi5Xzcaa0a7i2ZTpTZmeoFmj9O5JdY= X-Received: by 2002:a05:6000:2dc8:b0:3a5:24cc:6d5e with SMTP id ffacd0b85a97d-3a56d7bb11fmr11538947f8f.3.1750167930859; Tue, 17 Jun 2025 06:45:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbypEBaDDs19Bl9DuY1V8Qu3UyMIidLu0nEN7nOfiU5+Gdehh5BsZJgxN4zYE3IqruYL0KHw== X-Received: by 2002:a05:6000:2dc8:b0:3a5:24cc:6d5e with SMTP id ffacd0b85a97d-3a56d7bb11fmr11538930f8f.3.1750167930520; Tue, 17 Jun 2025 06:45:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4534172d2b0sm108385935e9.35.2025.06.17.06.45.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 06:45:30 -0700 (PDT) Message-ID: <460e16a0-c8d9-493a-b54f-2c793c969eb1@redhat.com> Date: Tue, 17 Jun 2025 15:45:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() To: Jason Gunthorpe , lizhe.67@bytedance.com Cc: alex.williamson@redhat.com, akpm@linux-foundation.org, peterx@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250617041821.85555-1-lizhe.67@bytedance.com> <20250617041821.85555-3-lizhe.67@bytedance.com> <20250617134251.GA1376515@ziepe.ca> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250617134251.GA1376515@ziepe.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: a_0TabCGEqiV_O0LhrFvOCO7_5xOiIzY-Me0qpGqq8E_1750167931 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 93099A0006 X-Stat-Signature: cqcnnd9wx19ywxkyja73zoc96zz5qr9n X-Rspam-User: X-HE-Tag: 1750167934-257797 X-HE-Meta: U2FsdGVkX1+Cwzuk7ax3+WAZuJ37S3Dytzn1mG86Mc024p84vpXr2p6pD6+8/v3C3O9/J7A4wQynqCrnOL9LqeQ7Nu3bkLAE1oMWIGDYGpDCAJhp6BATG6+bHZutxy1FiPL2tKiXZCHj909vNo/ZWpqKXOCjUhg+SH5+6zS+Q8yi8TaKNozxl+T7GUq/spO+Fi9SoAidin/ia+IWUf+nE1xZjMtVE6AVZ3XQT+7PB5cP6ya2WTCNAbX6LegZzw14duEVwxTdz0DR+4kQohhuH2HiCuqnLu4dbsnaiCL2OajibGY9qHQKYapu4XmSmivlQJus/QO4dgEZBaKZIw9AS0QZ3EmtgBLEsupn6E/v7MEY838mXstcPUpgX+MvF9lb+qRKghQhZDST065OhNZh7LX5e4oqD0JYBl17/PLfyN+aXxi+ugAiM4p94QADWXLHaEEbUhkZIhk1HoF1EXu0cJHCAqdPJr8ZudDMjNFJ3OBfJHH+eG/KcfTZisN09wATLGpgCadFFjiJSFuyjPCqcHpdJQWvdyHqwtQYMyHcOFhMQBOoyWxe+DcJMHPfXrVc1k0+keEYQI0hrddo9jeMCSgqxZegZxG9QgBawivzYufkVBveE5MVpygj6/5khc4Fuoj0mlJKK4dkcr7h6HE/xmNKJhsgR72tj10qIqbIf+Oa/H4nVmsAC301Rl5DWkRTChixJoUGmLYicqa7EgsFohLYD7iPrOr04ntjB/KQz1io7t3OsgeUMHhjSmLgH2Q0JcVB0mDfvsqjAQ7daM2mX0nYlMyhPdLWojmLuDislaxUfrLXQJ3K2kInMpgD/LC5QFWjg7wClbGSdRTaFv0vXY+8IVJZPx0V8PpGy8rHgAKqBYd5+iPKMWXQUOanvvJl8Gnnrkf0rXXvUYJjF0LEG/9Ga253Q52le+qX5S4g0QujrMyVfkEM2w42c1SaWUTz3QHbEZg0qYpJhaD6AQ7 e8Y5NFlr S3dsdZOaTZ2ru4w8deexE+tvm/SeqqCiFZ7ZUubbP8dPqpdYqbRN4vo1rHGtJH4U+KtNwMvP8kFslZa3RTyOdvWVO+jNmJTE0Cl5sURam/eEjwgjsfcZgDA1wRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 15:42, Jason Gunthorpe wrote: > On Tue, Jun 17, 2025 at 12:18:20PM +0800, lizhe.67@bytedance.com wrote: > >> @@ -360,12 +360,7 @@ void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages, >> >> for (i = 0; i < npages; i += nr) { >> folio = gup_folio_range_next(page, npages, i, &nr); >> - if (make_dirty && !folio_test_dirty(folio)) { >> - folio_lock(folio); >> - folio_mark_dirty(folio); >> - folio_unlock(folio); >> - } >> - gup_put_folio(folio, nr, FOLL_PIN); >> + unpin_user_folio_dirty_locked(folio, nr, make_dirty); >> } > > I don't think we should call an exported function here - this is a > fast path for rdma and iommfd, I don't want to see it degrade to save > three duplicated lines :\ Any way to quantify? In theory, the compiler could still optimize this within the same file, no? > > Make the new function an inline? That of course also works. -- Cheers, David / dhildenb