From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4519EC197A0 for ; Fri, 17 Nov 2023 05:43:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE54C6B03E2; Fri, 17 Nov 2023 00:43:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B94366B03F4; Fri, 17 Nov 2023 00:43:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A35F96B03F7; Fri, 17 Nov 2023 00:43:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 94BC86B03E2 for ; Fri, 17 Nov 2023 00:43:32 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 74BDBB60C4 for ; Fri, 17 Nov 2023 05:43:32 +0000 (UTC) X-FDA: 81466353864.26.AC8C1C9 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf09.hostedemail.com (Postfix) with ESMTP id 0D6AB14000B for ; Fri, 17 Nov 2023 05:43:29 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=M54trlkb; spf=pass (imf09.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700199810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EwGl2Raou1wlZbgyA4gj3IIYc9SXGYbAdpUH+BDajbQ=; b=iwoOmSxj9vJCEvDowKXGxvcq//IytnNk9NXVBi47vXtz3ueIn82L/3ywtIGYBd1x7d46Uw wQKH7wOZKu4+FlhhJa1rO+fv30g+mrnlBVocX0QgBJJnaDAyQl53uzhwBlFrq84blh5Ub7 HgwKlgbyTlUF7Wy+Fd9Q2oGsykg8/H4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=M54trlkb; spf=pass (imf09.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700199810; a=rsa-sha256; cv=none; b=z24EIP+n3Uu2YiccbwS9ERsurAX1gdbjR9cRejtm2HAjf9DNFo7rfUdQtgi2U7nvkw8z+m 0rC1ibeqSUuNjJTfzPzvMOK4YJ3xBpEnbEnNSsTW8TG+sWMjk6J80Iq/A2uzlDzHCQMbmH Apvi3u3714uEcTDNbmm8Y1rudQvIb28= Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AH5cX6G022114; Fri, 17 Nov 2023 05:43:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=EwGl2Raou1wlZbgyA4gj3IIYc9SXGYbAdpUH+BDajbQ=; b=M54trlkb2i4UophFTxb6BvH1lUcpVdKRhLWFyJLbsqKmYjiWfZdoqKJPmjinEj//GzIq tjEQzWeeYzjPFoTeWmcvutLWRNwEF7l2iuA4zeSBpIF/78ZGLS6GavSkUXw6nykIKpMm U070KuSIDEfiMbGp3Bu5T/t+r20bQPRdUKmm9JFGNuzeIk5Su4esE06Rutyc5k0oin2o YTXgsPo6pTna7iVyq/ECQnMYKLfuXvVG7KmnEgO53vpVVyYOwXEh6XDCJH7/KydyMcNO 0uJgejLlDiXogxQUodzRfK3QBPMMhAXgx65xr3LsOivnqB9GcNxKY7tayQ2Lf7AcmQCE Gw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3udmw41tc8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 05:43:27 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AH5hQrR006839 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 05:43:26 GMT Received: from [10.214.66.119] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 16 Nov 2023 21:43:23 -0800 Message-ID: <45fc0324-4a1d-7b2c-6cbe-3755056d5981@quicinc.com> Date: Fri, 17 Nov 2023 11:13:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 3/3] mm: page_alloc: drain pcp lists before oom kill Content-Language: en-US To: Michal Hocko CC: , , , , , , , References: <5c7f25f9-f86b-8e15-8603-e212b9911cac@quicinc.com> <342a8854-eef5-f68a-15e5-275de70e3f01@quicinc.com> From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: zyDbRmouoK97QZQYJmqa0ZJBhzr0aezq X-Proofpoint-ORIG-GUID: zyDbRmouoK97QZQYJmqa0ZJBhzr0aezq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-17_03,2023-11-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxlogscore=661 clxscore=1015 suspectscore=0 mlxscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311170039 X-Rspamd-Queue-Id: 0D6AB14000B X-Rspam-User: X-Stat-Signature: 9shj1kr3c5zywscmwuzuwppwxuqd36qk X-Rspamd-Server: rspam01 X-HE-Tag: 1700199809-502230 X-HE-Meta: U2FsdGVkX19G0DYGtHWRxQDBNRlW0duqRD9aYkVGlCbEh0v0txPheoGEtT222mR12Ogkh+A/G35KzxrYh6t6AjkIC4ASZvIQJicoDk9OiPgBn82KmZFduR5LQoImyAQo9hpGf61pVmgAxdjmp5kOeqXTV+8Z9HDJbhjrbzraLiTvJO0j07WRt7MRL0myuEhjSFqbcAsam7aH0iNaSB94xNvC2hc5Q5qEfOZnC+B81ZYn6ZBn1eI04waMMDEMwbTVwH7IE5sPEO1JCLBn/3MTEvZRWkh8uZyH/T1VJSQ9kVX6LjpyQoRtXipussh6snFQd5T2S6AZ9IZ2IcWvFtAb/yKIasx1OXQVowCwMu30GT0576RJxK4TcWVVo1IsNXIrifG+Nvm/sF9JCQaw0Y+u2q+zoNjKuk0+qkRE0wvmOIbpMtnkXr1wdZlMnfO0G7IYaVpz9/dRPsov8l32M6WM8QoDlvL5ng14EXok57mpE5kifjJNSlCCCFlsiRu/BVgdCAMEygvqkm5MLmTIj5MSo4oukjLsepA5dQz21RpJ7ZQ45Fr05kJ8jEiv5QM/N8KVZ5h2O5HGCpySFvv7i2A+EoGURNULcAZyg8o2JFtTTvfuzAp/mSVto8BBf7sDm8CzygywmLPL7Ph+ZQ1hq940+kvojIOZsxyrs9QKdqaAM0KHUfq/kAbWu6VU7LpCBCxuOMyAj/expN827Jh6SU1KhQemjyUE/Xn9nytUojB8EUBezVQl0zzTdrwTrGHvTOF1esBuqO1bRyKj+XpZcJTkmzHQXBwLpb/2EC7vYIMJbP92NTAGLShX1YTHonmBH28RJZmExG5IUss1OHBl2cB+/Ok3Pz2cNAsSPr8y8MYCmJxzl82qxlpn6PYd0JcqyaiS37Uzlo9Zv5f71GuUsUtSx5u711EDGQuZ7F/7aZHUC+3TogpxnOrVTsvpTHC2j/vUFcI2p/QKHI0rROmnctS xCBbe37o A+tEE/0TbFj0ZmQVMzGgofGQ/lWoagU2V+q8X/SJpKbY5WX8RrLa7WKaPyMdddmqD0tNIOQJOLuney3wvVQleptZ/lkahGx5w6LP1i1f9Xr0K68+NpLbkw03Ehpa4yngqubrJc/mGfpKdaOpkx4Tvdf43zIsFLn/Mzq5K1a38ZSF6Ic/RDMBnyL0+ZtKFqAEukmGQNg+/CJO0KdpHLlMZdQ9uM/aXuPIkV8w1eOp1h8jrtfMksXS0tLBAaxHrXI82nZTNzLu61EsM74IjSRXXacvpy/nVK0+zKKMS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks Michal!! On 11/16/2023 6:25 PM, Michal Hocko wrote: >> May be other way to look at that patch is comment is really not being >> reflected in the code. It says, " Limit the number reserved to 1 >> pageblock or roughly 1% of a zone.", but the current code is making it 2 >> pageblocks. So, for 4M block size, it is > 1%. >> >> A second patch, that I will post, like not reserving the high atomic >> page blocks on small systems -- But how to define the meaning of small >> systems is not sure. Instead will let the system administrators chose >> this through either: >> a) command line param, high_atomic_reserves=off, on by default -- >> Another knob, so admins may really not like this? >> b) CONFIG_HIGH_ATOMIC_RESERVES, which if not defined, will not reserve. > Please don't! I do not see any admin wanting to care about this at all. > It just takes a lot of understanding of internal MM stuff to make an > educated guess. This should really be auto-tuned. And as responded in > other reply my take would be to reserve a page block on if it doesn't > consume more than 1% of memory to preserve the existing behavior yet not > overconsume on small systems. This idea of auto tune, by reserving a pageblock only if it doesn't consume more than 1% of memory, seems cleaner to me. For a page block size of 4MB, this will turnout to be upto 400MB of RAM. If it is fine, I can post a patch with suggested-by: you. >