From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E7BC02187 for ; Thu, 16 Jan 2025 21:00:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C04F6B0082; Thu, 16 Jan 2025 16:00:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56FD16B0083; Thu, 16 Jan 2025 16:00:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 410676B0085; Thu, 16 Jan 2025 16:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 21F966B0082 for ; Thu, 16 Jan 2025 16:00:43 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B8F97141261 for ; Thu, 16 Jan 2025 21:00:42 +0000 (UTC) X-FDA: 83014533924.16.580B083 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 9A01D8002C for ; Thu, 16 Jan 2025 21:00:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=krLzUDGJ; spf=pass (imf30.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737061240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yjk97imBnKIfiyfiWXwvHSWjkC0UabJBaiHXXMbZsqE=; b=Y2PEB5DgahhMPqWqbAkcInlaK/NlNyKvaCDQmkxAAar75HF1ULOd0WGBu1DOKM9VYg5XI6 fe2+vTg9d6GiSckkOKDQYzMQiRUPALtQSC3Vht3uCwVl/hfHxsYe9jawSVEu3AwGCnTH9W zVakCuOc5VLuUbNn2as99wyhEwb/yPA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=krLzUDGJ; spf=pass (imf30.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737061240; a=rsa-sha256; cv=none; b=xDg6w6Pcob37kNF7wEGBc5hblmUKb4eiJE1fan3eWeiiIssqKCFjyRTPFSMCq61DRr7ge8 rgF8nUjVHsNJT6oT+/9FPgIiP3QwjEbkEEYyeaLVkgWkQiLTRAXxyRdqTLIwF+lJO4aaMn mnvvdw48Z2q2THmzXCg1FCePBs78sLs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8308E5C5FD3; Thu, 16 Jan 2025 20:59:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 128E9C4CEDF; Thu, 16 Jan 2025 21:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737061238; bh=ei48WzDzQXjwdLn3xeNuV6Y9soa7jumN+VhYVf6oIbQ=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=krLzUDGJpvLy/t9Kt5pMwTh4Uez1IeaoqrxvB8XYpPZgBiTnhXx4WRFQUowinmlzn mRd7JZZtv/4faOqBd3sx4rT9ZKwaCYL17MWmvA3cPeiZ4C/X3JDh5iIhEbfp2u6hEE tMcHiOKCOMg0c+f9JGDQQeZMo2Hy0tiwzByswP6RQJZ2BrF7RRLWOnhFVxFdXbWaR1 4YHKEEvilbrEG2rQafVavGW3VRP7kyVKE4Mw287KtrZwmyrHbWfMS4c5J3qeE9EMZ5 NEqrqzzZ/4AzOrS8iZWTVjTXJxC+6RLJ+os16QqA8uukEZGLCxL9bltC9YfSkGdtKl Gy0sHHYDs+8bg== Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfauth.phl.internal (Postfix) with ESMTP id DAAFD1200083; Thu, 16 Jan 2025 16:00:36 -0500 (EST) Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-03.internal (MEProxy); Thu, 16 Jan 2025 16:00:36 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeiuddgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdfnvghonhcutfhomhgrnhhovhhskhihfdcuoehlvghonheskhgvrh hnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpeejvefflefgledvgfevvdetleehhfdv ffehgeffkeevleeiveefjeetieelueeuvdenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghonhdomhgvshhmthhprghuthhhphgvrhhsohhn rghlihhthidquddvfedtheefleekgedqvdejjeeljeejvdekqdhlvghonheppehkvghrnh gvlhdrohhrgheslhgvohhnrdhnuhdpnhgspghrtghpthhtohepvdekpdhmohguvgepshhm thhpohhuthdprhgtphhtthhopehjohhroheskegshihtvghsrdhorhhgpdhrtghpthhtoh eprhhosghinhdrmhhurhhphhihsegrrhhmrdgtohhmpdhrtghpthhtoheplhhoghgrnhhg seguvghlthgrthgvvgdrtghomhdprhgtphhtthhopegshhgvlhhgrggrshesghhoohhglh gvrdgtohhmpdhrtghpthhtohepshgrghhisehgrhhimhgsvghrghdrmhgvpdhrtghpthht ohepshhhrghmvggvrhgrlhhirdhkohhlohhthhhumhdrthhhohguiheshhhurgifvghird gtohhmpdhrtghpthhtoheprhguuhhnlhgrphesihhnfhhrrgguvggrugdrohhrghdprhgt phhtthhopehkvghvihhnrdhtihgrnhesihhnthgvlhdrtghomhdprhgtphhtthhopegrgi gsohgvsehkvghrnhgvlhdrughk X-ME-Proxy: Feedback-ID: i927946fb:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id A17001C20067; Thu, 16 Jan 2025 16:00:36 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Thu, 16 Jan 2025 23:00:14 +0200 From: "Leon Romanovsky" To: "Jason Gunthorpe" Cc: "Robin Murphy" , "Jens Axboe" , "Joerg Roedel" , "Will Deacon" , "Christoph Hellwig" , "Sagi Grimberg" , "Keith Busch" , "Bjorn Helgaas" , "Logan Gunthorpe" , "Yishai Hadas" , "Shameer Kolothum" , "Kevin Tian" , "Alex Williamson" , "Marek Szyprowski" , =?UTF-8?Q?J=C3=A9r=C3=B4me_Glisse?= , "Andrew Morton" , "Jonathan Corbet" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, "Randy Dunlap" Message-Id: <45eee716-83fd-4b15-ae11-2414aa119db3@app.fastmail.com> In-Reply-To: <20250116201853.GE674319@ziepe.ca> References: <20250115083340.GL3146852@unreal> <20250116201853.GE674319@ziepe.ca> Subject: Re: [PATCH v5 07/17] dma-mapping: Implement link/unlink ranges API Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9A01D8002C X-Stat-Signature: fbofkghduy3h7k1su8rtop9ujub4yxw9 X-Rspam-User: X-HE-Tag: 1737061240-184405 X-HE-Meta: U2FsdGVkX1+E4gxV+IxZk9bngKMNilD8qS6feWDhqRxvIoh2d6Rk8DDPmoclvyTjs2KTCcvgI+0ZmzcJfUIudVMXu7rN7IYDlvq+UHJGCUdg8yejodWQrRmC8bueYc329ABGrNGXjSF5V7GdV3yNPUy+NRE0qplYf+TVBopgUDWwCD5eNH4vGACs+XW/SCBkNU16o7Pq9aI/a5OAEUvOGfTnXXm4VJU4IlYelDKhX96mteC2xW8Pvis4RZlF7kOam8kQkhibkRDrA0zCWSM1Z0G0kgV8Zza0NbcuQQdcUjrlN0t349YYgAAhVyV8wy9ELzLLn+3DhDvsbM4Bl/M7pboKJOIID1hMhpPs4U/qqODkzpoepvoX+A1sraG2qlAyHw9un4Uk2bjSg1E75EFRdvOW0GPsEnF91+iNEvFfuVUOfTwlcsBDsqfBcvxnyJpdYSOZUZhyP7dyORALuRMLQewn4kKjYu2upzbccdZeL7KJtfDy7/z8mPa9V+JbOYYATYoW7MmBlvobVHKKHp/hMNOlWwhHaVHi3tWT5sVbCyhiWAkA1NJjryUjHcdSdOspAbStRpDqUHU7xFxZ0T2LMV6/jW/DdioZWyJJ5czq0ceyjg1vabV0gQiZjHxMLDjRosX8O4wMlFBsokwmQjkw5RHUClWfixLqbiH+gSSAbqVvXbf+pDjjdM4W+d5k3h2whqpI2mmNxNoDuBLzPAYe0HPFr9cCaP9BcTKwetCtRyXabusZkgSmFkFG0L7xXSbpFfxoqY6ZuyVZhJHFqeTGUgFlb/67AoiW3vx+/w2NjKCU4solYhrTOE1ORSPYkcqYYCO3CMEtivotxWEoJIzSxR77c5JuMu4zcq+1omnvBQIQ9C9RbZWGMZsORbS4MyV+ZpmRhVXIEIFbqlX2OUid20QKcL+Ud1UVCEop46LTs/pmk6C7UAlX0GewdUOZ0Xo9Rlx1VJ32H+JlnBfnrI0 HoXbx4F7 Susa4ACU1swW+qOo5/e275y4HS5zivFBXwwNyg/JcqrOJHj6yZTNfj0xhvjYD69ir/SL9Bq+5UUk+oTNFXcFjffvhOisJb3X7s8C9h8vO5ggW1Sv6JM9pPW8+V+HYfgkRkIsO57vj8dZK9ER3TxBUQRedbneX7roKlR506TPRO2eNMU8dwCWvpMwGieBIa4aXrzur X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 16, 2025, at 22:18, Jason Gunthorpe wrote: > On Wed, Jan 15, 2025 at 10:33:40AM +0200, Leon Romanovsky wrote: >> > > + do { >> > > + phys_addr_t phys; >> > > + size_t len; >> > > + >> > > + phys = iommu_iova_to_phys(domain, addr); >> > > + if (WARN_ON(!phys)) >> > > + continue; >> > >> > Infinite WARN_ON loop, nice. >> >> No problem, will change it to WARN_ON_ONCE. > > I think the other point is that the addr doesn't increase, so this > loop will lock up. Yes, this is what I planned to do. > > Possibly just do return? I suppose something is hopelessly corrupted > if we ever hit this.. > > Jason