From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE325C7EE2D for ; Wed, 1 Mar 2023 19:10:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 365926B0071; Wed, 1 Mar 2023 14:10:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 315886B0072; Wed, 1 Mar 2023 14:10:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DDAE6B0073; Wed, 1 Mar 2023 14:10:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0EB2D6B0071 for ; Wed, 1 Mar 2023 14:10:32 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CEA23140A68 for ; Wed, 1 Mar 2023 19:10:31 +0000 (UTC) X-FDA: 80521270662.01.210340F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id C6A812002A for ; Wed, 1 Mar 2023 19:10:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UaLSUnMO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r0USI+V0; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677697829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mbm6Hwho1WNEO+BzUCGTeM2WNbgC07zt/Pe/XjjbxP8=; b=piHI2fMvA/2epB6sgyvzTgFPO1GaOtAJCtKiD0xWHxcuZM+7J1lGC5pEFZ+6ZLM3GzhOKI EJ43kThWiob7SHnCkf7v7N3aC9ZYG/ihhXF9cgtFzyb2Nc5LwCV8dFofeNmu+EjcpnnvqM aBL1BAYms9966vwF28VUWeS3XGp9Agk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UaLSUnMO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r0USI+V0; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677697829; a=rsa-sha256; cv=none; b=XqtjVnuxyXk2auyb0sBBfJ6DOGLnJ+QDBeVOB4kZ+6M5KUM/rlNDmcfGrY6oKAIoGC0ZoF ZcpqTWV42BEqoE9IGg+KcFFBifAqEMC8IRmnVGIFjG2is3Ogmhe6OhZHHvk+RcBA/LNqEn uqJEClpu7sbT4o3DC1zgE1qIG6/SWRE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3D50221AA0; Wed, 1 Mar 2023 19:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1677697827; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mbm6Hwho1WNEO+BzUCGTeM2WNbgC07zt/Pe/XjjbxP8=; b=UaLSUnMOLqw92deEICinMO9G+XAH3yoGNclRLm5drBrvf/iUP/BaAkuikou+RnmROklirn CTIPE/4Cef6BY69ssfeaxOrSF/IGA0DSvIuUZ+rYeop4PiLZRZPBIUshcg/jn19P60iVj4 XfG3MCPEyo/z2i5Mxw/50DW+CRF6UUs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1677697827; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mbm6Hwho1WNEO+BzUCGTeM2WNbgC07zt/Pe/XjjbxP8=; b=r0USI+V0HHR4+6Q6kJq1fsby09KOrPDMJa5L46F5Objy/+KZ0gaNKXnLcZEHDMipRV2NsV g2zIL26UvUI3hIDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 174DD13A63; Wed, 1 Mar 2023 19:10:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +Oi+BCOj/2NcUwAAMHmgww (envelope-from ); Wed, 01 Mar 2023 19:10:27 +0000 Message-ID: <45eeb539-ed82-4984-197b-3f88cd765a59@suse.cz> Date: Wed, 1 Mar 2023 20:10:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [linus:master] [mm/mmap] 04241ffe3f: Kernel_panic-not_syncing:Fatal_exception To: "Liam R. Howlett" , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" References: <202303010946.d35666d1-oliver.sang@intel.com> <20230301165036.mal6lkb6qhpjyz2r@revolver> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20230301165036.mal6lkb6qhpjyz2r@revolver> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C6A812002A X-Rspam-User: X-Stat-Signature: zu7q34aurs837xar61hxt4miustnzyo1 X-HE-Tag: 1677697828-183329 X-HE-Meta: U2FsdGVkX1/mmHFBXG5gBSJwajmCb10KjJN3d8Dne5CWAs2MjjCIicQnXKmYNpGuvtQac7DQKTriHX3apQJwgJaTMKnGddEK2ic0ctubtoSuIMCOrb9aI2fWiAHu91U2NE1FhwabYWeSk+kdhQdC1y7lhaop5X8K5fZyHZPk1Xhm1FWhmKqLi2QudyV/Sa8fJQM7si9Oqp5FHkKxGZQKwMas0scJ9a0A5SqjSzZeibOcuitqXswk1TQ5k/EcyLeWe/QFTE0TnYtNSbVlZtgvtGWNIJMGhVQM9c7OfZUgQdpE8nlYnfZ59lgZP+Ys7K7ox2Q4yN5GGiGj78HU8gwr0udjmlubNBf8nqyWgcijyJSaPCldrh45Y+Z5NX2ZJ25nV6NBcEOlcG9OHtbm2xdhaPtaNZ0SRBXvH8KXMkpkNf+ecW1V9jWTLzOFdmouHND6RZScLLQuK7MU+QJ164i1gAsi9aLemK7lCDDd/ltma2keuzF14Wur1XZf7TuiHJdSZH3vxbrxtXejTJJwqp+jHEoMcAjToIvIqk3GYhLYiNzYkQ85o6zADKaz2ktiI29yrAgMywA9/DPlTOfP745Zd8zcAF7lO3J4m3k1h+aQywn9rkDwsUNc0JILIX+PDetxb74j5agDi8ARtE+6MkUl9E83le9izSScGVJAHmqlH6BbB5SaMiB8E3kSO6JNMWALkh5MqUOcFiqYnEf79qGHr+1FxjcG88s9M+NEU7uc2FIlaFplUFzAj28xAHey2jm0Z8C700bFv+SZmFf/0vPAjhzFouTqTPSjoyyOrRJwEBadZZTp9wgDfGevFRyJwI3vaUpef+TDXCUtTqn2AeKSi3dy+b7/9Iv9xJbjjtvzkjtCHYymiXPYtphh9LzIGVJiU96Me8UGRjG7QpqAMnTD9OS2cys9+EBEOZACPbXvvqq73eINcKRABKv5NmFGTGLQPuN5uip0Rn6sz+YLp/D /bgyEII9 lisClqvhHY8mB5Lklg9NOeCh/gjwhJxEPpiWDn0KQWeo3dceFmRlGZP6nMX0K2fI3elAjOaYC+bllbVMWeHlEH61yH0Uss/nAHL9xfI3Giju7feEFDQMN3Of7iKzxgduOUy3SqU4iXvSjbY68ZlsN7rVjtxx66kwAeoSpp2qxJFmKXig+gfhxIOrJrnqFWMvRcSZ80oMW9pE4wiJ4I6FXsZGch7vePu6d95DSNrsLxaSoiccpdG6bLk8a8lXCDL4ToCoKaLHuVfcnOe7+NqG26ExFygcThp2jmjgkbl+iQzmFKZQNx9Psp3z7xF7f7ucPcgMRL+pntvpfQDyTzi2C6zI8Lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/1/23 17:50, Liam R. Howlett wrote: > * kernel test robot [230301 02:21]: >> >> Greeting, >> >> FYI, we noticed Kernel_panic-not_syncing:Fatal_exception due to commit (built with gcc-11): >> >> commit: 04241ffe3f0458d54c61cf6c9d58d703efda4dd5 ("mm/mmap: introduce dup_vma_anon() helper") >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master >> >> [test failed on linus/master f3a2439f20d918930cc4ae8f76fe1c1afd26958f] >> [test failed on linux-next/master 7f7a8831520f12a3cf894b0627641fad33971221] > > I tracked the problem down in that commit. The fix is simple enough: > > ----------------- > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -802,10 +802,13 @@ int __vma_adjust(struct vma_iterator *vmi, struct vm_area_struct *vma, > * If next doesn't have anon_vma, import from vma after > * next, if the vma overlaps with it. > */ > - if (remove != NULL && !next->anon_vma) > + if (remove2 != NULL && !next->anon_vma) Oh I actually did notice that one too, but as it was only temporary within the series and already baked into git, thought there's no benefit in pointing it out. A problem for bisect obviously as was just confirmed. > ---------------- > > However, that will not fix the problem in linux-next or linus/master > since this code is completely changed shortly after. > > You need the fix from Vlastimil (Cc'ed). After cherry-picking > 07dc4b186203 ("mm/mremap: fix dup_anon_vma() in vma_merge() case 4") on Which tree is that? The mm-hotfixes-stable commit is here: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-hotfixes-stable&id=4c6759967826b87f56c73e0f1deb7b76379ccd23 > top of linus/master, I don't get this particular failure anymore. > > I do get the "kernel BUG at mm/filemap.c:155!", so it might be masking > another problem. (Added Matthew to Cc) > > I think the right thing to do is to include Vlastimil's fix. Great, thanks. > Thanks, > Liam > > ... >