From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA85BD18158 for ; Mon, 14 Oct 2024 22:30:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E7006B0082; Mon, 14 Oct 2024 18:30:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 397596B0083; Mon, 14 Oct 2024 18:30:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25E716B0085; Mon, 14 Oct 2024 18:30:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 06D526B0082 for ; Mon, 14 Oct 2024 18:30:36 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 98598412E4 for ; Mon, 14 Oct 2024 22:30:31 +0000 (UTC) X-FDA: 82673653062.06.657C011 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by imf01.hostedemail.com (Postfix) with ESMTP id 0E24040009 for ; Mon, 14 Oct 2024 22:30:28 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=fYhYRz0c; spf=pass (imf01.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.167.177 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728944962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2nxU2mZnAYX6T6eXg9lnZK4zwF7VD1vbXC0Zas7xojQ=; b=kz4NDFTezkL38EdLwZiXGyeLRYRCPD/OvN2WXx/yv4cOyhdbIONyB44Mktt92DPEdKZP+a kSVAkWmOJ0udZkKNMWY+J+fWMWOmVbMTuWDeMEkZFjNkJIf4ofDpt+rwOHPZjauNqzOdmg rko0NM5mSD79WtQDLFKhbTOdFO15DEI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=fYhYRz0c; spf=pass (imf01.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.167.177 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728944962; a=rsa-sha256; cv=none; b=wNbrDjTJnzui4G+c4jDdKzjotBbAYZpBIGnIIb3G3ecvpF4tE3IgvXtAwXDRbC/vrQ25Ap ZN9R5u+jgDEC+q61BF+L7onVdv71MTh4PdIgpVvWo6PsA9CJbQ6y4jTnWLQ2V2TloG94W/ FfmIXp8U/wfETlSoYZhyLjTRs91ZEJM= Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3e4d624ac28so2966993b6e.2 for ; Mon, 14 Oct 2024 15:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728945034; x=1729549834; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2nxU2mZnAYX6T6eXg9lnZK4zwF7VD1vbXC0Zas7xojQ=; b=fYhYRz0c0+8AmzGiP/Pk6pwqESpDpZq6NrMlpU8jMLJr9ZwWDjvJmHkn9Pud3tmzao lAH00A9Q45VeEZnAJY7TDOljCl1C2GL0Qyb33A7eKGcd6Mz9+DBbq06ZO9/mtNdKYPfT p1K+B92Uhx5zoQRtYNtsvdjnMgRanIaaRfnCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728945034; x=1729549834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2nxU2mZnAYX6T6eXg9lnZK4zwF7VD1vbXC0Zas7xojQ=; b=BHv9iMO+9SlwKahQEFO5eLRZxtdnnpag+75mUbVjrPYluyl8C935Om41n4xAHQ/hF7 CixJjGrtQIXr7MbZ+vf8tCi2ElfwmFK2Jyqreiww0N2HMKKRAdDTZ5dW34OWF1O7gfgs 2DGqYI4hDNLYtAbMggkCsynTxdZXB+gIzRd8An4B8sfWHHSnckFjVIpyDwg3ezRw8sBl nCn3uKKAMGAdOEajy5RW0VH+/1TQeAuhdeCHWbrhU6XwIDZmmdr8y4VU/pb1V5W9Ot5v dvek44ZGi7wRbxBCmDFzKJTZf6zZgQ9JAWjfFnW7swO9R9g10Zoi1aQ0YFgpU5gf+CpT sVSg== X-Gm-Message-State: AOJu0YyRNlpeT9QummJhfBtwCIHHgbCYFpnvudcA58+DXqdV4sWE/oSo eawnIEUQTn99jdAdNNZ7grmRM8tCAo7lnxjeQ4dd1HVDtC4VZlF/b2GVjwYlB6Y= X-Google-Smtp-Source: AGHT+IH1wFzvJxpp/AlsgSPi+jtIbJy+RDZllf8eVWiv10gC5XaakWgiqeWYKHUZ37GMC26ba9Uyfw== X-Received: by 2002:a05:6808:152b:b0:3e2:7e47:fddc with SMTP id 5614622812f47-3e5c912039amr5484537b6e.34.1728945033696; Mon, 14 Oct 2024 15:30:33 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3e5e8562044sm19511b6e.7.2024.10.14.15.30.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 15:30:33 -0700 (PDT) Message-ID: <45e3235e-17a8-4f2a-8ecb-a66542dbaf34@linuxfoundation.org> Date: Mon, 14 Oct 2024 16:30:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next] selftests: memcg: remove useless code in test_memcg_oom_group_leaf_events To: Jinjiang Tu , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, shuah@kernel.org, jgkamat@fb.com Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, Shuah Khan References: <20241012021057.993520-1-tujinjiang@huawei.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241012021057.993520-1-tujinjiang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0E24040009 X-Stat-Signature: cfnnqhmtyd1htcd15qwnq8drisr91pae X-HE-Tag: 1728945028-834650 X-HE-Meta: U2FsdGVkX1/Ue440Rk6p5ibfsR6BwmGERBvh2mviNydATmIxstqI1vpBZkFGrx9EIX/SeYSP6zmW9kXIvR3QIc4Q71tPPbjAkkpAa7/a9dEnm+B9mx2rKLNhNJrJX93Lu9S4C14rwN5lNat4GNsiNieiL/4NoyzxihfSuSk0bVJk9jqYcpWFQ9KULohUwko03fTBD1FjRFCGtXfpasZwN9706gof0S20ln3Abxtxk3e/8cBajoM6YcU6Fu3/0d2vRpJGtUN0YTm0OsD3iqmeT9jM6xVp3+cnG3Ur9cXXts7OFGjSN77ZQdcXqO3ljjVbYTrdHvjU44TCpuEwfXO38kcTc4AoNykhcGk/7WnnTLBddC4IY4m7T4+DcustC8JJlgRlg+urv/GvN6aKRle9omDuOxd8sM5H1xJ2w+tuHZr8OceaPtvjE8ok2KRrQjy7NmgQ0mtfjhfUbfhhVdrYrI+z2fTPHQp3POF+3YsSBBcgK2WnH4e0mvAxg3rDJnXQkU7ElmK2x9MttAwRjqJpljs3vYIdyFQkceVDEg6WQApG7uqk+ASTaeBsPBdmIqprxMTUzHSRGzG6/mZsG9IyMoNL50b1DsJdz2pDr9wfaX5ewV9YtCBi7EU7xbQq2flyfJ3mVf+y3G3QIrnW+5RazHzADXaClba10CoKXbKLv6by1xJ8kcid75wkAf/8zRvNyYwwIPggOEMajJYYHqrCN4TZQBQiWsJQW+RPgA2o4wvgYPf1+hKfx6XuTCFKRtHhDFqgGZxgz9i6QQvQSY89+y+VolSk5x8LXc+7ZKuDElmZMMb70NSmqIXbH0BY9bCKSAcV+BrBiHnEf95kU0kHgf+KoV3a2VfHjVCqWHojY4AR/ftwQRGtYWYB9R6yt7yGhl6LyC+iuG1rMYZNHJZ5dkPUUV6m0uFE+tySlezu3WAfNn10uGKGjzrkTS99AxOPvRETXtGmHKG2lUIARP1 7XSonXfZ HGecVZa0bd415JaqR2qr72Y4RuJwJdcthsfauG9pTHpcdQK3Rzb8RgmwqDh7JXwqfNyp9VdjzhK+mig69odHZ+UIaWHFWkiGOXyLK36hA7UhGzksXtJMzmo0L9sCvkXRxcEKoYSF5DZGRseX5YNRv5Bv/5OEME4X9G+3Is9C7iAy4HsHXTtuUf5DHC5Z5277c0ZUyLWE9HUjoE4mJ6dTa2pPqwJ04iRrB2xCdZSFng4AJ8d1ZXJvGGDvGUMIEfk0y4HZSixFX35kA1+8pK4mcf72ceDG6460KMRK17tbSD6kvWtAdisE/RqViGXo24nPYU18umz273F9bAiavacea8xwZCcLfz0PN+yDxsGE53j3EabNEi4is+TySRYgM/b+Xv/v+3IdnvGgnkDPiC/54OLTs3TWFHdLDYD9I5Wdaac3T9ZU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004116, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/11/24 20:10, Jinjiang Tu wrote: > Due to No Internal Process Constraint, parent cgroup couldn't contain any > process, the code `cg_run_nowait(parent, ...)` fails to execute and > return -1 in fact. So remove the useless code to avoid misunderstanding. > Hmm. wouldn't this make a good regression test for "No Internal Process Constraint" Why would you want to delete it? > Fixes: a987785dcd6c ("Add tests for memory.oom.group") > Signed-off-by: Jinjiang Tu > --- > tools/testing/selftests/cgroup/test_memcontrol.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c > index 16f5d74ae762..1be36cff72a0 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -1392,7 +1392,6 @@ static int test_memcg_oom_group_leaf_events(const char *root) > if (cg_write(child, "memory.oom.group", "1")) > goto cleanup; > > - cg_run_nowait(parent, alloc_anon_noexit, (void *) MB(60)); > cg_run_nowait(child, alloc_anon_noexit, (void *) MB(1)); > cg_run_nowait(child, alloc_anon_noexit, (void *) MB(1)); > if (!cg_run(child, alloc_anon, (void *)MB(100))) thanks, -- Shuah