* [PATCH] mm/uffd: Fix comment in handling pte markers
@ 2023-02-15 20:58 Peter Xu
2023-02-15 20:59 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Peter Xu @ 2023-02-15 20:58 UTC (permalink / raw)
To: linux-kernel, linux-mm
Cc: Axel Rasmussen, Andrea Arcangeli, peterx, Andrew Morton,
David Hildenbrand, Nadav Amit
The comment is obsolete after f369b07c8614 ("mm/uffd: reset write
protection when unregister with wp-mode", 2022-08-20). Remove it.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
mm/memory.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 7a04a1130ec1..f456f3b5049c 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3627,9 +3627,7 @@ static vm_fault_t pte_marker_handle_uffd_wp(struct vm_fault *vmf)
{
/*
* Just in case there're leftover special ptes even after the region
- * got unregistered - we can simply clear them. We can also do that
- * proactively when e.g. when we do UFFDIO_UNREGISTER upon some uffd-wp
- * ranges, but it should be more efficient to be done lazily here.
+ * got unregistered - we can simply clear them.
*/
if (unlikely(!userfaultfd_wp(vmf->vma) || vma_is_anonymous(vmf->vma)))
return pte_marker_clear(vmf);
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm/uffd: Fix comment in handling pte markers
2023-02-15 20:58 [PATCH] mm/uffd: Fix comment in handling pte markers Peter Xu
@ 2023-02-15 20:59 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2023-02-15 20:59 UTC (permalink / raw)
To: Peter Xu, linux-kernel, linux-mm
Cc: Axel Rasmussen, Andrea Arcangeli, Andrew Morton, Nadav Amit
On 15.02.23 21:58, Peter Xu wrote:
> The comment is obsolete after f369b07c8614 ("mm/uffd: reset write
> protection when unregister with wp-mode", 2022-08-20). Remove it.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> mm/memory.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 7a04a1130ec1..f456f3b5049c 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3627,9 +3627,7 @@ static vm_fault_t pte_marker_handle_uffd_wp(struct vm_fault *vmf)
> {
> /*
> * Just in case there're leftover special ptes even after the region
> - * got unregistered - we can simply clear them. We can also do that
> - * proactively when e.g. when we do UFFDIO_UNREGISTER upon some uffd-wp
> - * ranges, but it should be more efficient to be done lazily here.
> + * got unregistered - we can simply clear them.
> */
> if (unlikely(!userfaultfd_wp(vmf->vma) || vma_is_anonymous(vmf->vma)))
> return pte_marker_clear(vmf);
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-15 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 20:58 [PATCH] mm/uffd: Fix comment in handling pte markers Peter Xu
2023-02-15 20:59 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox