From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878FFC636D4 for ; Wed, 15 Feb 2023 20:59:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070276B0074; Wed, 15 Feb 2023 15:59:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01FFA6B0078; Wed, 15 Feb 2023 15:59:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2B406B007B; Wed, 15 Feb 2023 15:59:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D2BAE6B0074 for ; Wed, 15 Feb 2023 15:59:38 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7CAAE1410F9 for ; Wed, 15 Feb 2023 20:59:38 +0000 (UTC) X-FDA: 80470742436.27.5D8764F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0DEBE8000C for ; Wed, 15 Feb 2023 20:59:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dPUxKb4Y; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676494776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q6S1VkTICkUqA9YHU6wXxGdQoIJSBXpOMfD6usHNMyI=; b=m0G/uywuqHPHu/rqVUuJa/WzYLbH1yWPZMtt1pOrPNnIXkuSL/cIFVUeGqIENhVWUudBC8 6F5/EuZk7ytu5F/daU/rorYoFoZGwoUfB1km/1c/15evQnckpiW/8XmxcjezxrS9ON4gas MiYVa/GwtUprPfXoVr7lyADetx0E7i0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dPUxKb4Y; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676494776; a=rsa-sha256; cv=none; b=mHoO5fqBs0F5Ilm6eBvgdJ9ZsOxz0Ab7/Qn9EssEo+mZ2LeNT59q0gglKs1OetfZd91UqR L7ePvxMYCNhHi+az2rM9ZGRTexjiv3rT3txVyO2ksgb5R7grj1EL6P3COiVWR4Up8uBqOs SiH6WIiIkTIkVX5ATWPZ4p/DIhmqfZU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676494775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q6S1VkTICkUqA9YHU6wXxGdQoIJSBXpOMfD6usHNMyI=; b=dPUxKb4YrcLkq+bVlGRS/Mzs4CbiqyvUGEmASxrwjBqYI/Ocz7Oz6GWi3D75Z9qWYd1Io8 fKIYZuYyR/dLeO3anzGOhx8TIdro+d3RejIA2nK4CaSAOgZvFCjCgQHwW2TyZ2FlOVmNPh ZhkwR+QuwI8k4oi4aFMoLKzZgkLCIM4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-529-9PJ6Cjz1OsGt7epSP8Pxeg-1; Wed, 15 Feb 2023 15:59:33 -0500 X-MC-Unique: 9PJ6Cjz1OsGt7epSP8Pxeg-1 Received: by mail-wm1-f70.google.com with SMTP id t18-20020a05600c451200b003e1f2de4b2bso1895217wmo.6 for ; Wed, 15 Feb 2023 12:59:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q6S1VkTICkUqA9YHU6wXxGdQoIJSBXpOMfD6usHNMyI=; b=jQQDYZI2l2SCw7V6+egvJVPAFeg8CfqFoQLzfay1iankTJjJKQgYu0UB+2Pxkay9o+ Tr6OJddyRPHGZvjKQPOhKrvrR04roJO0CRh2nC6G5zqYkh90AHB5+0Ykjf7uMJx0lNNV yaMN2iwiJZm0Kq3hnBUgFtMaWkw0eQfTivAadTsMtljYBjiraWpqr4D9/LbxXAADrldO VwmXIRYFKeK+vhAaqC0gXHDcC6bOnFDamDGMEV2ZztoBNBubdO4vMxt2OCt1gFJLQfFT dCB+qQEhuu5uOF72QDDyZOnM8X9aCFFHIyldJXaeL7AMA8MUzl4ogmL/zrfswaWn0CRy UeUQ== X-Gm-Message-State: AO0yUKV2gKZiHRCpgvaQ+sLa1esOSb9BPE2Ry770za5wqevKuwaLZXkH g/zSlDHFxf8PnJH4jZyy/zYeY0AwFmF8Eu1B0vtNOlhmob+z+2a7C9Oausj473aO+pY7qiYTr1L sGng4GX6MN/U= X-Received: by 2002:adf:f7c1:0:b0:2c5:4f48:cbb2 with SMTP id a1-20020adff7c1000000b002c54f48cbb2mr2789986wrq.51.1676494772486; Wed, 15 Feb 2023 12:59:32 -0800 (PST) X-Google-Smtp-Source: AK7set8hffY8uY94ZVaHKD1JlU09IKXZUXP+Z3EUeF2EhZ+aIWmuPB0fxjsQYSj+MY98VMTBSCU9jQ== X-Received: by 2002:adf:f7c1:0:b0:2c5:4f48:cbb2 with SMTP id a1-20020adff7c1000000b002c54f48cbb2mr2789969wrq.51.1676494772036; Wed, 15 Feb 2023 12:59:32 -0800 (PST) Received: from ?IPV6:2003:cb:c707:1400:b7d:4122:28d:f4c3? (p200300cbc70714000b7d4122028df4c3.dip0.t-ipconnect.de. [2003:cb:c707:1400:b7d:4122:28d:f4c3]) by smtp.gmail.com with ESMTPSA id m20-20020a056000181400b002c54e89fcadsm11672017wrh.55.2023.02.15.12.59.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 12:59:31 -0800 (PST) Message-ID: <45e0bb2a-c03c-e5fd-aa77-c2e3d079570c@redhat.com> Date: Wed, 15 Feb 2023 21:59:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] mm/uffd: Fix comment in handling pte markers To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Axel Rasmussen , Andrea Arcangeli , Andrew Morton , Nadav Amit References: <20230215205800.223549-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230215205800.223549-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: koukwcgm8ce1h6rbknbr9pyxrd8xxfp9 X-Rspam-User: X-Rspamd-Queue-Id: 0DEBE8000C X-Rspamd-Server: rspam06 X-HE-Tag: 1676494775-226594 X-HE-Meta: U2FsdGVkX1+f552bKRrgUOw2NzweTFSMDoF/TeZBTsuO5LPntty4M1Dms1jiteHh0tpd36/7m0GQ/eSMKY5acJmkjZP/2BSj17frGV981XiluK0csDtBG23LeKntI/XTjMKmdTzKTaRDk4Xj10nlVtvR7qrMafNiqaI0Tiq6etXmZNLRw9dM7b4CXKM8NiL0eAto2GrfFznZJ+wC5jkc0bTi0jK7QSQXc8dtgh+qq+829pfGb94LCRO024/ciZHAQsodXlC0DKCQfYXb4SZ64wcl66WXDQoNZYw66yGB4A95KnkFjvYwuKBpg94OgXRGXfl3RvX9SxrqFlydoV6zHBTuU4diFu30Cwbn7uF7TWCwqNoDYmSSDK2PZevbULMrpWyolBz/eVqfYuth0vhAcfKdeRsVQBMw4O7zNFzPfCTJZk8FzaP9tSKzU7SdPkpGSyPCo3XKOm84+sdW4BMFz5MLqNhgoEf+HnmkReLzjM154NSO/9UYwIHilyWk15YUj1NpzMAmxJi8hjxkZ7D1q3+w04DARiNCLKF5jvBvAa47S2rV0pcx1atJxN3k9Bk6Z0Afs8SbwQnxo8tWC+8BGuiBEdA2Phww6uxfVxn5vxWXJL0PC+KULlCwQq1bZk1FjUjn5BDsOchyUMFDlXs9ErX5B6EJ0U/K1/OK9o11hBwHyp9XJPxmTPRbvMTwkZpMa05psaQVKrgCZBMSp+SCSznYeBN2EtowlUQoPvLIaF7PhF0KPZgofAkg5sMQ1TIvYfID3ihPymtiDYlkEcqvc3SIZQcMWuH6gN9lk4zEaDhOU2YiJk2k15CZzdeEbCusGqfP6YDbAI3i/jh/SCEMt9VzcLRUISdzT+GsG/e7S5dKdar3wVFAeQULomLHtPvrSBvXCg4kd7KJ/Y4m+XHlqxBvR5P/RWHLvjiFl2lyTdLc3kAGgEUCeuFt9yYeo2qtK6BvlZOqcAvVO9TwjqO uxfla40C C4RYFsiRrrec9IHL7sqTn06xz6VUL4S+DorOtPJnU/qNmqrC5K3Uh23KGEdG3YELI0JiHNLkU2gBoQtbM1fJGa6qn5I96iOvjUWcYl89APVsc+VlyOpZzEzxvKRIUO8LGRvvNPdc5qos1+2Cn1XJ6xlecVVQoDjJ5/NaStEJ8l0Nk+PGgpzqfd5/6Na75hPFIJTnrunBP1VmsjBIShNBI4zRxkBU+BkGRAXi1a6X8hG7IIIG5EInnLcgVKBzkFiYdHvllaZ7aBr6nQF4cZDtkxgaM6jR+HILos1OZ9vcZnueQATR/BtGkppXW4XeTl3+D2VQ6gsGfuCZYvGb0T3YDjnQYD1746zn3qitqVjAb5i+cxxpi0Xkef2T/pZTqj2SrTO+/wcY9SwAKAmCaWqnP01yNWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.02.23 21:58, Peter Xu wrote: > The comment is obsolete after f369b07c8614 ("mm/uffd: reset write > protection when unregister with wp-mode", 2022-08-20). Remove it. > > Signed-off-by: Peter Xu > --- > mm/memory.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 7a04a1130ec1..f456f3b5049c 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3627,9 +3627,7 @@ static vm_fault_t pte_marker_handle_uffd_wp(struct vm_fault *vmf) > { > /* > * Just in case there're leftover special ptes even after the region > - * got unregistered - we can simply clear them. We can also do that > - * proactively when e.g. when we do UFFDIO_UNREGISTER upon some uffd-wp > - * ranges, but it should be more efficient to be done lazily here. > + * got unregistered - we can simply clear them. > */ > if (unlikely(!userfaultfd_wp(vmf->vma) || vma_is_anonymous(vmf->vma))) > return pte_marker_clear(vmf); Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb