From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 873EAC77B7F for ; Mon, 23 Jun 2025 14:10:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270B16B0092; Mon, 23 Jun 2025 10:10:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 220F46B0098; Mon, 23 Jun 2025 10:10:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C2186B0099; Mon, 23 Jun 2025 10:10:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F15746B0092 for ; Mon, 23 Jun 2025 10:10:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BF9471D6AA5 for ; Mon, 23 Jun 2025 14:10:01 +0000 (UTC) X-FDA: 83586849402.14.E6B97C3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 2796640014 for ; Mon, 23 Jun 2025 14:09:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pa4hacm2; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750687799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fU/eXGbkp3rKuzXlI+aQj0bKJDTEpXSWfQHeLkuQF+c=; b=PJ6kn7UahOlDQA6ya3NiOl0lU7GSSWmkWDRSFateXKnXjOsTWLHU6M8pKQue+2JoJ2d0wV e8DT2R+768qX3iK++wkUZqBVKyD4d5PsX/F2cJMYu86NDpwXV2crnoqo/uBUnAEsNZsDUz z+H+atQV6nB7sbeMaAiW8+n4dGU2mIc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pa4hacm2; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750687799; a=rsa-sha256; cv=none; b=sfU62uAQ9mlbiex+SA144IHyGQlGNAMayBh+vgMg+lgtVlV9++mGOs9hdt8ueTOlSHgq2T EHlKSBqdBFyiwvtTFn/U7euGkZeLxrdiNRVwsnlRO6/EU3fXzXYHtdRKhsaqFQlzcA9Xtc ad+6pxGbdjcKcQbjIAM0YIC0It7srNg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750687798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fU/eXGbkp3rKuzXlI+aQj0bKJDTEpXSWfQHeLkuQF+c=; b=Pa4hacm2o1bPx8w9P8Ii+umhwJ3MLEiRXAUz6wcyATnETL/syPsOaZjOWq4Lk2QHLbtPkJ FrwtIbMwl7j2pp157JtHZ4bpMHq/uuz+BCMDQ8JLQzue/8DNOMl9rBtSnPNynWGVh/o7xL JTY58ynuHjff+sqtgAIbmc+Gfc1UeZg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-Iy3_P4QlNGGTo2TYN-z46g-1; Mon, 23 Jun 2025 10:09:55 -0400 X-MC-Unique: Iy3_P4QlNGGTo2TYN-z46g-1 X-Mimecast-MFC-AGG-ID: Iy3_P4QlNGGTo2TYN-z46g_1750687793 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45311704d1fso27079045e9.1 for ; Mon, 23 Jun 2025 07:09:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750687793; x=1751292593; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fU/eXGbkp3rKuzXlI+aQj0bKJDTEpXSWfQHeLkuQF+c=; b=qon1Bmi1p7mM4R8VEdyW7JSwafKr4Saj6djsc9/V3gckFal5pSW+v5f/814b53xeLi 3w9it0xDUcu3H+NHfR7OW01MvIXeIZbN5OWDJg3cLFowRtsMz4/thDvIctuZKHNPNnE8 OIEW98WycRNu9NwKBOvs53SsC+klR0U7yHgGY8M5Z88gPkPIvl5U0NxFfAPtvMdQqKVB Hoj1+CCgYni2L3cOVNiOflEfTnuo+ozP5/FCCcOu0CwSalXmPnO6WUBsnAlUkY0ZRRE3 hdb6A70QkQsD4Jvhjn/HEcM7C3tKCV6XtCQYi9eXm5vGrTHtd75XyDo+wAcolKGWZt3p 1hug== X-Forwarded-Encrypted: i=1; AJvYcCWEk4dBHSQwLVv4nX1ex+3Q5FxIXpaFO9tohvjDProZtqtTqDe9CnHj4AoRpP/OlN2lzWzJN1hGjw==@kvack.org X-Gm-Message-State: AOJu0Ywl4rGhfdsWuQZ9KALxscWQveSAoXYBj0L8XgKW4aI8KOFxKMuT ch+YCfPJdQ/m4pZaaMg3d7ykOk2daWR0TAZZkytnJbbIrm4XwKnL8SsKbmPWadGShOUcYF74pbz KzN5xx1hpJKfRxiYqcFuWhzeybwmMy4f3DrdTVCTJtj3oq6bCg3Xv X-Gm-Gg: ASbGnctLNRotBRhihYkSvuuXFTlcgAAlveK8bw9VyH9n42uzBp8WDPY+8osz2320xY+ fdyYY2xIIlYUW7LF7oLk4ctq+90mwxyFtofnBySvRO1G0lUMNgZo/cNVdYx/uZlGUGlqH2PGJHz cqa/DC10myOSRb9JXpvrecEcSWFeRu3hYKSoss/JJuhjenldUMKMyun76PhZPZn5FTLIfpV37d/ e/rl/fY+qRP5f1z3uaOIew8Pdqx/E/VxFNmOywrgSv0xGGN3QmE+DOu2oCJ5pNS4t+aplFPrt9R DMv7gTBEPimQX/v41KsUJXH8IcXU6bhhsPdgejq4rCflzKW3iwMm1JvCIa+60qj3he18Fw7oJvv ALC83kj6Z+4T56GcKEbhsz4In/uPhROryPNBWsCP+xMmiQ9D+Zw== X-Received: by 2002:a05:600c:c48e:b0:43c:ea1a:720a with SMTP id 5b1f17b1804b1-453659c3bbamr96209755e9.1.1750687793276; Mon, 23 Jun 2025 07:09:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGa2vbMZNuJPSi8HRpIM8Gidj4Pkak/D89pC4T1P1Q8CIk99VA8TjZO10VvYA/54eGMCXMow== X-Received: by 2002:a05:600c:c48e:b0:43c:ea1a:720a with SMTP id 5b1f17b1804b1-453659c3bbamr96209475e9.1.1750687792910; Mon, 23 Jun 2025 07:09:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535ef6edbesm144055485e9.20.2025.06.23.07.09.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 07:09:52 -0700 (PDT) Message-ID: <45d66a0c-a5ed-4894-999c-0ed5b732ebb0@redhat.com> Date: Mon, 23 Jun 2025 16:09:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping To: Oscar Salvador , Andrew Morton Cc: Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250620123014.29748-1-osalvador@suse.de> <20250620123014.29748-2-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250620123014.29748-2-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FAHpCtMG6Vvd4qC2TETGLgnN2-8qa-xZVUSWbRjoQHc_1750687793 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2796640014 X-Stat-Signature: siteu9nzoyu6jqrd6bqc35yd5th7iym1 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750687798-23734 X-HE-Meta: U2FsdGVkX18/tpQ3wRV8cO1r1NsW/NAQdAVmttqxeO+xg+zU1wjI5dPVM/NUetmpXJCJmvlsMQABcJkwZeadQJ58UeolsYp70B/VDNq3pYJzzaihrZXKp+epCLXtSuW6hJz0uYf8VOiyOBzZtGNV+hqV9BkloWrZ60Lty6VfENj1317fDu/6xFyiz6PpY+Mkno686KvPFxy+lUvtf1m04pePP9fZ0zzr2N9TwRR1IdkQtZ+E63vLVxZuk1DXUtXQfPws97XlNYbFhhFmDHsRR8u+EDNSuiNKpTX5Zgw8hXhMWYT6YSo0fkPIilr2G2t9SWkCG2w46+3wN+2TMqxr8w4rVBtg0C/zDpekEMVop5GnW37SZpMywBKB9G3kwfRdmDEOn4nlQbmP4+lRb2y70NgP8k8ta1Zdo+Fv9uNoEbCC61f3Mtn+8vaRIC6IVSjDPV3nlQJWA4q60UugB0SuMbBOYAbA/VhTvQlOYLrQxpkn2p8M2wz2YZ11ApJAu7nsQDs565GRQqi8qj5kW+kk/yBu2Zvh4aqD22Dl3pKdO/M9p+oCs39IppxxTi9sexeu/DThP3kKWfz0G/ZW9fPCRHaGkI2r0VQwvj8djROQrechzqv63nyzlEyttQVTYzkqKTYLZPe7bZC7z9YzWXJCDLh+kHvu/kY2B4B+DamELKQVl2/NrI1Cia7O2eyGjJirSA0GbTvLBVHoJsCatlLQZ9nH3lsXadat1v2WY51gRWZhvudfPojaekNWLZvOn3c++i1hiVDK/Vu+R4s0MlgiB7/B/ymYCtbJTL5DztEE9p1sw5AmnWqcmkVsY2sxPfA4HZ6g9Vmk29VgYS8DaD1ss3A3Oa5FCualxOyWqXnrGI2NpNKuveDUbI+IrPSVyAf4cQxREhIlXVSKDxVpNWB/meqIMzJIuc0xRA8qQJrWZgyr30BXPdrGUI/z2pVAnDbQVKW20/y45Mj57Q3eA30 y3DO2k12 yBNtAKzDGSfd3bu3xThpuOxoPDfMB2RmtilQD4p7oGrqf4sKx+TKyPPGq5QlzEgUnMFRlVQeFBYD+mxPa2ANDMBhWy4s9u5M4M7KSD+8uma9eh3hzpuADhAAA6iL9T8n/jt6WC6MYHrhbCMJulUemv65ESuEWeP7pQyGs7Md4QP+lUzi3slZcluCVA/4RhIW17095jwWrvGb1USC/ltNacFRaY6fh8WpCw9t6rxCuxcXfg4ByQg2IO5uxp1dOAy1nC+rD4eFXS8iqRQejjJauSmiW+BYfeL/2aVMpPCn9HrXW16L4vor9RRapimKfhzKQCBNOokV+OuecHS9KAXc1Iqkxoeqkj5L9FqptsDdRN+6GPUwK+qXtesni2zUCU6ciAlw1dwYi7PjUmPYroBks+lonTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > - /* > - * hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) and > - * pagecache_folio, so here we need take the former one > - * when folio != pagecache_folio or !pagecache_folio. > - */ > + /* hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) */ > folio = page_folio(pte_page(vmf.orig_pte)); > - if (folio != pagecache_folio) > - if (!folio_trylock(folio)) { > - need_wait_lock = 1; > - goto out_ptl; > - } > - > + folio_lock(folio); > folio_get(folio); Just realized that this won't work for this patch here, as we are holding the PTL. In patch #2 you do the right thing. -- Cheers, David / dhildenb