From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911F0C433ED for ; Tue, 20 Apr 2021 15:19:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1716D6135F for ; Tue, 20 Apr 2021 15:19:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1716D6135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D2726B006E; Tue, 20 Apr 2021 11:19:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A79B6B0070; Tue, 20 Apr 2021 11:19:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7485E6B0071; Tue, 20 Apr 2021 11:19:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 5BCD86B006E for ; Tue, 20 Apr 2021 11:19:01 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 202D1181AEF3C for ; Tue, 20 Apr 2021 15:19:01 +0000 (UTC) X-FDA: 78053103282.32.BA72B2A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 3FB64C0007CE for ; Tue, 20 Apr 2021 15:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618931940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=770vz2JVGNnIzK29NwyJrUqxj03tbV5pp2hzoWbqGVw=; b=h637VEFaW6VfqlMfD3C2EFGmK41kg4P52bu29lDwBBzAf5ZcVx8QCrCliH7VbS3IS03YiV mLAEu7S05m8bvPqO0rtqtNqrPa149Eu7lkrU1dNIjcerAbAgm7OG1Z0j8AxZIES41WXL63 zQCSLiKN5igZjpRSj8aCIPuOapsZByw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-bx7Wyw_wMGeqFlt8v3DSdg-1; Tue, 20 Apr 2021 11:18:58 -0400 X-MC-Unique: bx7Wyw_wMGeqFlt8v3DSdg-1 Received: by mail-ej1-f70.google.com with SMTP id r17-20020a1709069591b029037cf6a4a56dso4948049ejx.12 for ; Tue, 20 Apr 2021 08:18:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=770vz2JVGNnIzK29NwyJrUqxj03tbV5pp2hzoWbqGVw=; b=XrwEtR/JeaVe/nvoL4V04Pg69S6sPz4W6iRKYLMlyMtDtgCY5T/teZNa9+Um6P4qsB PM7gma4RLaIvM77DsjjFqj0RNetXd4S0Nm//De5k6kWcmbvB4VmocrklPxtEzGvgORz/ 3RAnR8s0ZYg+nVzST2nn2AKvd5CM7jjmBme6vhUWvp7wNrnm4e3Lr8S6lkqTq7oGq8lN oSqHjMDVsqBuM9ij6Ich3xaXrs/9Zx4cAzn6zseX+grI2ocsqyUfLpYKy6SjjZagaVuu FHIkhrUF0EGGupscG9NT3PqKmY45VImL2pAc6ZFxQ23BEXJEmJh6aQWwk78fWqHJYlzy n8aA== X-Gm-Message-State: AOAM53186OPUFqdXOn02JinNz4cjrI8Jg6oDhxt/k7oDomqJrSzEgV3X TZUANKhTgDcQ2wMmd+hz/q7GwqDkCAg5Xq48oRfKW+ZHZaIXeg3K6wK/cBQo0ZObAmZvqFUmaF+ XgW9k6f1HHZu2eIqopaIefvw4rC94e/f4lxpu27PY9jkhhQXEntHTuwQgKqI= X-Received: by 2002:a17:906:6d48:: with SMTP id a8mr28828682ejt.92.1618931937017; Tue, 20 Apr 2021 08:18:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX0gjV1YOL8zIlogJIXvYhztp20fRFlx1w9hSqe5B3fLMvw1anl4MLNbGH45aEpi3l71uCRQ== X-Received: by 2002:a17:906:6d48:: with SMTP id a8mr28828644ejt.92.1618931936653; Tue, 20 Apr 2021 08:18:56 -0700 (PDT) Received: from [192.168.3.132] (p4ff2390a.dip0.t-ipconnect.de. [79.242.57.10]) by smtp.gmail.com with ESMTPSA id v8sm16154073edc.30.2021.04.20.08.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 08:18:56 -0700 (PDT) Subject: Re: [PATCH v1 2/4] memblock: update initialization of reserved pages To: Mike Rapoport Cc: linux-arm-kernel@lists.infradead.org, Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210420090925.7457-1-rppt@kernel.org> <20210420090925.7457-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <45a7e13d-3e44-3b94-a253-2df72649a83d@redhat.com> Date: Tue, 20 Apr 2021 17:18:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3FB64C0007CE X-Stat-Signature: nfzbk4kndbw99rb4u5herdij1bhuisy1 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618931935-48105 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.04.21 17:03, Mike Rapoport wrote: > On Tue, Apr 20, 2021 at 03:56:28PM +0200, David Hildenbrand wrote: >> On 20.04.21 11:09, Mike Rapoport wrote: >>> From: Mike Rapoport >>> >>> The struct pages representing a reserved memory region are initialized >>> using reserve_bootmem_range() function. This function is called for each >>> reserved region just before the memory is freed from memblock to the buddy >>> page allocator. >>> >>> The struct pages for MEMBLOCK_NOMAP regions are kept with the default >>> values set by the memory map initialization which makes it necessary to >>> have a special treatment for such pages in pfn_valid() and >>> pfn_valid_within(). >> >> Just a general question while thinking about it: >> >> Would we right now initialize the memmap of these pages already via >> memmap_init_zone()->memmap_init_range()? (IOW, not marking the >> PageReserved?) > > Yep. These pages are part of memblock.memory so they are initialized in > memmap_init_zone()->memmap_init_range() to the default values. > So instead of fully initializing them again, we mostly would only have to set PageReserved(). Not sure how big that memory usually is -- IOW, if we really care about optimizing the double-init. -- Thanks, David / dhildenb