From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id A85666B005A for ; Thu, 25 Jun 2009 14:06:04 -0400 (EDT) Received: by qw-out-1920.google.com with SMTP id 5so742341qwf.44 for ; Thu, 25 Jun 2009 11:06:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20090624105413.13925.65192.sendpatchset@rx1.opensource.se> <20090624195647.9d0064c7.akpm@linux-foundation.org> Date: Fri, 26 Jun 2009 02:06:13 +0800 Message-ID: <45a44e480906251106h6cd72a72h380da4283be62506@mail.gmail.com> Subject: Re: [PATCH] video: arch specific page protection support for deferred io From: Jaya Kumar Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Magnus Damm Cc: Andrew Morton , linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com, arnd@arndb.de, linux-mm@kvack.org, lethal@linux-sh.org List-ID: On Thu, Jun 25, 2009 at 2:06 PM, Magnus Damm wrote: > > The code is fbmem.c is currently filled with #ifdefs today, want me > create inline versions for fb_deferred_io_open() and > fb_deferred_io_fsync() as well? > The patch looks good. I was going to suggest that it might be attractive to use __attribute__(weak) for each of the dummy functions instead of ifdefs in this case, but I can't remember if there was a consensus about attribute-weak versus ifdefs. Thanks, jaya -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org