From: Andres Salomon <dilinger@debian.org>
To: Dave Jones <davej@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andres Salomon <dilinger@debian.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c
Date: Tue, 06 Mar 2007 23:42:36 -0500 [thread overview]
Message-ID: <45EE42BC.6030209@debian.org> (raw)
In-Reply-To: <20070307040248.GA30278@redhat.com>
Dave Jones wrote:
> On Tue, Mar 06, 2007 at 05:52:46PM -0800, Andrew Morton wrote:
> > On Tue, 06 Mar 2007 18:52:59 -0500
> > Andres Salomon <dilinger@debian.org> wrote:
> >
> > > If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
> > > and setup.c won't compile. This wraps it with an #ifdef.
> > >
> >
> > I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
> > discover that. But I don't think we need to "fix" it yet?
Oh, it's certainly not urgent. I sent it simply for correctness reasons.
It would've been nice to see the ZONE_DMA removal patches just #define
ZONE_DMA regardless, and include less #ifdefs scattered about; but at
this point, I'd just as soon prefer to see a proper way to allocate
things based on address constraints (as discussed in
http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).
>
> CONFIG_ZONE_DMA isn't even optional on i386, so I'm curious how
> you could hit this compile failure.
>
Why, with custom code of course ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-03-07 4:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 23:52 Andres Salomon
2007-03-07 1:52 ` Andrew Morton
2007-03-07 4:02 ` Dave Jones
2007-03-07 4:42 ` Andres Salomon [this message]
2007-03-07 20:25 ` Christoph Lameter
2007-03-07 20:38 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EE42BC.6030209@debian.org \
--to=dilinger@debian.org \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox