From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45BFEE7D.7060509@yahoo.com.au> Date: Wed, 31 Jan 2007 12:18:53 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: page_mkwrite caller is racy? References: <45BDCA8A.4050809@yahoo.com.au> <45BE9BF0.10202@yahoo.com.au> <20070130015159.GA14799@ca-server1.us.oracle.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Anton Altaparmakov Cc: Mark Fasheh , Hugh Dickins , linux-kernel , Linux Memory Management , David Howells , Andrew Morton List-ID: Anton Altaparmakov wrote: > On Mon, 29 Jan 2007, Mark Fasheh wrote: > >> >>No page lock please. Generally, Ocfs2 wants to order cluster locks outside >>of page locks. Also, the sparse b-tree support I'm working on right now will >>need to be able to allocate in ->page_mkwrite() which would become very >>nasty if we came in with the page lock - aside from the additional cluster >>locks taken, ocfs2 will want to zero some adjacent pages (because we support >>atomic allocation up to 1 meg). > > > Ditto for NTFS. I will need to lock pages on both sides of the page for > large volume cluster sizes thus I will have to drop the page lock if it is > already taken so it might as well not be... Although I do not feel > strongly about it. If the page is locked I will just drop the lock and > then take it again. If possible to not have the page locked that would > make my code a little easier/more efficient I expect... OK, that makes sense. Thanks to you both. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org