From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B81C433B4 for ; Wed, 14 Apr 2021 15:16:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E5B4613B1 for ; Wed, 14 Apr 2021 15:16:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E5B4613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D62666B0070; Wed, 14 Apr 2021 11:16:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D12C46B0071; Wed, 14 Apr 2021 11:16:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8C5F6B0072; Wed, 14 Apr 2021 11:16:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 99FA06B0070 for ; Wed, 14 Apr 2021 11:16:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4A7C812F7 for ; Wed, 14 Apr 2021 15:16:19 +0000 (UTC) X-FDA: 78031323678.19.586E0D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id E728C3CC for ; Wed, 14 Apr 2021 15:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618413378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wi7Vsx7fsiQc/wyHgFKatT0Y76VokmNc3vRxm+hzn58=; b=ZCLicsouWF15NXwkUTeDE+HTVxgsu9RJzF3zQNSI/z5qVCutCI1D2JHVIexPXUcuJP3i2G egFka8QRZaOaY/6NJmJLSvXLC2yz9RYkVUjl/hj8sNGkuSOUbiOkyxWuq6Ko1L7+gDgc4t 5BY4zuqIGvRQjHhuKRP3ZXlUItYe8AU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-fU1EC6HIOnOC9a2KaMHRDw-1; Wed, 14 Apr 2021 11:16:14 -0400 X-MC-Unique: fU1EC6HIOnOC9a2KaMHRDw-1 Received: by mail-wr1-f71.google.com with SMTP id f15-20020adffccf0000b02901028c7339ccso1214767wrs.1 for ; Wed, 14 Apr 2021 08:16:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=wi7Vsx7fsiQc/wyHgFKatT0Y76VokmNc3vRxm+hzn58=; b=QYP+HuCoPhuZyBmIe84i2nXOrl8jdEOQaPX4kXG5dn/HFoLCfL/3d9qviN+pm1uuFL QQmgBWKMwj7v8342EYFwwIJr8NiplVQtVmuXMxvOnOrChhQ/dzit6jyNvxMwYk3Rp+1u y32djZZnW2D/AqeTylK/xgANEhB4NtozwMqm3Vxn9Rc9OE1a1YRJIHXtOInL6DsOSooY RLFS99Rtuf0W57jHKgQEMXeNFa907q3+eCGGVwUAekfX7DLRkoN0hcR9PolSqoRxjdvy XBUyK3aeFW8oE91uw3dqIZSXj6lRpn09Ycz1ppUXE/VYQ3amXlRBfhNxqzesqNJBuBEK t4dw== X-Gm-Message-State: AOAM53186gJzXXRGvjHNKQGluyIG2j7MvW2/79kUbIsggYkOL7elBQSX wvCZNeJo3r5qkFKke7BsqXHtcAkcPh0xKBFx5pG5/w+DwYsYN6W7mbNAGsPMjVZP79TWFQSffeG hKJB3HWMo6q0= X-Received: by 2002:a1c:4b13:: with SMTP id y19mr3695853wma.12.1618413372899; Wed, 14 Apr 2021 08:16:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy35JMmK9bF2B+eF87l+y5GGmoAQLNqebx4EHnd7JjEV1/GA3x6z5GH9wCqSz0nLPLczE/QXQ== X-Received: by 2002:a1c:4b13:: with SMTP id y19mr3695830wma.12.1618413372675; Wed, 14 Apr 2021 08:16:12 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6470.dip0.t-ipconnect.de. [91.12.100.112]) by smtp.gmail.com with ESMTPSA id r2sm9575003wrt.79.2021.04.14.08.16.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 08:16:12 -0700 (PDT) Subject: Re: [PATCHv2] mm/mmap.c: lines in __do_munmap repeat logic of inlined find_vma_intersection To: Gonzalo Matias Juarez Tello , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210408034632.r5nor5akqo5o3aus@monty> From: David Hildenbrand Organization: Red Hat Message-ID: <459c338e-bd9b-fb27-5d6f-f217b684a9e3@redhat.com> Date: Wed, 14 Apr 2021 17:16:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210408034632.r5nor5akqo5o3aus@monty> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E728C3CC X-Stat-Signature: gr1cde18uukie5ozzarxtr4oo6e546x5 X-Rspamd-Server: rspam02 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618413376-899241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.04.21 05:46, Gonzalo Matias Juarez Tello wrote: > Some lines in __do_munmap used the same logic as find_vma_intersection > (which is inlined) instead of directly using that function. > > (Can't believe I made a typo in the first one, compiled this one, > sorry first patch kinda nervous for some reason) > > Signed-off-by: Gonzalo Matias Juarez Tello > --- > mm/mmap.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 3f287599a7a3..1b29f8bf8344 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2823,15 +2823,10 @@ int __do_munmap(struct mm_struct *mm, unsigned long start, size_t len, > arch_unmap(mm, start, end); > > /* Find the first overlapping VMA */ > - vma = find_vma(mm, start); > + vma = find_vma_intersection(mm, start, end); > if (!vma) > return 0; > prev = vma->vm_prev; > - /* we have start < vma->vm_end */ > - > - /* if it doesn't overlap, we have nothing.. */ > - if (vma->vm_start >= end) > - return 0; > > /* > * If we need to split any vma, do it now to save pain later. > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb