From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Adrian Bunk <bunk@stusta.de>
Cc: Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [2.6 patch] the scheduled find_trylock_page() removal
Date: Thu, 04 Jan 2007 15:53:07 +1100 [thread overview]
Message-ID: <459C8833.7080500@yahoo.com.au> (raw)
In-Reply-To: <20070102215735.GD20714@stusta.de>
Adrian Bunk wrote:
> This patch contains the scheduled find_trylock_page() removal.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
I guess I don't have a problem with this going into -mm and making its way
upstream sometime after the next release.
I would normally say it is OK to stay for another year because it is so
unintrusive, but I don't like the fact it doesn't give one an explicit ref
on the page -- it could be misused slightly more easily than find_lock_page
or find_get_page.
Anyone object? Otherwise:
Acked-by: Nick Piggin <npiggin@suse.de>
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2007-01-04 4:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070102215735.GD20714@stusta.de>
2007-01-04 4:53 ` Nick Piggin [this message]
2007-01-04 15:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459C8833.7080500@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox