From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E502EC4167B for ; Tue, 14 Nov 2023 18:39:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E1CC6B030F; Tue, 14 Nov 2023 13:39:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 592446B0311; Tue, 14 Nov 2023 13:39:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C8B6B0312; Tue, 14 Nov 2023 13:39:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 31E4E6B030F for ; Tue, 14 Nov 2023 13:39:50 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F0DDBC0848 for ; Tue, 14 Nov 2023 18:39:49 +0000 (UTC) X-FDA: 81457423698.18.FC31FA0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id B7AA1100020 for ; Tue, 14 Nov 2023 18:39:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="J/FXMHiu"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699987187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lMzxw7MpAdlI2fv1gHp8QXTc6SEWuODVU51yYvgu0/s=; b=g5sZIfwrY4iWj4CnbEmmbNjHf90VXKWyI+Z91b1RALiqE0UWCYP4Fs4mGSFJkl28LmVFPJ eHkBMKsSZYJALyMgnhWW0xb15VZofD7uK4qOUkROjNKSXhdvu5BXhJx8iOZDZ1cfaWulMG jnIfkZGgdkFZfbCc6DWTPI8tgM2pIJo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="J/FXMHiu"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699987187; a=rsa-sha256; cv=none; b=CN2c5Rww20zs1/QNP+IaDkUye4yREqWuwBqwiosQ0YB/1Fzc1cfxKbcqJ7lWFkPl9OLwlh C0YDpRI/vVIbcWwY4i4WbW39Mo3CzRXWYhuBQ+9nQFn0VKzijg3HRy3yhC9YYOZlPVdaah PnDVdeferO84uZJpEWbhGUGjb0QCTOI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699987187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lMzxw7MpAdlI2fv1gHp8QXTc6SEWuODVU51yYvgu0/s=; b=J/FXMHiusLpFioT6smBYt1eDafJzoTUv9fCOgzITh58JV1jSRWomu58p+ZyNpFUbMzdnec tbJ+IGll7C4vtJuVlxfMEau019lR8r8+jQMdEsCL7wLblrV1CrgUYc+7sDXa+mR/IsH4uL KpoU0QsCfqh1BvasTsDq8msWPFcUPss= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-xX4iKe0JMbOd-Dg6qaHZMQ-1; Tue, 14 Nov 2023 13:39:43 -0500 X-MC-Unique: xX4iKe0JMbOd-Dg6qaHZMQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40845fe2d1cso40203125e9.0 for ; Tue, 14 Nov 2023 10:39:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699987183; x=1700591983; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lMzxw7MpAdlI2fv1gHp8QXTc6SEWuODVU51yYvgu0/s=; b=iF3/xeEcEWDJl5wIwtALUSxzbf842buzNJN9pWU8STJX/QCA1cFXbTjwTcBqPjmH84 UYtYs6vpgxPkaB+2DIagjiaLfwIk5ef+Sv5CZOlBpFsyHvDOqa066Jbqg3UEEndSVnsm 8s9/QkxA+LiYPhl9LBHqi6csSBWjpUx94H4RO+edf0AcRhCw99PDzGCqaEju9m0g1/tZ SCpNOCYOpzfrPRxg5nqCvw4Jyfej0Foyop5pogApME53VSxkJgTywe1hwctiZOQGP9kh U9GykfkxzQDLMGXBB0jBMuVnBhXLf8USERPBH2GeoYK3SLiJC29v1f2ihvyC0n2kqn8P GdgQ== X-Gm-Message-State: AOJu0Ywmz0vdaoUnmVsWe7VR2YALQaeMZlSqVDApJ59EYEY516ZVaZnS m3+lrtzHIgfONm1G0S0bYi9W8WUh1+/Wb4uLkWsLikOvam5z5cL5qgmtnnqeEjSxsbUuORoOuxy 2ND0NNKADGE8= X-Received: by 2002:a05:600c:1695:b0:3fe:2bb1:11ba with SMTP id k21-20020a05600c169500b003fe2bb111bamr8763298wmn.27.1699987182485; Tue, 14 Nov 2023 10:39:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZXV2odJ/j8P9xGS6bVV1sMppBwnilp87FedLQhpCqCfvR3Yot4+anzqUz+v1b/GpLTVWLaA== X-Received: by 2002:a05:600c:1695:b0:3fe:2bb1:11ba with SMTP id k21-20020a05600c169500b003fe2bb111bamr8763284wmn.27.1699987182081; Tue, 14 Nov 2023 10:39:42 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd? (p200300cbc73e890002d8c9f0f3fbd4fd.dip0.t-ipconnect.de. [2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd]) by smtp.gmail.com with ESMTPSA id fl14-20020a05600c0b8e00b004080f0376a0sm12442292wmb.42.2023.11.14.10.39.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 10:39:41 -0800 (PST) Message-ID: <458da84d-3838-4c5d-abda-1aebba676186@redhat.com> Date: Tue, 14 Nov 2023 19:39:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] s390/mm: implement MEM_PHYS_ONLINE MEM_PHYS_OFFLINE memory notifiers To: Sumanth Korikkar , linux-mm , Andrew Morton Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-7-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231114180238.1522782-7-sumanthk@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B7AA1100020 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: z9tifq77u8t379fpq4z36q4h8u87gize X-HE-Tag: 1699987187-805757 X-HE-Meta: U2FsdGVkX18dTTgBWZtBl+fTX1TD8Zq07F5ycd1uJLeN7pnrezouQmc+K+oCmzb4TyA1Pw32Jur64WeRKNMnEeyOKtejpR8UfrbNAmPd9d7UgzktZooU+AFvYeC5M1F0YuHGexqWsgglNVL24sw3hMRkhbHfdZ58ebGUZ3lnl9OXuQ/mgK+nK4QSfmXo0xdZoOqtehYtIuh0CrjmmpfteARC0S6HKUdUYfCeRQWWi8GMdHrhV0wr7bV1+h3xMSJKBL4dSJqm2EwhrCIUN5cJtU/vz+uaJctX2PB/6XdL8s709U6fDjQpbJTLPkW6yBUXhP6lfmE9uZDJrzVlkgCFJMCONTBv0GjMeOTwWAOSaPj2LtOB9Hd1kioVxJwo1A8vYm8zhb6LlKlrd/vBk5pJ2DjoCQXPUmLj2jigh8GBmrRk11tschr15NaTXdV+THJNXhV8hHVWrGd7E2J0A1gbQogaMVClT7ekYlPXhIMJye6VOLN/AC2OCDjAM2iGpLQ5xVsiuj/gOwmdnbqaGy3HXLJlfETNFh6rxdDXK28twV8UjkOwzk0jDWCJd33Pt+TD+k69+gFt2pHr7RgfhPkm+qQ7I/Yq6UAXS5p27Onq3bBQdQBwEaPiWnDnPykGyNip/chZYXtzGFDG++w4HY8NDfJyKCVMKCvHzRzB7PJabVkWAUo2hfkFH6W5j5Eqdz4DXrEkjDRol77Noi4YRgEayaZHV0tgLAVSYSFEuH6777oZLpILynzbGZZUB8DpoHkYo7XAUqiHDsLojhQ0xK5pJtOF7uB04ODZmsUwMLIwbjSTywgC/jsw6csDYgLXecjfsYEG2jo7ksQNApw1jDgnQo6xO539nHXwiJYzdl74r8GwmKjlTgOWl9ueQOjSSa6sxvZaW0Wvq/cXpBK1MMDioc85ZHmlVlOd3w4762Na6kQuwbnBnqJgwrsGOcLbnvsN47drCfu5lAyA/FOepuM pQ88GLKn LZncPL/DkZVcg/4v3EA/A/08I60zJQkSoVabK535aRO2ptjRMn3M32n1Om1VlI28PX9h2u5BzDdNa1QpQtrUXchu2tlnvA2c2JiWX50IF/kkqgduBgI0NpLf6ljkhydHgpOmXBznmPQmFKMrocyW7XDDXlkBPcHIKGQu+U/77yIGwhIWmf5LmSDQg3JLhZBD6auK1KFtmjGsG0tmTPmXr6Ffv1yj7+RQtRby39nvxhBjHG4HeRZC1H6AmDHd4bN7VCNgYZT2/gkNY6XAE6rzW6ZJypLrjXamVMkDzjcvKDFE+tyJVsBSsCDqw7RjV9PHYxGBi3v8nGiDW6gECxz3KEXwInqM9kpdWPQJ0lcWh8yR37xmalK791++9TDhbWCfmiJQ5QtgeN4rqBR80yohkQ5CbJPXgrhh+az9b10WODhyzCMArg93VJNIdPeLHCpZqxVxRY6ukZOWt51hs6NetT3BPYL/ZFkMoG1hxy2mZuML/F1dcVOIiFBqbUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.11.23 19:02, Sumanth Korikkar wrote: > Implement MEM_PHYS_ONLINE and MEM_PHYS_OFFLINE memory notifiers on s390 > > Implementation of MEM_PHYS_ONLINE Memory Notifier: > * Transition the memory block to an accessible/online state using the > sclp assign command. > * Execute __add_pages() for the memory block, enabling a self-contained > memory map range. For boot-time memory, vmemmap mapping is carried out > through sparse_init(). > > Implementation of MEM_PHYS_OFFLINE Memory Notifier: > * Execute __remove_pages() exclusively for the memory block (applicable > where a self-contained memory map was possible before). > * Shift the memory block to an inaccessible/offline state using the sclp > unassign command. > > Additional Implementation Considerations: > * When MHP_MEMMAP_ON_MEMORY is disabled, the system retains the old > behavior. This means the memory map is allocated from default memory, > and struct vmemmap pages are populated during the standby memory > detection phase. > * With MHP_MEMMAP_ON_MEMORY enabled (allowing self-contained memory > map), the memory map is allocated using the self-contained memory map > range. Struct vmemmap pages are populated during the memory hotplug > phase. > * If MACHINE_HAS_EDAT1 is unavailable, MHP_MEMMAP_ON_MEMORY is > automatically disabled. This ensures that vmemmap pagetables do not > consume additional memory from the default memory allocator. > * The MEM_GOING_ONLINE notifier has been modified to perform no > operation, as MEM_PHYS_ONLINE already executes the sclp assign > command. > * The MEM_CANCEL_ONLINE notifier now performs no operation, as > MEM_PHYS_OFFLINE already executes the sclp unassign command. > * The call to __add_pages() in arch_add_memory() with altmap support is > skipped. This operation is deferred and will be performed later in the > MEM_PHYS_ONLINE notifier. > > Reviewed-by: Gerald Schaefer > Signed-off-by: Sumanth Korikkar > --- > arch/s390/mm/init.c | 16 +++++++++++++++- > drivers/s390/char/sclp_cmd.c | 33 ++++++++++++++++++++++++++++++--- > 2 files changed, 45 insertions(+), 4 deletions(-) > > diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c > index 8d9a60ccb777..db505ed590b2 100644 > --- a/arch/s390/mm/init.c > +++ b/arch/s390/mm/init.c > @@ -288,6 +288,12 @@ int arch_add_memory(int nid, u64 start, u64 size, > rc = vmem_add_mapping(start, size); > if (rc) > return rc; > + /* > + * If MHP_MEMMAP_ON_MEMORY is enabled, perform __add_pages() during memory > + * onlining phase > + */ > + if (params->altmap) > + return 0; So we'd have added memory blocks without a memmap? Sorry, but this seems to further hack into the s390x direction. Maybe s390x should just provide a dedicate interface to add these memory blocks instead of adding them during boot and then relying on the old way of using online/offline set them online/offline. -- Cheers, David / dhildenb