From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F1FC38A2D for ; Tue, 25 Oct 2022 15:37:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F2C28E0002; Tue, 25 Oct 2022 11:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A2FC8E0001; Tue, 25 Oct 2022 11:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAD2E8E0002; Tue, 25 Oct 2022 11:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB0868E0001 for ; Tue, 25 Oct 2022 11:37:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8251DC0BEE for ; Tue, 25 Oct 2022 15:37:41 +0000 (UTC) X-FDA: 80059876722.04.D995F5E Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by imf06.hostedemail.com (Postfix) with ESMTP id 1403118000A for ; Tue, 25 Oct 2022 15:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=f8Du+MtqcshkZAivSawu/fPBgzGqyOuTUC9w0UwA0us=; b=ma12HTv07ZvN/PMtXNYq8f4UVE tKXtoxcuzCMVqGLKjEXOj7DMUtJYVGj5+rPki6TxyFFCVpP46hxCji5pMn3E9YHtuuherZrziOpaW DH0G+ZZM5c5NQTW5Y3uRl0wIvA6qiQ3zQt6Bx/ixCGbeutwRoUdLhsNp/QeIQf9DclGpoHLHCPx8b VQ9U8Qs3jUiMZU1aWJnEuAT1K3GPkZ2M0LwAwXaBbiCoSJYnesVrmxPgqhLBib86Lqx3YeRc/zDAW IYZAXgSHru2stPrxuF0ZSV1HZTm4k6O75N1xXS/uIro7syUZ3yRkEPuMD0oloe6g8+dQEHQ9Ln/8G kHBW5WdA==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1onLzk-00H0S9-TU; Tue, 25 Oct 2022 09:37:37 -0600 Message-ID: <458b5dce-e130-6608-119a-63ccf6bd1eae@deltatee.com> Date: Tue, 25 Oct 2022 09:37:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-CA To: Chaitanya Kulkarni , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-mm@kvack.org" Cc: Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates References: <20221021174116.7200-1-logang@deltatee.com> <20221021174116.7200-7-logang@deltatee.com> From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: chaitanyak@nvidia.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, gregkh@linuxfoundation.org, dan.j.williams@intel.com, jgg@ziepe.ca, christian.koenig@amd.com, jhubbard@nvidia.com, ddutile@redhat.com, willy@infradead.org, daniel.vetter@ffwll.ch, dave.b.minturn@intel.com, jason@jlekstrand.net, dave.hansen@linux.intel.com, jianxin.xiong@intel.com, helgaas@kernel.org, ira.weiny@intel.com, robin.murphy@arm.com, martin.oliveira@eideticom.com, ckulkarnilinux@gmail.com, rcampbell@nvidia.com, sbates@raithlin.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v11 6/9] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages() X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666712261; a=rsa-sha256; cv=none; b=W8OIDy0mBrvMHiP4xJdAh4fOJRUvTwtfFo9tCOaXbQopN+xTgESb4cPUsreTH16yhKL0JH 8SAzaknCr2y7hMWsRid34K363/V0Qnm9ADvciU1fu5zikbz2z/WJEofrRVcIEt6RtF5ZYd 5O50IW8lce4vXEgSgXBUoZOdn04ysHs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b=ma12HTv0; spf=pass (imf06.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=none) header.from=deltatee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666712261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f8Du+MtqcshkZAivSawu/fPBgzGqyOuTUC9w0UwA0us=; b=xPNESViEFcvJHgbUDowRBHlN98kkYfBlUOdZE9ocNomVYrZqKPNFrZUnfgyp+6TE2Kgb6W ZRsUvnPXu3emsQ3oaX+8iKQAaC60wAa9kRbgrrykpKomFdb+v6uXU8pCwnaduTGQ2Q9Ct7 IBvptIF6n4tVS2268EhOuT6TiMyYlAc= X-Rspamd-Queue-Id: 1403118000A X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b=ma12HTv0; spf=pass (imf06.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=none) header.from=deltatee.com X-Rspamd-Server: rspam04 X-Stat-Signature: t1b7ge8thk3eyuzo7y8u5yj5eetzun1p X-HE-Tag: 1666712260-139073 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-10-24 19:23, Chaitanya Kulkarni wrote: > /* >> * Each segment in the iov is required to be a block size multiple. >> * However, we may not be able to get the entire segment if it spans >> @@ -1217,8 +1221,9 @@ static int __bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter) >> * result to ensure the bio's total size is correct. The remainder of >> * the iov data will be picked up in the next bio iteration. >> */ >> - size = iov_iter_get_pages2(iter, pages, UINT_MAX - bio->bi_iter.bi_size, >> - nr_pages, &offset); >> + size = iov_iter_get_pages(iter, pages, >> + UINT_MAX - bio->bi_iter.bi_size, >> + nr_pages, &offset, gup_flags); > > nit, 3rd param in above call fits on the first line ? plz check :- > > iov_iter_get_pages(iter, pages, UINT_MAX - bio->bi_iter.bi_size, > nr_pages, &offset, gup_flags); Oh, yup, this just fits. I'll queue up the fix for if I send v12. Logan