From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3313F459F3 for ; Fri, 10 Apr 2026 15:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04F8F6B00C8; Fri, 10 Apr 2026 11:30:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F42396B00C9; Fri, 10 Apr 2026 11:30:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE3C86B00CA; Fri, 10 Apr 2026 11:30:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CAEAE6B00C8 for ; Fri, 10 Apr 2026 11:30:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2584CC1B86 for ; Fri, 10 Apr 2026 15:30:58 +0000 (UTC) X-FDA: 84643034196.13.FCCD51D Received: from iad-out-010.esa.us-east-1.outbound.mail-perimeter.amazon.com (iad-out-010.esa.us-east-1.outbound.mail-perimeter.amazon.com [34.197.254.9]) by imf09.hostedemail.com (Postfix) with ESMTP id EDEC0140002 for ; Fri, 10 Apr 2026 15:30:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazoncorp2 header.b=dxw0hgR1; spf=pass (imf09.hostedemail.com: domain of "prvs=5539d40d4=kalyazin@amazon.co.uk" designates 34.197.254.9 as permitted sender) smtp.mailfrom="prvs=5539d40d4=kalyazin@amazon.co.uk"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1775835056; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fk/G0VoAmsTULxx1duFy1qBcFztpaqd84bNcnJdqZbI=; b=fD0wubVa29JGimAWHVIaH36LLN0ULyLTdSAZi4O02Ztw4GHQQ28JyvhqS4JQH3KT39Q0b/ hNVOL9gMddh7XUyLoUS/q7pPumrqY59kvUBCDuHcUvitm5gyzqXlQwbUOvVitDBLc8gU/V serfA02DrWT7NQ7yTnwKvogUFaRay90= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazoncorp2 header.b=dxw0hgR1; spf=pass (imf09.hostedemail.com: domain of "prvs=5539d40d4=kalyazin@amazon.co.uk" designates 34.197.254.9 as permitted sender) smtp.mailfrom="prvs=5539d40d4=kalyazin@amazon.co.uk"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1775835056; a=rsa-sha256; cv=none; b=8HPOvxRbwBhQlztoorxtnnLL8n3dcm2rYKThiFljANIhYyWkyqDCIb8xIdSQeJ75Z0cDdx MGqdO2R1vREHpXRUFa5XhYqdtT/2NiINBQDV2qC+DZ1FEN84YwyEHMv6iMjNN2hAUOzc0x Oe6uiWLUiLIZqpFRhVJM0/WOU9osLyE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1775835055; x=1807371055; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=fk/G0VoAmsTULxx1duFy1qBcFztpaqd84bNcnJdqZbI=; b=dxw0hgR1jDhI1vBDwNgcRCLGQ8CeR7UfLYdYPyNKECdTUvihycu6cERJ eafHqqgR3/uSgJkLTh+UDR8qhXZDR7/o9Qsb/7tZD+XjjvjD3x4QpTUPc 99BdMyCX8JDRJPJnrNBtlEf1IASZazQ+ZQm6hHWY/XU+wGdD8Kr1AFlzK kFMhb+fXbubR9xUySaSExgzBCo1h0Ri7FBvDjSsEkzWmSpOXC8Hf2bHHn ff5spB3uwpcUGPmJWmNwbkpnrJFqPrY50gigzLsDfUjOi7F1iy4c+Ahvl dZ99Xlxflj82lXxGqObj1Rm9heNgEeXUDIcSJ4HRXH8ep/RcK4paU96fU g==; X-CSE-ConnectionGUID: EfpEH2kdQD+iuAgL71BkKg== X-CSE-MsgGUID: S2cYWuC+QKSF2lkzx+JDHw== X-IronPort-AV: E=Sophos;i="6.23,171,1770595200"; d="scan'208";a="15700706" Received: from ip-10-4-17-41.ec2.internal (HELO smtpout.naws.us-east-1.prod.farcaster.email.amazon.dev) ([10.4.17.41]) by internal-iad-out-010.esa.us-east-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 15:30:52 +0000 Received: from EX19MTAUEA001.ant.amazon.com [72.21.196.67:32091] by smtpin.naws.us-east-1.prod.farcaster.email.amazon.dev [10.0.29.254:2525] with esmtp (Farcaster) id 88ad7e41-cdbc-4feb-8b06-7a4fac6cc058; Fri, 10 Apr 2026 15:30:51 +0000 (UTC) X-Farcaster-Flow-ID: 88ad7e41-cdbc-4feb-8b06-7a4fac6cc058 Received: from EX19D027UEC003.ant.amazon.com (10.252.137.250) by EX19MTAUEA001.ant.amazon.com (10.252.134.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:30:51 +0000 Received: from [192.168.12.97] (10.106.82.30) by EX19D027UEC003.ant.amazon.com (10.252.137.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:30:39 +0000 Message-ID: <45807109-570d-4681-bbd0-7a1649f515d9@amazon.com> Date: Fri, 10 Apr 2026 16:30:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v11 10/16] KVM: guest_memfd: Add flag to remove from direct map To: Ackerley Tng , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-pm@vger.kernel.org" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@kernel.org" , "lorenzo.stoakes@oracle.com" , "vbabka@kernel.org" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "skhan@linuxfoundation.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "yosry@kernel.org" , "ajones@ventanamicro.com" , "maobibo@loongson.cn" , "tabba@google.com" , "prsampat@amd.com" , "wu.fei9@sanechips.com.cn" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "Jonathan.Cameron@huawei.com" , "Liam.Howlett@oracle.com" , "urezki@gmail.com" , "zhengqi.arch@bytedance.com" , "gerald.schaefer@linux.ibm.com" , "jiayuan.chen@shopee.com" , "lenb@kernel.org" , "osalvador@suse.de" , "pavel@kernel.org" , "rafael@kernel.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" References: <20260317141031.514-1-kalyazin@amazon.com> <20260317141031.514-11-kalyazin@amazon.com> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJp2NfjBQkGQlIzAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPPNDAEAvsw8vEWj8ArWQ1QJNufjrvobU/cE8MLKdBxbSE8CyZQA/0BldKxNAtAwG4qw wCLxsZ5vBL3Zkh/PdvtFCj/VGscGzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmnY1+MFCQZCUjMCGwwACgkQr5LKIKmaZPPQKgD/f3FtERbJ+LYHLSG/ZbLNAOLngUlQ qo5VfIyJOzeLzC0BAP2PIUFIHo7vmia/PXEmT+ve4c5rx+EkH/Dx1GRpjWoI In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.106.82.30] X-ClientProxiedBy: EX19D005EUA004.ant.amazon.com (10.252.50.241) To EX19D027UEC003.ant.amazon.com (10.252.137.250) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EDEC0140002 X-Stat-Signature: x3h199a79xat6hyin95yrf7xzq4xk1ai X-Rspam-User: X-HE-Tag: 1775835055-630602 X-HE-Meta: U2FsdGVkX1/S8VE5Kkf13GWJPX3IAknBe6elhMfe1P7jWP/C6huuWHTLLa5qA5I0nzK/PEKB7glWLyNXg0QAqr2Eez2l0daSxvFIqNSpDIi1PIUz2EgZHJIWLgrL6u8nf9mgH61bSmlslM45del7p2i/z5/7+JVy1BTyJLKKa7VnN+Sjl//kv+FjN+aDPiOkqk78Xpp+bDHcUKhGrX+0FcOOPSl0BcPS2kiyrClyjL1SiimZn6bqRbaUQbP1/9koKZptwYWUM3MLFXNGoP7GHnKBwB/VfQ0kvyqC35x5vc/uPq/hBLPGlwUwhnC5tJbXSya2VqUQjdM50WpueO9yEjpc5PDBhRzEnEJSVvRBn4b3fZXv0/QEVEQD06pLe8f9qZhGnP9hZzH5kVY2j6qJbyKwkWBLWQDTT6GNsDWmxYOYZOZmNVkLPkeImtskkHY9IzEaYg19sEyYJru1fFXSFnx/PB6p79A/NRecxveH/TzeX/hjYo3Rzh/jUQSR/6ltQJEF/5i8tEmjHVVuBdj7Z3VyAmu4aLnakGrGNUkKF1/VgjuxUhaJpjWLlqCGnDozjkOncGaQqFjM5EA3fCIKW90d9R9GjKAQb8OF08+LzQ5VO2VTXzQWC4U6rNjKAJjnLbe+jcCGLAJmW0UkHgMWFdiy++iVdI97Sc7bceYn9nTvlHwsOrUsG6Kohpi2z7S8u80S8HI7mtSsodWE4I23vmNcoB+JnbD0elWTwqH1UKNPUtke86eaDzIgADLBC/8FJK4K7fIQyGNkPtM3JOSdM89X2Q4f7kiDp5+VOHYwPg7i/Zu35eJwq04R28pE/zVdrTWjSDUt9pIBLkyECnWh8HohjktSw+iEzOzaDm9iw0Sr1nSrtL7w7WnRStXXff8H37Zmodll/xeqF/sMVMVA6SV5xAwZNpRj0jeCZb/Xupi3aSqm81yF8cwZ2mTWnGGalqkAaXeHEO4zQQgIOxy a8yo1fQT 1/LsOCmzULnBXhEfQZWApu9w4KTVyaLBw3B1docN0+uJpmaNMOrFBtzNr+ErcQItxQOhK9BYOwL8BmmV42Zox8Wh9B5EFO6e/KYKasfifkON3ArI4JorMmPL0QdKnIzIM9onZeuCkX+xSInuFfJXtWVQZJLl7RowOVDspD6aAJ6EkRnmo0lyBkUjeSGGVEVd77thk+ZwXdMdOjxbwZnmIlPxVmcPfcr6H3+4X5GwmlRS/2miRT+tAnW2tLaPo71fQlkN38DPT+GBnhHDi88S03ll+VlATSF/6aa8EF2+KChCfuVuXnyCPeyUVMknyG9+m0oo0Wr9g6g6DSqyoZgzCEzIPOQAIYW9D97NAQAd17E9Gs6ZUjk6lFZSLfH0ga3j/EWROw51q673vVx/U09WyIfN5O1/rvAsFIoCwlltkIg+2L5UuKF9Ufjb6Cl45RCLtNRNAQvxxRY5PEks2Apk3Rmxgcsrus4mPAkemW3lv0oPS8OTKzS/zRepifJbApqJ6CvoOk34SGdgV0ljE7O/l0lBil+lkUe7joUt2nDz8cCqpvxc3UgqObrbDm6WuNgRfpHFXFBeXTvihPAj81o9HC8tIk8pJnehO6zwUVaYUGvXeUooSTwmuEzg/XmLCnt3Bk8jdMwBl4bhgwUY1/qNVfTfmUA== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23/03/2026 21:15, Ackerley Tng wrote: > "Kalyazin, Nikita" writes: > >> >> [...snip...] >> >> static vm_fault_t kvm_gmem_fault_user_mapping(struct vm_fault *vmf) >> { >> struct inode *inode = file_inode(vmf->vma->vm_file); >> struct folio *folio; >> vm_fault_t ret = VM_FAULT_LOCKED; >> + int err; >> >> if (((loff_t)vmf->pgoff << PAGE_SHIFT) >= i_size_read(inode)) >> return VM_FAULT_SIGBUS; >> @@ -418,6 +454,14 @@ static vm_fault_t kvm_gmem_fault_user_mapping(struct vm_fault *vmf) >> folio_mark_uptodate(folio); >> } >> >> + if (kvm_gmem_no_direct_map(folio_inode(folio))) { >> + err = kvm_gmem_folio_zap_direct_map(folio); >> + if (err) { >> + ret = vmf_error(err); >> + goto out_folio; >> + } >> + } >> + >> vmf->page = folio_file_page(folio, vmf->pgoff); >> > > Sashiko pointed out that kvm_gmem_populate() might try and write to > direct-map-removed folios, but I think that's handled because populate > will first try and GUP folios, which is already blocked for > direct-map-removed folios. As far as I can see, it is a valid issue as populate only GUPs the source pages, not gmem. I think this is similar to what was discussed about TDX at some point and decided to exclude TDX support [1]. I followed the same path and excluded SEV-SNP in the patch 8 [2]. I kept your and David's "Reviewed-by:" for that patch, but please let me know if this makes you change your minds. [1] https://lore.kernel.org/kvm/aWpcDrGVLrZOqdcg@google.com [2] https://lore.kernel.org/kvm/20260410151746.61150-9-kalyazin@amazon.com > >> out_folio: >> @@ -528,6 +572,9 @@ static void kvm_gmem_free_folio(struct folio *folio) >> kvm_pfn_t pfn = page_to_pfn(page); >> int order = folio_order(folio); >> >> + if (kvm_gmem_folio_no_direct_map(folio)) >> + kvm_gmem_folio_restore_direct_map(folio); >> + >> kvm_arch_gmem_invalidate(pfn, pfn + (1ul << order)); >> } >> > > Sashiko says to invalidate then restore direct map, I think in this case > it doesn't matter since if the folio needed invalidation, it must be > private, and the host shouldn't be writing to the private pages anyway. > > One benefit of retaining this order (restore, invalidate) is that it > opens the invalidate hook to possibly do something regarding memory > contents? > > Or perhaps we should just take the suggestion (invalidate, restore) and > align that invalidate should not touch memory contents. > >> @@ -591,6 +638,9 @@ static int __kvm_gmem_create(struct kvm *kvm, loff_t size, u64 flags) >> /* Unmovable mappings are supposed to be marked unevictable as well. */ >> WARN_ON_ONCE(!mapping_unevictable(inode->i_mapping)); >> >> + if (flags & GUEST_MEMFD_FLAG_NO_DIRECT_MAP) >> + mapping_set_no_direct_map(inode->i_mapping); >> + >> GMEM_I(inode)->flags = flags; >> >> file = alloc_file_pseudo(inode, kvm_gmem_mnt, name, O_RDWR, &kvm_gmem_fops); >> @@ -803,13 +853,22 @@ int kvm_gmem_get_pfn(struct kvm *kvm, struct kvm_memory_slot *slot, >> } >> >> r = kvm_gmem_prepare_folio(kvm, slot, gfn, folio); >> + if (r) >> + goto out_unlock; >> >> + if (kvm_gmem_no_direct_map(folio_inode(folio))) { >> + r = kvm_gmem_folio_zap_direct_map(folio); >> + if (r) >> + goto out_unlock; >> + } >> + >> >> [...snip...] >> > > Preparing a folio used to involve zeroing, but that has since been > refactored out, so I believe zapping can come before preparing. > > Similar to the above point on invalidation: perhaps we should take the > suggestion to zap then prepare > > + And align that preparation should not touch memory contents > + Avoid needing to undo the preparation on zapping failure (.free_folio > is not called on folio_put(), it is only called folio on removal from > filemap). I reordered both, thanks.