From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E35D1C48BCD for ; Wed, 9 Jun 2021 10:48:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7431C60FF4 for ; Wed, 9 Jun 2021 10:48:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7431C60FF4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB8006B0036; Wed, 9 Jun 2021 06:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C67976B006E; Wed, 9 Jun 2021 06:48:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB9D86B0070; Wed, 9 Jun 2021 06:48:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 787B56B0036 for ; Wed, 9 Jun 2021 06:48:46 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0DC9BB9E3 for ; Wed, 9 Jun 2021 10:48:46 +0000 (UTC) X-FDA: 78233862252.19.1DBD625 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 77087C001C7C for ; Wed, 9 Jun 2021 10:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623235725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eK4YrgIitVNuRzbtJ6elIl2Y09eAwO9jJx0UlWIgk2o=; b=HUauVDh7eP53THWS1EGvBuTrDWM3ibwLY5qLjKpRGPX/LDmLKyI6Hm3evhymHS8fVqfLXw 8gQglau0+t96uY4f/qKKzL6kC6Zyn4ikPuH7snRHhSp9dGhxP+gGv8QmHPgUQ8JOTVlZp3 fVPlWy9b4M1Ca4iBF/KPC6g+hmBvguo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-Smvef1r_PEWxiCpydY59Ww-1; Wed, 09 Jun 2021 06:48:43 -0400 X-MC-Unique: Smvef1r_PEWxiCpydY59Ww-1 Received: by mail-wr1-f71.google.com with SMTP id n4-20020a5d42040000b0290119fef97609so751283wrq.18 for ; Wed, 09 Jun 2021 03:48:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=eK4YrgIitVNuRzbtJ6elIl2Y09eAwO9jJx0UlWIgk2o=; b=RZpEE8t+fOdoxyLqo9bqhCe/qTQv8K8Go+clBNBfl3inIT3m/av4br5uMgTgHL22v6 HzwEl1dHdeOU762g4tePI89kT43Kaa1Ble9TFOJBOckQsR/VXu8dqRFxTqqi2EIXs4iD MrUOPrgKfkmAQ/oEQPOQE0rPbBOOFPPpz5D7BgHwvvMKycF0ezmolbltmpz+Bw13H2KY Vr+UheIlldAyIuXKJ22NYWgzepV1iJ7A+ekQlZuq8dNvBlOfU/NzJ05GipMp/c3eGh6+ E+GRDhBg9KabN3Z8k57CDGBo8RwDTnPPvX04w/itJXxYXRRmpy6T/fKqz6+I3bgTKVJx 1vVA== X-Gm-Message-State: AOAM531nuSZC6z9+pIVmBnDMDQF+F9dmdcJHsJMsJ2zYp0OfK5TqqrqL iuWyrVglv6gh6nwKzkLPpaxonKS3s6nrLWkYmBl/i+ghNThS+yfJqBupfDfyjjvOewiKVyHs804 GzjwP/l+H4UJ+fkjVW8nyv1xqath6/MXVAxlQfz2NlXQZ1DXqRSYr7Z6LnmE= X-Received: by 2002:a5d:6acf:: with SMTP id u15mr28034979wrw.262.1623235722713; Wed, 09 Jun 2021 03:48:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvjjNUB0ALcT+A+SOmAZxR0bBNf5wlAMaKj7S1GashaETNJDj/xZjHT+VweSIgZ547v/tWVw== X-Received: by 2002:a5d:6acf:: with SMTP id u15mr28034965wrw.262.1623235722535; Wed, 09 Jun 2021 03:48:42 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id z11sm22292966wrs.7.2021.06.09.03.48.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:48:42 -0700 (PDT) Subject: Re: [PATCH] zswap: add reclaim trigger and stat for debugging To: Ananda Badmaev , linux-mm@kvack.org References: <20210602092753.10566-1-a.badmaev@clicknet.pro> From: David Hildenbrand Organization: Red Hat Message-ID: <457d5c4a-41d3-6052-b80b-a5c9610ead70@redhat.com> Date: Wed, 9 Jun 2021 12:48:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602092753.10566-1-a.badmaev@clicknet.pro> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 77087C001C7C Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HUauVDh7; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: q76qrcnc413s1szi9q6f9qoak8btb9rd X-HE-Tag: 1623235721-370243 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.06.21 11:27, Ananda Badmaev wrote: > - Added 'total_pages_reclaimed' stat to debugfs in zswap. > - Added ability to reclaim pages from zswap using debugfs. > - Added u64 reclaim counter to shrink_worker() I wonder how this is really useful from a user perspective. Wouldn't it make sense to shrink automatically, e.g., when reclaiming memory because low on free memory (OOM?)? -- Thanks, David / dhildenb