From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6536BD2A520 for ; Wed, 16 Oct 2024 14:43:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F12076B0096; Wed, 16 Oct 2024 10:43:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC1D86B0098; Wed, 16 Oct 2024 10:43:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D89B46B0099; Wed, 16 Oct 2024 10:43:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B9C506B0096 for ; Wed, 16 Oct 2024 10:43:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E1860A0529 for ; Wed, 16 Oct 2024 14:43:39 +0000 (UTC) X-FDA: 82679734662.25.BD2390E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id E4AE580014 for ; Wed, 16 Oct 2024 14:43:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729089719; a=rsa-sha256; cv=none; b=qNNhrUQj8EvWprX+MQNIC1zvLANBt4Ue2QFj18DjgUWTVQwGvKE+fx9d138Fj69Ovqfpbm +t9l9qIz4GjlwVjQSMkayeR9A9jEfOYfyv0iYX7Af1a1aLG5fJLB03BJTUY4QqNsW7NO86 wo8BpABUpO6rhCy/7TUMOU+csIPrEec= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729089719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ap8TCtVQtKAEaWVGknPYcFTq1ovJiv5/gXWJd3wztFw=; b=Io0flaU4PTjRoEk/PIc1aMNZtwaNI63IZHYsLZBMS0kY/hLst5BxU1gLF6Kyy9tAn9bBOe tbSdnMLD3ZQIpasrn2A51BMahP42Q28GTer9geYqXLEIvOIOfDFonppuiUscJry+34Ml1F P+Jnn0m4Bn8D6ohPDHiOnfeUPSfCrek= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5FD381007; Wed, 16 Oct 2024 07:44:25 -0700 (PDT) Received: from [10.1.28.177] (XHFQ2J9959.cambridge.arm.com [10.1.28.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D5FBD3F71E; Wed, 16 Oct 2024 07:43:51 -0700 (PDT) Message-ID: <456ea437-fe6c-474f-bd9f-583c6fce9151@arm.com> Date: Wed, 16 Oct 2024 15:43:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 27/57] net: e1000: Remove PAGE_SIZE compile-time constant assumption Content-Language: en-GB To: "David S. Miller" , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Eric Dumazet , Greg Marsden , Ivan Ivanov , Jakub Kicinski , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Paolo Abeni , Will Deacon , Przemek Kitszel , Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-27-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: <20241014105912.3207374-27-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E4AE580014 X-Stat-Signature: qcjyr81suz34de6xznjtxxg44b1yn81s X-Rspam-User: X-HE-Tag: 1729089819-717448 X-HE-Meta: U2FsdGVkX1+PQiUHVFxbe5eV8GhXKn877tO9DJzYLM2NnOsedKhXO1K6wDwKRMTHbDiHN/97df+r/NWcPPDAoJIgt8UlOMaleRyD6INYn6mlosh7UUuLwDra14RnfpnjQYqRoul8x9pVHCLiMgN51N+WEs/heTMDi7T/mY1l5PgPxbt+E7+0lImxG+CznZiK47htOciNJAPMJ5X30sR5DQlE4LdpQ4q4lKtSYoJ7VvEFFRe0pYDWkpZAATvbX46GTlq4eqgbVBsnpjwrlAMYZNl8ZI2/ZpF9mD2ZTGFI60PZd2H1N8L1MQuzfJYQTb9ilhjJwUvom0mGm5ZqLNY34IMeEwxklvdOZtBcHeUs4zixYBvBuu4giriHa4KcOSyAAZTR/8qdPMOLoCMvVwTriE0FjiugtK4rrEH18Ake1X9G2C/p5CFUJjg8qZuCWyQf4RnJfmEiZ9azp+5nRk5Pb59OTIHBoJxb3XIxn2iPJwk8l+iN+mDsK/tmZhDTGRAMHlWUIqLutKVD9pkmh81/EpuRi/7WYPC0YSJiZijayR3Vg2jWy23nujowvX2KSdm7/4bxTB0X1gjLB2b7+xN+MWV/rfBhcbEn57B8cfpzaPfMCSGazYv7BLhIp4SL74Bgy/NIk/1D5WOBFT9rKT17dYoAiaZvRj8w5jJIsYGYl4jv3zuynid8eqlrfNpO3wjxMlM9k3gLYUaNI+zO2jNQXN7HDJwsEXCg4KDk4SOdnpQjhc+HDUskb+igaCt8cmTl5QhnbcCKHk0kLN/unH//0h9tpBKa8S6B2zD3kau+kiRF//NKjrGH8BQoITpePXqCt8g+hRuDcoHQKQeuHnnvXLkkiP5JDnNZob8KllcPxUYODzd9ob9brAz3LYtr9e0x/8qYsOOnZKZ7TJfAYKiI5AuTAaLLnG/1txCYqE7zSvqCouL5F/SoKLyT79XRCkWxKIBr1zB7quKlVzZhjhA mJh6EO1j xItJ62pMGjP/auPpJG8LmUcBLtvyf63K4zZZ3ZOAhgCShSoZa5romgFojfEYF5cNvMXnAIvqsH9VS4Il54a545xHHT4DCkSBxel3TebvVg5bjXbqadWHLy1fvu5LGH2XK+qW9TdnfJdGl1CvT3dhgniCOAoO9NaOEHtqTqPKuaFlYFdSabJo1oicxJLACud+dYCMYmSHVJ+hOEmyxxIvRMqXKILhr+D4st24Q6qMveyoag4pqmTUv73mAmgFU3fuzrQwFq0FxQcK84ebGb9hlscBCmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + Przemek Kitszel, Tony Nguyen This was a rather tricky series to get the recipients correct for and my script did not realize that "supporter" was a pseudonym for "maintainer" so you were missed off the original post. Appologies! More context in cover letter: https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ On 14/10/2024 11:58, Ryan Roberts wrote: > To prepare for supporting boot-time page size selection, refactor code > to remove assumptions about PAGE_SIZE being compile-time constant. Code > intended to be equivalent when compile-time page size is active. > > Convert CPP conditionals to C conditionals. The compiler will dead code > strip when doing a compile-time page size build, for the same end > effect. But this will also work with boot-time page size builds. > > Signed-off-by: Ryan Roberts > --- > > ***NOTE*** > Any confused maintainers may want to read the cover note here for context: > https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ > > drivers/net/ethernet/intel/e1000/e1000_main.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c > index ab7ae418d2948..cc14788f5bb04 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > @@ -3553,12 +3553,10 @@ static int e1000_change_mtu(struct net_device *netdev, int new_mtu) > > if (max_frame <= E1000_RXBUFFER_2048) > adapter->rx_buffer_len = E1000_RXBUFFER_2048; > - else > -#if (PAGE_SIZE >= E1000_RXBUFFER_16384) > + else if (PAGE_SIZE >= E1000_RXBUFFER_16384) > adapter->rx_buffer_len = E1000_RXBUFFER_16384; > -#elif (PAGE_SIZE >= E1000_RXBUFFER_4096) > + else if (PAGE_SIZE >= E1000_RXBUFFER_4096) > adapter->rx_buffer_len = PAGE_SIZE; > -#endif > > /* adjust allocation if LPE protects us, and we aren't using SBP */ > if (!hw->tbi_compatibility_on &&