From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE0AC001DE for ; Wed, 19 Jul 2023 08:18:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B655D8D004F; Wed, 19 Jul 2023 04:18:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF518D004B; Wed, 19 Jul 2023 04:18:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 967B98D004F; Wed, 19 Jul 2023 04:18:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 827DA8D004B for ; Wed, 19 Jul 2023 04:18:09 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4D8E9401A5 for ; Wed, 19 Jul 2023 08:18:09 +0000 (UTC) X-FDA: 81027658698.29.0CF9648 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 19747140028 for ; Wed, 19 Jul 2023 08:18:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TkvMVbjF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689754687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MmVR/bllIudc94xa/30s1JGUSnUJtFWF09nSa97ATdk=; b=XUv1KyTQc7yWQEaZnUg1BWeUxauqe277OCtz7KB4+0/b+Y30E2vltltCjAJpAi0gi8mS8O w6GJBFmU+xtaaBmRaOUOGi+c1lzgjmkqdhXZsrla2tmaa1tMkuFQVUHTeNFchlIV4wsQIz 3VKe1Zu2md24qO0CIPjupwojQq5/lno= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TkvMVbjF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689754687; a=rsa-sha256; cv=none; b=JOsXAxTTF7+ke386ll4i+Zt0nHi879kbxwSU3YZdh9Vv9evG2TfCDJQRk96QrgDLEUd8da equ07wXiVLaG5GiAhXg1+GoBa2bL2thcPUTwTmLCVqKXt2Wq4oTgXcDpWFvnL1GlHUjx79 S0Rcq0lONKX5hxjONYXEsNszrRW6DaI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689754686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MmVR/bllIudc94xa/30s1JGUSnUJtFWF09nSa97ATdk=; b=TkvMVbjFo+6H8ZozwyHZXCW44Y/Hvq1Awj8HnEDATCSDeoQPwp1MtKofuRo/iGMmlyciyK K4h+M9dWPzPMOkDF3EJTslfzjGkzNeekdG6bWCPpa6ONmtoxn6BuoVb4aKO3laN5rpYr/7 kBXKjZ67J3nEv005FRPgiftBnI4s4xA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-YoB0vK8TODCQueeYjlebXg-1; Wed, 19 Jul 2023 04:18:05 -0400 X-MC-Unique: YoB0vK8TODCQueeYjlebXg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-314256aedcbso3693451f8f.0 for ; Wed, 19 Jul 2023 01:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689754684; x=1692346684; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MmVR/bllIudc94xa/30s1JGUSnUJtFWF09nSa97ATdk=; b=Kler7Xe4pqfIxq1kC3tWMhB9XvPl2zmwFzS5yq/CuBvbrq1reA15JN1XYZ+NW6woWN +RcXVaU+r2eFzaErEi7gkoNHfpBlFKJUgB35Rf3jGoEfbWr/kNxxBIIA0zXnt4MUJ8Jq 5lAMaIy3tEc1Rxj5OWRdysGe2zLUh1hGebw/kMlszlHyE11uKzwWRDNEevyzhTXzs5Qd LkeX5aeImICpIZBQbUFjJDXboB2BLqrChBopvRWrhW0oEsD70LdXK3W6O8OjgCURnhDZ GYieACcdC5dAiz6vcKen5zjqOcOCn3ucCAgq8Ke4U7yelZNR9uhsnHG5c1Xop2iazFLy YRvA== X-Gm-Message-State: ABy/qLYZMFHAVZ3JUm4glshT1BEcKG7R9oDUjJoCL/FlAM59fHTOr/NE Y/9pMlmdEy85J2bRm57GJIk8fsGx04TIyIRL2SFnLFazZNmvYDMRCf3A8ydWAdhUcSIiGv8rz7d +lh0bcL7EXNE= X-Received: by 2002:adf:fe49:0:b0:314:1ca4:dbd9 with SMTP id m9-20020adffe49000000b003141ca4dbd9mr13566756wrs.27.1689754683964; Wed, 19 Jul 2023 01:18:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlF49g1Vta7mjhC1+bf3quUqv/nXAVqJtAkEUDjFA8Ku+wnpSH62a3c0EOossUbfX4CpB0nijg== X-Received: by 2002:adf:fe49:0:b0:314:1ca4:dbd9 with SMTP id m9-20020adffe49000000b003141ca4dbd9mr13566743wrs.27.1689754683589; Wed, 19 Jul 2023 01:18:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:4f00:b030:1632:49f2:63? (p200300cbc74b4f00b030163249f20063.dip0.t-ipconnect.de. [2003:cb:c74b:4f00:b030:1632:49f2:63]) by smtp.gmail.com with ESMTPSA id n10-20020a5d51ca000000b00314398e4dd4sm4588195wrv.54.2023.07.19.01.18.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 01:18:03 -0700 (PDT) Message-ID: <456a78ae-5d7e-9955-5edb-f9f46c22bd75@redhat.com> Date: Wed, 19 Jul 2023 10:18:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 1/4] mm: factor out VMA stack and heap checks To: Kefeng Wang , Andrew Morton Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org, =?UTF-8?Q?Christian_G=c3=b6ttsche?= References: <20230719075127.47736-1-wangkefeng.wang@huawei.com> <20230719075127.47736-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230719075127.47736-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 19747140028 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8ukhfnp8cczfkh9p1z59dfmf1p9rxr7r X-HE-Tag: 1689754686-204820 X-HE-Meta: U2FsdGVkX193+46f0JzfY72EfxpRxdGJHvMDXF4F/3UEE7YfpSaggSVMNB6LNVGffu44eK8GbMc7+UmByp+qeSaVhVlzGm8N+hkzFT952iX7z0RHq21qbOBx2rAmDDP0+t929geQnWmGVy+UM0x6tjNr4g36ubPNk/cmwmLhwI25h4FuQJg232pXa7Oo3bME6dufsrdVW26iidg7KwbYVhB+TQvulkWBmgpx/RC7oQ73P6O6CiSDlkBQ/kLn5pU0D1mYzegFSN+88jcNmadA3c1B3CrLF05WdFfMi2zxTySKnEZaOJi3vwWX4S+7O8G3LJ575oFeJwnAc6H9OT1X3jDdJ5HTrI6eFJTwCFiggJ/sgX+dXXX7NS3//IdkDP26BVoN++NDVkDJ6gtIG9aDnihpaW6m/ppH28QcVRIcYns40MWCmCJRd0zzSYX8NeinbuS+ftQFrFoGoceg1AcVtH7wWmW6x5meuIl/i81Iae85OKWEqeS6zFNSR31q1dTXyoL7yGP8orjsjGmOp5Fw0Jl08Qk4yBU+WkqVJDaIQehX5mC4UzL+/8ETbsM8cyU6moMEY2VK2EinjU20IM0uxJFix6j23wjn9MMyeIUjBXvGcSIUdbFG3xKYXA6idPWfKBCycR1tRpukfOSmCMV+ZMVBWsd408qYcTRKXcQVCRSzCyMNefY4pVxkjRo7sNsF8rZHT9ujxC7MfRl4CBlfxiQRq+Tbu/7p261ayWrUMP0HzP1Wa/aGDoby/flhdT+o/TdynVnbZkHiWBo0tiPJNzCuTaAwEwwncL+EUqan+T8215ilLTyzyRC/cLaxvvB82UnzC42T+fb16ELQ0O9ErzwAWVjbwRFcULVTXU5vwksnOIHIytMuAixYWKoSDQcB1AagGSf2BJDV5GG66WdBu7DrLcw95q5fCHKNQ6VCLeMwUttO3H3mmIOxrHxKCrJtIhD/lIHQaFolE+UaH0C G9S62mdT zYrkqFZtzpz7Ci0zLAFiKL4sJzhfZO5FYJIxNZWTI+wBUi6r5ulJZXZliwq/PIBHFluisd1JbLZc8IgnslXH2uQywxpMi159lY/IDCbHLfr0nKHVa0Vk/MvlB/e6zggkcqf4QKlqpoV931uFpxJ5glqjpeQ4qtJGOrAZuTN3KBnImxlj5sl62TkVTc2xGugJQpdihe3ftBUdMWW6tT89ZSehOHin3AqzbNJ1ZBkREXjlWoKozocXvd1vwk8FAo33RULak11fMsC2cdlb5s04KwHcM+IcExc+INP6uGvMtjVPxhB1sMHUgzX1uc8GbIIcCj/urRTTIh5BgiunMKWLluvdGOR9qJ/sGn5kUPQd4+A1CqV+2CSbvERuy4QIngFpPJIkS4amHIf5XqqE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.07.23 09:51, Kefeng Wang wrote: > Factor out VMA stack and heap checks and name them > vma_is_initial_stack() and vma_is_initial_heap() for > general use. > > Cc: Christian Göttsche > Cc: David Hildenbrand > Signed-off-by: Kefeng Wang > --- [...] > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2dd73e4f3d8e..51f8c573db74 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -822,6 +822,27 @@ static inline bool vma_is_anonymous(struct vm_area_struct *vma) > return !vma->vm_ops; > } > Worth adding a similar comment like for vma_is_initial_stack() ? > +static inline bool vma_is_initial_heap(const struct vm_area_struct *vma) > +{ > + return vma->vm_start <= vma->vm_mm->brk && > + vma->vm_end >= vma->vm_mm->start_brk; > +} > + > +/* > + * Indicate if the VMA is a stack for the given task; for > + * /proc/PID/maps that is the stack of the main task. > + */ > +static inline bool vma_is_initial_stack(const struct vm_area_struct *vma) > +{ > + /* > + * We make no effort to guess what a given thread considers to be > + * its "stack". It's not even well-defined for programs written > + * languages like Go. > + */ > + return vma->vm_start <= vma->vm_mm->start_stack && > + vma->vm_end >= vma->vm_mm->start_stack; > +} > + > static inline bool vma_is_temporary_stack(struct vm_area_struct *vma) > { > int maybe_stack = vma->vm_flags & (VM_GROWSDOWN | VM_GROWSUP); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb