Re: [RFC] Extract kmalloc.h and slob.h from slab.h

[Nick Piggin <nickpiggin@yahoo.com.au>]

Christoph Lameter wrote:
> On Thu, 30 Nov 2006, Nick Piggin wrote:
> 
> 
>>I see, I didn't realise kmalloc was different as well. I guess you could
>>follow the same approach. Probably don't bother splitting it, and just
>>move the kmalloc definitions to slab_defs.h / slob_defs.h?
> 
> 
> kmalloc implementation are very different.
> 
> We could segment slab.h into a a part for the kmem_cache_* API. All slab 
> allocators need to provide that API and if they do not need a certain 
> function will have to define a stub in a c file.
> 
> Then we will have a portion like this that redirects to the allocator
> specific kmalloc implementation:

I'd rather not do the stub thing, and just split out slab_defs / slob_defs
slub_defs. Then you don't have to create the specific kmalloc headers either.

> 
> #ifdef CONFIG_SLOB
> #include <linux/kmalloc_slob.h>
> #else
> #ifdef CONFIG_SLUB
> #include <linux/kmalloc_slub.h>
> #else
> #include <linux/kmalloc_slab.h>
> #endif
> #endif

elseifdef works here :)

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>