Re: [RFC] Extract kmalloc.h and slob.h from slab.h

[Nick Piggin <nickpiggin@yahoo.com.au>]

Christoph Lameter wrote:
> On Thu, 30 Nov 2006, Nick Piggin wrote:
> 
> 
>>I don't see the problem with slab/slob. It is not the nicest code, but it
>>isn't unreadable. We do something very similar with nommu, for (perhaps
>>not the best!) example.
> 
> 
> I need some order in there to add another type of slab allocator without 
> getting into an umaintainable mess.

OK, slab_defs.h and slob_defs.h would work, wouldn't it? That seems to be
the standard pattern used when alternatives become too numerous / complex
to be in a single file.

>>But kmalloc seems like one thing that could be split nicely. It would
>>allow you to get rid of asm/page.h and asm/cache.h from slab.h
>>(converting callers would be a bigger job).
> 
> 
> What callers would need to be converted?

When you remove kmalloc.h from slab.h? I guess anyone that includes
slab.h in order to get kmalloc.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>