Re: Slab: Remove kmem_cache_t

[Nick Piggin <nickpiggin@yahoo.com.au>]

Christoph Lameter wrote:
> On Wed, 29 Nov 2006, Nick Piggin wrote:
> 
> 
>>Christoph Lameter wrote:
>>
>>>This patch replaces all uses of kmem_cache_t with struct kmem_cache.
>>
>>kmem_cache really is an opaque type outside of mm/slab.c, isn't it?
> 
> 
> kmem_cache_t would require a declaration. struct kmem_cache * can be used 
> without a prior declaration in include files. Please review the earlier 
> discussion on linux-mm regarding the removal of the global slab caches 
> from <linux/slab.h>.
> 
> Frankly the maintenance of the opaque type here has caused us enough grief 
> over the years. I would like to get rid of it in the future and declare 
> the contents of struct kmem_cache in slab.h. That will allow us to 
> simplify the slab bootstrap and make it easier to understand. One 
> reason slab bootstrap is so complex because one cannot simple do a static 
> declaration of a struct kmem_cache and start off with it. See the earlier 
> discussion with Matt Mackall on the slabifier design.

That's all fine, we're not talking about any of the mechanism to how any
of that works, just what the type is called. So what exactly is wrong with
a kmem_cache_t declaration in include files, then?

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>