From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC180EB64D9 for ; Wed, 28 Jun 2023 01:49:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6602A8D0002; Tue, 27 Jun 2023 21:49:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9D28D0001; Tue, 27 Jun 2023 21:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D8198D0002; Tue, 27 Jun 2023 21:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3139C8D0001 for ; Tue, 27 Jun 2023 21:49:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F2FE2B0458 for ; Wed, 28 Jun 2023 01:49:21 +0000 (UTC) X-FDA: 80950474122.23.264955D Received: from out-62.mta1.migadu.com (out-62.mta1.migadu.com [95.215.58.62]) by imf04.hostedemail.com (Postfix) with ESMTP id 1421A40009 for ; Wed, 28 Jun 2023 01:49:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qPmhKnIN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.62 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687916959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oOyzcJ8VePO1Q+C6BRDa2asTrgF7Hq/6F0KbFPox+Ks=; b=VKSyGL4TGJtnGsG+xk9/69dy/aJcOmPh0DONsIyQTUWD4LAtvSLaAF76kFoygh68BrFLcV FaqypBlerzdMfzOtteBptFhOI5iNF0TToxYBrASodPt6jKdy0Ao5wTDT0mVfw53Z9BFt2t dp7XAyyv4kJX42SnNuiLXE505dcV/bw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qPmhKnIN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.62 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687916959; a=rsa-sha256; cv=none; b=dNj/hy75CtcSvBnzz9NhRKDPFxRuMgDEtU+38FvNs9aQnqXBOUyMChv+8OhLJw2BJqfuWM Tv9ZIjks1tD5tH/6wOmjm+CQPeiq1wjps++TjKiCFNeyO3bAeydqCZmg8XUzAi5/YHL9sb qse8e7k0EimRmwBTRX9XUwSvRzcwz64= MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687916956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOyzcJ8VePO1Q+C6BRDa2asTrgF7Hq/6F0KbFPox+Ks=; b=qPmhKnINywNfOvxpUNbxYp+kqBqH7hwkNQ4PS5AIPiIJaX0M49bhKlHhjx5OtyxVwP1Ld8 FotqAp9S+ioG+EmE3dPT3UWQ7Th8gejYgE6sKLCqLr+BFczkqKArPEpr4WMO1hZ5I2Bv1E GMuJWgzgd1K8mMmQa3dwmny1jAZL/Ok= Date: Wed, 28 Jun 2023 01:49:16 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: <45683de8eea1912297542aad909ece6d@linux.dev> Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node() To: "Mike Rapoport" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20230627143318.GN52412@kernel.org> References: <20230627143318.GN52412@kernel.org> <20230625050850.GJ52412@kernel.org> <20230624024622.2959376-1-yajun.deng@linux.dev> <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1421A40009 X-Stat-Signature: q189j4tww9tmfpps556tznz6mbdouu6t X-HE-Tag: 1687916958-873068 X-HE-Meta: U2FsdGVkX1+59qr17OvnNCzutNjsjm+Dfs/8ycMjZwKXzqW0YYIXc1lzp7I5VsrMxL+hmA4OjCMEEYP9I9ycmlJr4On8N5JNGibbi5aHvvbqNMlH9AelbDzMChYq5ht2MLVbR9Y1XkPECA0ct/ql5g+755WqOvjRm6YGA01fDD/PswaOxpyX3XeekybcD4BK1Sfj1ausG9pAAUdXtqPu2bEftAmfqtnrf6UC5TtMDA7dE/kMQ6kuN+IxaWktEwYEwIQZ438R+f/BcPljSC26P/QLt5vVIU0ZlBEFc63XslPGqge0MVoTku0EOY91xWaIVg4Mqt/2BfM8WVxCH+SBb0cZLVXaAJNYhm1nBaiOEhd7jOU9e9izZJv58Ny0FxgtqYbsWi5D24Snx87ofRPx2u3UtfQSZHf9a0x7BT1ambRxTWprk9pKx0kFqzxns3xN8mfhkp+GIeRxQT67saYXFQaCV0MC8KVIAAQ6NPYh3RdZAoGfIAJN+LhCo2Gfms6vpg03s6FQr9lej4ZmppGdspT5RNImhWNS33kS1FAwSURfS+THZn3EcGHkMNolK+qrqIc0CBZjMwCVaNu21uQN7eK0IQqBMSu7SJb576xYUMS7oOzMQpojpvA/bIhqK1mi5lMPst/cWwQ/xjbXr/aKAOJVTEEPqS13eL1Gi1yfz8NufSouYUSghBz0c3L2kHHy6S3LgWKfDJu8pjAN9w6OfY6M41fUQTfRkg0+ikqLyD/vheLMRiGDPLUqu8Ob6XlnZGdhhLRLFZ3H6+j/GiRJSNsGlp4EkrGmGZ0alhroheKCu7OVmY1TmBx99sHj60dv0xfq6IIcFRzFv1kIEeiiQP6J8jIxreuScG7WO22PPc7ZqPCbedSe8F526PlzK/HjCaXnEn0xGNE1d2IMb8TtYeSJ77AkQTpIeYMBrpal2wWY2OulhOU09s76eAQeuVoMYoHCGV89YWBNNd19EyO O4zEmJCM ClhfIm0fl+l9kDu/07Qff5DPXkYzI6GLnOOi8/dkqSuLIr+dQqbYTHWDd7Tjf6T5b+nSMQpxq8fFr/QllW2evDMOfywZhzy6niC0x9ktG1uB+vlE67N/CtXm1alGAZBzg9OpUFsxCMrJVy4ObuW6v6JgXZVqtc7+Nd/pjkBXFANQyZt8kn9DuVgvDIW/ZyQ6WOph+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000211, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: June 27, 2023 10:33 PM, "Mike Rapoport" wrote:=0A=0A> O= n Tue, Jun 27, 2023 at 12:13:16AM +0000, Yajun Deng wrote:=0A> =0A>> June= 26, 2023 2:21 PM, "Mike Rapoport" wrote:=0A>> =0A>> On= Sun, Jun 25, 2023 at 07:39:10AM +0000, Yajun Deng wrote:=0A>> =0A>> June= 25, 2023 1:08 PM, "Mike Rapoport" wrote:=0A>> =0A>> On= Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote:=0A>> =0A>> It o= nly returns address now in memblock_find_in_range_node(), we can add a=0A= >> parameter pointing to integer for node id of the range, which can be u= sed=0A>> to pass the node id to the new reserve region.=0A>> =0A>> Introd= uce memblock_reserve_node() so that the node id can be passed to=0A>> the= reserve region in memblock_alloc_range_nid().=0A>> =0A>> Signed-off-by: = Yajun Deng =0A>> =0A>> What problem does this patch= solve?=0A>> =0A>> If we set nid and flags in memblock_alloc_range_nid(),= we may not need=0A>> memblock_set_node() in memmap_init_reserved_pages()= .=0A>> =0A>> When memblock_reserve() is called before NUMA setup, the nod= e ids are still=0A>> unset in memblock.memory, so very early reservations= will be missed and we=0A>> still have to update node ids in memblock.res= erved later.=0A>> =0A>> Even so, we still need to pass the 'flags' to the= new reserve region.=0A>> choose_memblock_flags() may return MEMBLOCK_MIR= ROR in memblock_alloc_range_nid(),=0A>> memblock_reserve() couldn't pass = this flag in this case.=0A> =0A> flags are only relevant to memblock.memo= ry, we don't care about the flags=0A> in memblock.reserved.=0A> =0A=0Aget= it.=0A=0A>> I tested this patch and delete memblock_set_node() in memmap= _init_reserved_pages().=0A>> It works fine. I did not delete memblock_set= _node() in this patch just in case.=0A>> =0A>> --=0A>> Sincerely yours,= =0A>> Mike.=0A> =0A> --=0A> Sincerely yours,=0A> Mike.