From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA822C4167B for ; Fri, 23 Dec 2022 08:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5475E940007; Fri, 23 Dec 2022 03:08:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F783900002; Fri, 23 Dec 2022 03:08:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C059940007; Fri, 23 Dec 2022 03:08:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2CF56900002 for ; Fri, 23 Dec 2022 03:08:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0932B40FA0 for ; Fri, 23 Dec 2022 08:08:30 +0000 (UTC) X-FDA: 80272843980.13.5D2BF59 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by imf11.hostedemail.com (Postfix) with ESMTP id 3FF124000A for ; Fri, 23 Dec 2022 08:08:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671782908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cMgM0qw6yt7z+oCKPukK4tuxhoEfRnX47Cch91Ru9Lw=; b=LygcLu2KCjuwQFmZYD7pDUPH/AR5eFojBKTh5cM9VHntgZsWekVTjkFxip2xHr6UFU9J8E mw6iPZZCsDIzhyhvNwPV3NK8dQ7QlpF9VDSe9e2GZ/Ot9KgwAMhMc/ABKeUzwPbmtW8FRY U/c7Un5cYhUg5DpScr10k4QioLpYAWk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671782908; a=rsa-sha256; cv=none; b=0jCID1Z6m0YUJeX2g64cxLNfZ4glEBxqLpKTJIV3gNmzhPHNZIUCERuUBn28S6pWD8IAPg 9+gLS+/En1B0mT1Ghi3CySfmLBRfIHKB5cUoZ5qyRF3d/ceQHKbFhbhJxo7tzcbYV54W0p DJXdwdfGQWFwxFdpX4tdx9ZB61BXqDw= Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1p8d6Q-00066H-Et; Fri, 23 Dec 2022 09:08:26 +0100 Message-ID: <4563bddb-8c44-8d3f-93e3-a1433dc3af3f@leemhuis.info> Date: Fri, 23 Dec 2022 09:08:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH for v6.1 regression] mm, mremap: fix mremap() expanding vma with addr inside vma #forregzbot Content-Language: en-US, de-DE To: "regressions@lists.linux.dev" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20221216163227.24648-1-vbabka@suse.cz> From: Thorsten Leemhuis In-Reply-To: <20221216163227.24648-1-vbabka@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1671782908;ee867ac5; X-HE-SMSGID: 1p8d6Q-00066H-Et X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3FF124000A X-Stat-Signature: 37dsg766ncoymijhukhtrsygtptqecii X-HE-Tag: 1671782908-348738 X-HE-Meta: U2FsdGVkX1+k5HKjpFsMPGl5S/7n10+hp6gjjWeaB+qsp1WeOrboEyLRjVvckKS3yecGx4epSOGLhfwtX8rj807S5um/PrHDeH/0KG8GD2yLcmdF0lf0Tj4kxXYL/qXSO1PD34fvpUFhcBylHzAcmtRqEaxG+KxWfiUVAEUXh0Vp0OTUG6wrInmgeC9xIo+/6/Ad8UDRuWqFCOmRophP101yhV6BCkFdWFM5zY8Xucz8d+owSOLy6B6vpXeOZPohNKzlIdtvuEr5nOMFh1Hzr6AvJ6kekSxCCEEpKqG7Fk4Lbad+xiVgXcdgcstTpmjBUiXID2fFBrBo+FeMoZtRUCvdPDkTamanjiwsnDlvk/r/+bKBUhjEkIEaBbaF+m9ybthJkxWPGl3vp1/J76kkY3vDCmF4huZbf0FtxzQRfH36ksfLqqRJRDx/R//3/ag1DRGp6vCwaHu7pJrK0xso/iUg1s9+Dnz7Ewx3Wflu77ujpALgAq9ccuGJNcEEA8IP213orKLNI2x/FpJZomQbn2x2/8rqeELL6T0wBuUy4eLLVOy4CS+z1W/eDKyUa7OYMbgRVnNI9cFY7KQqjRyKImbNIvbaVbtvCD9bdffGBNn6r5/QGcnHDHoudCYSmcMrH/AmGPYipCce3vbyjCKxJOsUrFH+/kCc0xpzAHO579QD/SaTlUg0A75/1REtwVXCjoVJ+/v9tsWQ14wQmeBpQB15vZHqyznTxko2kdsOBuM13nwD4WTPspFDlY/0GQ4MCsNugap2ElzCCgQCJ+wGdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [Note: this mail contains only information for Linux kernel regression tracking. Mails like these contain '#forregzbot' in the subject to make then easy to spot and filter out. The author also tried to remove most or all individuals from the list of recipients to spare them the hassle.] On 16.12.22 17:32, Vlastimil Babka wrote: > Since 6.1 we have noticed random rpm install failures that were tracked > to mremap() returning -ENOMEM and to commit ca3d76b0aa80 ("mm: add > merging after mremap resize"). > > The problem occurs when mremap() expands a VMA in place, but using an > starting address that's not vma->vm_start, but somewhere in the middle. > The extension_pgoff calculation introduced by the commit is wrong in > that case, so vma_merge() fails due to pgoffs not being compatible. > Fix the calculation. > > By the way it seems that the situations, where rpm now expands a vma > from the middle, were made possible also due to that commit, thanks to > the improved vma merging. Yet it should work just fine, except for the > buggy calculation. > > Reported-by: Jiri Slaby > Link: https://bugzilla.suse.com/show_bug.cgi?id=1206359 > Fixes: ca3d76b0aa80 ("mm: add merging after mremap resize") This is just for the record, the fix will soon land, but I want to have this in the report I plan to send later. #regzbot ^introduced ca3d76b0aa80 #regzbot from: Jiri Slaby #regzbot title mm: random rpm install failures that were tracked to mremap() returning -ENOMEM #regzbot fix mm, mremap: fix mremap() expanding vma with addr inside vma #regzbot ignore-activity Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.