From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E15FC021BE for ; Thu, 27 Feb 2025 07:06:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 999E1280001; Thu, 27 Feb 2025 02:06:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94B9B6B0092; Thu, 27 Feb 2025 02:06:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8117C280001; Thu, 27 Feb 2025 02:06:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 64E576B008C for ; Thu, 27 Feb 2025 02:06:34 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1726E120764 for ; Thu, 27 Feb 2025 07:06:34 +0000 (UTC) X-FDA: 83164841508.11.DE225B1 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf27.hostedemail.com (Postfix) with ESMTP id C23B64000C for ; Thu, 27 Feb 2025 07:06:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740639992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dMCNNhOnNTPbLq7f5mirTVD38KyLCMHYnFB/ehUSo3I=; b=ilUAUnkvcxcbrhryFCBpzt5TFd/CFbZp6m6b7i1RbIyL+LivXGovaGYpzWRhqKPjMmiRkS 5xDPWQsFGn4p34oJXa6e0yA0OeiYyjFwvdvUCJG9wrLg0a5U/OeDjD34Bh1sJwEVGLxLdl bamKmEs1bJD0DHcmhmDUCEBCFQA4p2E= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740639992; a=rsa-sha256; cv=none; b=Uzq4w6+WOaROepF+pKattFLHUJoIiqkHitaPxOPgIx6+vrxjXLkKU3zB3uS7l0Hc+jePYp gAxBKsBCquKw8lKzXiJdrnkCugFI2MBqBJ/vqPr2OTp2z5Gi6xAukEQUM8lY+oYoiKoiPz DLHz6hzG6zwh1wL1IT48zruMdLDtjcA= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Z3MkJ1L2Yz21p2T; Thu, 27 Feb 2025 15:03:20 +0800 (CST) Received: from kwepemo200002.china.huawei.com (unknown [7.202.195.209]) by mail.maildlp.com (Postfix) with ESMTPS id 2C42E1A0171; Thu, 27 Feb 2025 15:06:25 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by kwepemo200002.china.huawei.com (7.202.195.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 27 Feb 2025 15:06:24 +0800 Message-ID: <45638e1f-f91b-ad8c-9f8c-c2fbd0899a18@huawei.com> Date: Thu, 27 Feb 2025 15:06:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages To: Oscar Salvador CC: David Hildenbrand , , , , , , References: <20250225141933.3852667-1-tujinjiang@huawei.com> <44267aae-4209-c5d2-9d0a-b9eeb4bd4bf0@huawei.com> From: Jinjiang Tu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemo200002.china.huawei.com (7.202.195.209) X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C23B64000C X-Stat-Signature: h1cckcoxkui1k6phojgzd7b4pjysskm5 X-HE-Tag: 1740639991-209865 X-HE-Meta: U2FsdGVkX18NJ+jJntTDTJXuUbomqaGYa+NKu7/FTuMXRG8+ch7mHm+bEvwNLfiHOLeWKmp+IntLm/Nt9LLC/j3KNEYhHf4Axw6WuSb+M5/zOpv4hgkB03Vy8+3QjiwPij92jNxHmoRkUrGiUk3dYoUoiooADS9ryVOmR3HK04ifNBbK05krRMaP5ah4pjMK6pU6Oy/1rEiSgGhf2RFNh21HyOQprH8Q0CaFg807g8vL/qRtu51OUIKizNOrGELXqFre9S8EsU/n+gGSJ65rCa6CiRToFodZunrv5WFHTHtUUisnIorUJ2x4y842+ECUGbQ2WJvjGvrvTu2e5yymzklk1I8BDUM0sfatdDm4vWXx/LExk/wGY7PHJRzkdvXSpIcY/g9GhzwdLzCh3109HguWewunh7Pb7t2L/zuIo0uAEimzalNNbouOgfQS8dDOq5vlEHltr6EGCigyRq2snRwCOMxqpk+aj8bkJly84kTFbaiyNGnClx+Lwqz14+5xu9/fVx0NHHX3PbktqdyWQJLnHAg5ed8A3a5gzucuWgwQ22nDnnTQ82QYZvbeK5OapJDGuC+ZKL8eoaq8FRL5TtPgPVfP0KG4KKD5A5lGPLxxs+1sSFX7gfHfy74Ii/BGjsxG9ND2utNZhA6oUv8n1ZNhwq2VqXBAPfMEAVC6mHalANcLbuJWx+1u5/rl/8NyEoePIRcEjgiVMH5P7LjqT7sorFnt+oPlhvjtMsvks9CVAqRaYsqyQ2DIpy2deQmenbwNCI7gCRKoueLH/ZcPa3zF7jWPtQWzz1J8+17ENpCRYtqsHmDUKCCPQlzeABxfwuT5PbW/CT7CqgYSy36RgE0yl5/lWxNhqLroyDOA6AJmvBt7vQndARGV/lyrTBqtYItcJH/1eifCZB0uG844BpqSrYBoIeaHz3oN9NTb57niqAQ/4mZyoj7EuNJoIKmK2QR2RnMTy53U//7e89G cljpJkwz a7p9gHLeUstO0Qa8h6oKRT49YQvsIgqC1PaKDhpeL2JH+puuL1QP81jG5rrAvXua0qYbMm9Kv44hPxmFcYx/Ten65QzttUAO4xSIwnqw8xty9IeE3j6O4iPkQVDaTslu5HqEpqk9z5W892XM5zinaXcWCU0HwgYXp3NhtBpBelQkcLytbtbLdd5O7c74FSGy6is6xi/zRlxKzDTE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/27 14:19, Oscar Salvador 写道: > On Thu, Feb 27, 2025 at 11:11:25AM +0800, Jinjiang Tu wrote: >> The result with this patch: >>          Node 0    Node 1 >> Total     5             0 >> Free      0             0 >> Surp     5             0 > Why would node0 have any surplus pages? > > Also, this does not reproduce in my machine. Sorry, I missed a step between step 2) and 3). After step 2), echo 0 > /sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages So, the node0 has 5 surplus pages. > > Are you overcommitting? Are you using the hvo optimization? > If so, it might be that we cannot allocate vmemmap pages and those > hugetlb pages stay in a surplus state? > > >From bulk_vmemmap_restore_error(): > > * If unable to restore a hugetlb page, the hugetlb > * page is made a surplus page and removed from the list. > >