From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D32A1C4345F for ; Fri, 12 Apr 2024 03:49:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E8476B0082; Thu, 11 Apr 2024 23:49:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 297AA6B0083; Thu, 11 Apr 2024 23:49:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 186BD6B0087; Thu, 11 Apr 2024 23:49:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EE7DA6B0082 for ; Thu, 11 Apr 2024 23:49:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 725A4A144E for ; Fri, 12 Apr 2024 03:49:45 +0000 (UTC) X-FDA: 81999500730.10.0F3F4D1 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf02.hostedemail.com (Postfix) with ESMTP id 43B5480002 for ; Fri, 12 Apr 2024 03:49:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712893783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i9JV8sHlOqhIkp5o0m3qJMhBs2b3w4vO2PTq/RDvJ4s=; b=1HI55COQfbL3x4eHt6Wjoz5AyCtxDAYZK+vf0AkFKZxlqO5EOw9bGAI3a3Iac3rplE++VZ +/ZvpVBLNKjmzrdkPGIlHLGesJTnRmQixBbIE2yyHqahqOu5bw78Vy48xy4CEughxQhCnl A2TYZLIbkA2vvXlLlPXgsRlc63DkqZU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712893783; a=rsa-sha256; cv=none; b=ToTfUwUBQq58w2ghbO1M9HOebYc29E0pROV5ebxO16DOQek2O2eP057U9Oxb5rWOv18CVk GGEyjZ9QU9ia5ayrk986upEGwhZCgQEemHqHJD9/IMRuMHj6qERs2RfvHE7/VA99uwG+FB M37S1DKi9qZUu5ShmPh7cescX1DXI5U= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VG2YX3QNZzwRcq; Fri, 12 Apr 2024 11:46:40 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id CD1EC140124; Fri, 12 Apr 2024 11:49:37 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 12 Apr 2024 11:49:37 +0800 Message-ID: <4549178a-0168-4878-b4cd-db750d3ff6ac@huawei.com> Date: Fri, 12 Apr 2024 11:49:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: filemap: batch mm counter updating in filemap_map_pages() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , References: <20240412025704.53245-1-wangkefeng.wang@huawei.com> <20240412025704.53245-3-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 43B5480002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: bz6iyqbza71bdzxm7pr3hcrgyhpiypzc X-HE-Tag: 1712893781-35980 X-HE-Meta: U2FsdGVkX18hM9DOoo8eckWwB0efyrSu+5b70vwqLauoAkE0+AiMPSRsSmKwG/ftafW870mNucMfh1f9goyx9+GywDsgES0k7PB4zfb0OUgZF5QD1euE/XO1sBFxXnbc7wZTUGEFdsnEQsvJ5Id3lQE+KSS3BaMSfGTYm92EGSU1GyTUffEbBEnaI5DaOPwEYEM9GB7r/SZ32YvbmnrOuGfUhF6IKwK3CuxSsxW4xcbqELIdKOAcEUW6KqwTEVPmhBz2YARxBU8EmG/0zJQ8fwsCGZnNC7R9KG8jGcpa/71SV3HKgsSzZRfxMdJf4DeD/ymeOlYHhdQl/UHK83PVllBWeEvidypbB0m4gFNeieHsor7BssKknO+1u71xpCMm/JEPMVWE+gOX9kDHJABMMYQrgzxvmQDdWSJaqbFNT4i1sJ6lgKzo3MBwPTCO+TrHobWlQCzdBZ2ssosLgtBsEqhflSlfzGAT/oKjxw3wBMzbY/+FMYJ4qGuG0/O3YX1sTM015aI97C/I+6uWIOVcP+gKR73xuyZnrcqHl92CRojXbCdAr7kfP1QTqAXbdtM3DiXWE1TkI7HoIq/0ejM0FqnXJ7TZUQICbHlHw8CX8gh85yHaF3sZHJ6CkduTrF25K9ZE1jtqeTAivZsaB1MnxhkOTFj/waBeX4JUVA5JZ7rn76xEvdlIH8r1eOU3+4wbP3Vay1WtoNyunCWwCvXaxILDCs5p4OS6owsvjhjG3rM35E4caK19SPfrapvElR6AhVQmUfv1W06KwPLRpUbVtoYGLNtG9qRVzmAqhaOTo//7I5I3RMRffxuQygd7W4SmpwS2KHMCl78+sM17W/pnYYv/bH+JpwEV60XLk4zXQXKZGd48K3xfGzLNCCqAFgohlX0qmTmbttResVR4cAxAi4/ecotJ3z4LkWxk9A1kiRsUePwxzQsQRGSsdchiO2wE7iKDwjHin+pgqQrwanb VMp2Ov92 kckZxKYzHKtLbvdaHJQS7PBIcbJBzqhrZuqJ5noZKS3QAmjmAnE3QV0J9dIRbOXj5idekpG+IIJedDWFxkIiQTLSvPEQM4Poeny+QgVIPFsz4aXRWXzBiZ4PT4iDyXTqkA9t0IyP2QkFweGVeMV9zpPzTB8ONEM15Qw1yfao/cHmBJ3MQJ2CW1YUgSAO0t6Qj44RePDUSlcbSvK4RCBsqD7mfeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/12 11:17, Matthew Wilcox wrote: > On Fri, Apr 12, 2024 at 10:57:04AM +0800, Kefeng Wang wrote: >> } while ((folio = next_uptodate_folio(&xas, mapping, end_pgoff)) != NULL); >> + >> + add_mm_counter(vma->vm_mm, mm_counter_file(folio), rss); > > Can't folio be NULL here? indeed, I need get mm counter type before while >