From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D27E8C433DB for ; Sat, 16 Jan 2021 09:44:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7FB86239EF for ; Sat, 16 Jan 2021 09:44:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FB86239EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD8788D0207; Sat, 16 Jan 2021 04:44:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D622F8D0200; Sat, 16 Jan 2021 04:44:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C77228D0207; Sat, 16 Jan 2021 04:44:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id AE23C8D0200 for ; Sat, 16 Jan 2021 04:44:23 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E93608249980 for ; Sat, 16 Jan 2021 09:44:21 +0000 (UTC) X-FDA: 77711152722.19.rail07_2010f4c27537 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id C82971ACC31 for ; Sat, 16 Jan 2021 09:44:21 +0000 (UTC) X-HE-Tag: rail07_2010f4c27537 X-Filterd-Recvd-Size: 2911 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Jan 2021 09:44:20 +0000 (UTC) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DHtQj07Znzhsl1; Sat, 16 Jan 2021 17:43:25 +0800 (CST) Received: from [10.174.176.197] (10.174.176.197) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Sat, 16 Jan 2021 17:44:10 +0800 Subject: Re: [PATCH] hugetlbfs: correct obsolete function name hugetlbfs_read_iter() To: Souptick Joarder CC: Mike Kravetz , Linux-MM , References: <20210116093245.47472-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <4548039d-2ba4-5df3-95ae-e945fdd3dc34@huawei.com> Date: Sat, 16 Jan 2021 17:44:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.197] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi: On 2021/1/16 17:36, Souptick Joarder wrote: > On Sat, Jan 16, 2021 at 3:03 PM Miaohe Lin wrote: >> >> The func do_generic_mapping_read() is killed by commit 36e789144267 ("kill >> do_generic_mapping_read"). So replace it with do_generic_mapping_read to >> keep comment uptodate. > > s/func/function > > replace it with generic_file_buffered_read() ? > Many thanks for your review. I'am going to resend this patch as I forgot to mention the second commit that rename do_generic_file_read to generic_file_buffered_read. But it looks I should send a v2 now to fix above comment. Thanks again. >> >> Signed-off-by: Miaohe Lin >> --- >> fs/hugetlbfs/inode.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index 23ad6ed8b75f..d02616513b43 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -310,7 +310,7 @@ hugetlbfs_read_actor(struct page *page, unsigned long offset, >> >> /* >> * Support for read() - Find the page attached to f_mapping and copy out the >> - * data. Its *very* similar to do_generic_mapping_read(), we can't use that >> + * data. Its *very* similar to generic_file_buffered_read(), we can't use that >> * since it has PAGE_SIZE assumptions. >> */ >> static ssize_t hugetlbfs_read_iter(struct kiocb *iocb, struct iov_iter *to) >> -- >> 2.19.1 >> >> > . >