From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4545CB9B.2040502@shadowen.org> Date: Mon, 30 Oct 2006 09:53:31 +0000 From: Andy Whitcroft MIME-Version: 1.0 Subject: Re: Slab panic on 2.6.19-rc3-git5 (-git4 was OK) References: <454442DC.9050703@google.com> <20061029000513.de5af713.akpm@osdl.org> <4544E92C.8000103@shadowen.org> <4545325D.8080905@mbligh.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Linus Torvalds Cc: "Martin J. Bligh" , Andrew Morton , "Martin J. Bligh" , Linux Kernel Mailing List , linux-mm List-ID: Linus Torvalds wrote: > > On Sun, 29 Oct 2006, Martin J. Bligh wrote: >> Seems like that doesn't fix it, I'm afraid. > > Does the one in the current -git tree? It's commit > 5211e6e6c671f0d4b1e1a1023384d20227d8ee65, as below.. > > Linus Submitted that commit, results in a couple of hours. -apw > > --- > commit 5211e6e6c671f0d4b1e1a1023384d20227d8ee65 > Author: Giridhar Pemmasani > Date: Sun Oct 29 04:46:55 2006 -0800 > > [PATCH] Fix GFP_HIGHMEM slab panic > > As reported by Martin J. Bligh , we let through some > non-slab bits to slab allocation through __get_vm_area_node when doing a > vmalloc. > > I haven't been able to reproduce this, although I understand why it > happens: vmalloc allocates memory with > > GFP_KERNEL | __GFP_HIGHMEM > > and commit 52fd24ca1db3a741f144bbc229beefe044202cac resulted in the same > flags are passed down to cache_alloc_refill, causing the BUG. The > following patch fixes it. > > Note that when calling kmalloc_node, I am masking off __GFP_HIGHMEM with > GFP_LEVEL_MASK, whereas __vmalloc_area_node does the same with > > ~(__GFP_HIGHMEM | __GFP_ZERO). > > IMHO, using GFP_LEVEL_MASK is preferable, but either should fix this > problem. > > Signed-off-by: Giridhar Pemmasani (pgiri@yahoo.com) > Cc: Martin J. Bligh > Cc: Andrew Morton > Signed-off-by: Linus Torvalds > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6d381df..46606c1 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -182,7 +182,7 @@ static struct vm_struct *__get_vm_area_n > addr = ALIGN(start, align); > size = PAGE_ALIGN(size); > > - area = kmalloc_node(sizeof(*area), gfp_mask, node); > + area = kmalloc_node(sizeof(*area), gfp_mask & GFP_LEVEL_MASK, node); > if (unlikely(!area)) > return NULL; > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org