From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293DDE64006 for ; Thu, 21 Nov 2024 19:23:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE8046B0098; Thu, 21 Nov 2024 14:23:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A97846B0099; Thu, 21 Nov 2024 14:23:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 937716B009A; Thu, 21 Nov 2024 14:23:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6F6416B0098 for ; Thu, 21 Nov 2024 14:23:04 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EE4EFA14E5 for ; Thu, 21 Nov 2024 19:23:03 +0000 (UTC) X-FDA: 82811072652.19.A9A0B34 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 3411240007 for ; Thu, 21 Nov 2024 19:22:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="LuRpEN/5"; spf=pass (imf17.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732216920; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jMXPl1e6luieU7Y9N+10kogflMGEnR+4YH0MSEtHxas=; b=1At7brUnjDQxpc/sX6RskBfQxYkmD+Hez/bMMxdE/b6V6s4RS+2Elq2JfnNEGNx8RhfQNU pJN4h8VvhrEzLYdFgogNQMlPoqoCbVRrivfhSNJPcxQnHwiujdbKuBbd3R4ltwFFOV2QPT v6A15hunoDvMcSqYLGjblQupHaj47JM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732216920; a=rsa-sha256; cv=none; b=xMMe94v2aUPlziDF8vIZzAMWv7u54AkiBIUNfwHK+t/cbkZ4+HUe+cD0jE3SCFR55HVclA yYAv6rIgG/DJxw2c+VfUN4AbrK7QYbBDSyComm1hB7plzLe189IGf9xw/oFmaAC5h916zS m873Y4EZAxFLCqIhOJj1Dhpvr0MJUSE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="LuRpEN/5"; spf=pass (imf17.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-72061bfec2dso1163725b3a.2 for ; Thu, 21 Nov 2024 11:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732216980; x=1732821780; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=jMXPl1e6luieU7Y9N+10kogflMGEnR+4YH0MSEtHxas=; b=LuRpEN/5y65Nf3sze2xeqK3cou6C98Ix1siX2W1hlu80EIriEzahtx09CpIV0HTopv 1oPOEzrbXxVgSn8p+Jzp+nxuX9M4kA16qFEANsb2GsLS3HKKpC+U00Ki10AqP1pX9/V/ z8TJ7IqjgrLhXyLjBjmU+aZPMtYOf+IaZh7EO6pkz5GHGQfuEwfJRSEDe3jy+uyAhsxQ UdrzGW1t0mR74J0copLqoVCQF1ns37Bf0lYPy+4BToKZnPsHFP3Y0RyOBqtXoYe1EcVe 1aocRIEy7w39pEjjJmXNdRmRCoLBtn6X0OfmSeKGZvsUngDBYAQAA7+zz+rSbQVcu4vh 4J1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732216980; x=1732821780; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jMXPl1e6luieU7Y9N+10kogflMGEnR+4YH0MSEtHxas=; b=vV5JPvLDo6X+CY7P0dsSXFiJcz9zN73wQ1eVJmXp+6BlwWeRfo+1Fh/enmKxT1vg1z bSDVB9qWp8R9xFTyt0FaLchYEnT+njfqL0JtMWDKNN4M1FOeZSQAeQI0oCdb8TGIxRsi lGFlPUej/ProPIPijAf0xhQ69sx3fJwgbu5OTfg2hua8RxMncqAAGpwHye4ntHhMCIXM iw45lY9lyc7nApQnDL/U7UH9r58OEeP0gPJ3BEmujx9t70SZvPjbJr8j6RsCR7kO1N2w zlLJYec+OqZHms+VcFiNKmNU0eLVARcVjtobtsLoEHesEjxa+WBz5O70sGIamZSEfVdH 8HPw== X-Forwarded-Encrypted: i=1; AJvYcCUa/ICOa50ZjOnub68Ocg7OR3CTjOvb1O/aSub/k0U4Gttr+/Tg3JxosYu8+LU1rbiQ6nrdlX9M2g==@kvack.org X-Gm-Message-State: AOJu0Yxd85sP+6hek4karbcatJH9NyGoE9x/0b9TbOwpQ0cK0cLxtNiZ IzMJHySG0pCPuCQga4R7CMxbZbAHJc/rxsZBHfFJPPPvmj/Tx4rM X-Gm-Gg: ASbGncutmnQU8hIrArJc+al9Vlji0p/FpH4OfeY/9cZOPk8hiZRMdatOHDC/fFoKycn wGaMR7MA/uw2gSuNJrCOKq8NYKzKnA0Anv7XzKI/rraSY8rMuXwXZsUnrBnB/Uoq64Sgj8m+Zd5 hXApdeUOqmvaDn6K9Au7R20mbs0rqBFXxbpdtHhWcytS+Wfv1/582njS1Ns/C+EV45ZwcPWJgOx o/kAPQbCnfRuaj6b2QjpqB2z5foWyu4M7ZwvZw8JGwzUN/GQF7juje2dJo6otc= X-Google-Smtp-Source: AGHT+IFeU+EeHn8aEsc8Xfk+MY5CRBA5V7KZ4Htnq0QrwacyN/wmUAYcZvwIq/4yFCBV76yCHJxspQ== X-Received: by 2002:a05:6a00:9287:b0:724:d503:87a1 with SMTP id d2e1a72fcca58-724df5fcd72mr213508b3a.7.1732216980456; Thu, 21 Nov 2024 11:23:00 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724df8b04f2sm29739b3a.66.2024.11.21.11.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2024 11:22:59 -0800 (PST) Date: Thu, 21 Nov 2024 11:22:58 -0800 From: Guenter Roeck To: Geert Uytterhoeven Cc: "Christoph Lameter (Ampere)" , Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jens Axboe , Pavel Begunkov , Mike Rapoport , Christian Brauner , Kees Cook , Jann Horn , linux-mm@kvack.org, io-uring@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache() Message-ID: <4535df8b-0ca2-4c3c-9523-d27d3de2b9c7@roeck-us.net> References: <80c767a5d5927c099aea5178fbf2c897b459fa90.1732106544.git.geert@linux-m68k.org> <4f70f8d3-4ba5-43dc-af1c-f8e207d27e9f@suse.cz> <2e704ffc-2e79-27f7-159e-8fe167d5a450@gentwo.org> <693a6243-b2bd-7f2b-2b69-c7e2308d0f58@gentwo.org> <508aa9c4-4176-4336-8948-a31f9791dd39@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <508aa9c4-4176-4336-8948-a31f9791dd39@roeck-us.net> X-Stat-Signature: g4qqox1pc1xwfhq7ggckccxw89npb4ga X-Rspam-User: X-Rspamd-Queue-Id: 3411240007 X-Rspamd-Server: rspam02 X-HE-Tag: 1732216941-523747 X-HE-Meta: U2FsdGVkX1+OeuAwDyCiOZO+4m5bRdkC+U3N8felidYbSDhfmhPQlI+dIgP+ce0R8VDPGlCe1B0ul9HgavywCtdLIPiaYT8bZ+1JqTqikLgev/9QeAyZtEQPwUbYA1G9caAVbAYjTou4B3Wc1SWh3XwuW6xuc+0vCfHsfVzeHMqJcgcFKUqHp5p/823SQ3rgxmezPGW+KlGvHybIXrXQq213JP25goiGZuR0hcoQyRuBOqVLw8e6WCGdPvkBzYSbsCHx7gXuDgZZg4MUl8ix0qomsrmHLe9sPwjUE2V94pfmX7FX6gKHpBXUr9ppmdHqc87QPOKpR3oPn3WT3d/KswyUPyqAFHkXz5wJSKw7iWVGhFSwnKQW3XvihIansXGx0IEDiTzkm3A/usFYSfYaoBtgfeDhC5pjD60BCQ08lc3xIXEp4vyvM8JWoZbOJuy45ggHwgCchVJrNa7S8M0L77jsXkO5QZZBNa6IIHXBK+EVtV2dzoXaznMxoFikAwTCBwIp7GEiCsRta1zmTqldNgaliCpDdHnpeUrEmOHYOpGgsQRi/2YWVXfrXZIAQ0uqf3ntovs6ROLn7IHZjtxZXl1ZRT0OhofvqVEzF3H3U8O4LVBp+H7MR7+Lqc+I62eSocvLrs+Izzsh34gHw58MthWsPC+SEQnqiN0YRE1gP/lUI9S/BFT2PyOITvkq7tkrZHOoepjrG02Vn6pczpglwCDcUu46g8oB+/zGVhV3HCk4QpkrEw5krGe2l92qPnc2qqPN4l2DXFJYdXF3nTEhpTzTVV66fFkG/p7C/58uaCoLXkUum2o0ZCuiWFdpH4omq0HgkcOuv2WbwGMGs5VeCRwamY7cpmPqK/VFrhiN+Olildwu65Cpo9FoTZEMEpjgqa/itqpxJdBcTunhu20udCUuJZ/TaRXFOxi0V11WlcCX/bjyhNbiKSYErwoV31izBPiCkJ2NppjkFJN8OU3 NL8xT3gE FEoMEXcJz1Z/pM2iXG29LzNL+xh34tjOKUQB3lBdWDM60Bsz+1nl1dKKwuukD4i7B6RP0NZWxRamV7hQFUEd5/EhBygaeQhv1vsAQPS0wYctVBmI3XEfGP18uccHmtMmixaBdETbG+p7kdY9TbE3sEI6UWBBAXMtjkjWaZeA5qeQbdgH34R6H9pDYFa6vkWD63/GvxWyRZIU/7z+zIdU1ZNbPTZeylK4H+FD8707tKFuZcEjt+EsPBqqKZtxf7q4GjDgvvA5CJAWbn9eTs7pxTRQcwFXo+coy1zw+F/6nJ146JDqHhNGxkbFcz5rsERxSlotzhWIHhzFrZtvCTmeq2A6N0MFd9IO2mMbbtLVplCfQIFm/WdlnkMN1Z5JRzVNWvzyBPGFdRq3xU+lcL+HQg+kqheCo25iekgoLPfCNo5/hPwjZhtPT+IRz47hpEmWIAJZVafj4E6kTvYkAE+Zg7rPQVJCyiEYzjelKX++PxBC567G0XmT2MopyJ6qoxB6WmWLVWAR2jspCvAe9ptMbi1hLF48g0LDJlu2h9lUgBkQjHNRulpcE6leubgfxuQlvMmW1WcE51NYVVy0d2DsgOhRwKnNgVNtJlsofrLppNla5gSDLvGqWKsqF2x5ksVcIKv5ikBiHGYl8rZMkAxJI61oKaC5grV/hmKJrEHIJja16nLg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 11:08:54AM -0800, Guenter Roeck wrote: > On Thu, Nov 21, 2024 at 07:50:33PM +0100, Geert Uytterhoeven wrote: > > On Thu, Nov 21, 2024 at 7:30 PM Guenter Roeck wrote: > > > On Thu, Nov 21, 2024 at 09:23:28AM -0800, Christoph Lameter (Ampere) wrote: > > > > On Thu, 21 Nov 2024, Geert Uytterhoeven wrote: > > > > > Linux has supported m68k since last century. > > > > > > > > Yeah I fondly remember the 80s where 68K systems were always out of reach > > > > for me to have. The dream system that I never could get my hands on. The > > > > creme de la creme du jour. I just had to be content with the 6800 and > > > > 6502 processors. Then IBM started the sick road down the 8088, 8086 > > > > that led from crap to more crap. Sigh. > > > > > > > > > Any new such assumptions are fixed quickly (at least in the kernel). > > > > > If you need a specific alignment, make sure to use __aligned and/or > > > > > appropriate padding in structures. > > > > > And yes, the compiler knows, and provides __alignof__. > > > > > > > > > > > How do you deal with torn reads/writes in such a scenario? Is this UP > > > > > > only? > > > > > > > > > > Linux does not support (rate) SMP m68k machines. > > > > s/rate/rare/ > > > > > > Ah. Ok that explains it. > > > > > > > > Do we really need to maintain support for a platform that has been > > > > obsolete for decade and does not even support SMP? > > > > > > Since this keeps coming up, I think there is a much more important > > > question to ask: > > > > > > Do we really need to continue supporting nommu machines ? Is anyone > > > but me even boot testing those ? > > > > Not all m68k platform are nommu. > > > Yes, I wasn't trying to point to m68k, but to nommu in general. > For some more context: I think it is highly unlikely that anyone is really using a recent version of Linux on a nommu machine. Maybe that was the case 10 or 20 years ago, but nowadays there are other operating systems which are much better suited than Linux for such systems. Yet, there is a _lot_ of nommu code in the kernel. In comparison, supporting m68k (mmu based) is a no brainer, plus there are actually people like Geert actively supporting it. If we are talking about dropping m68k support, we should really talk about dropping nommu support first to get some _real_ benefit. Guenter