From: Dave McCracken <dmccr@us.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: zilvinas@gemtek.lt, helgehaf@aitel.hist.no,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 2.5.62-mm3] objrmap fix for X
Date: Tue, 25 Feb 2003 17:02:54 -0600 [thread overview]
Message-ID: <453440000.1046214174@[10.1.1.5]> (raw)
In-Reply-To: <359700000.1046209586@[10.1.1.5]>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
--On Tuesday, February 25, 2003 15:46:26 -0600 Dave McCracken
<dmccr@us.ibm.com> wrote:
>> Keep the flag for now, find the escaped page under X, remove the flag
>> later?
>
> It occurred to me I'm already using (abusing?) the flag for nonlinear
> pages, so I have to keep it. I'll chase solutions for X.
Ok, the vm_ops->nopage function is set in drivers like drm and agp. I
don't think it's reasonable to require all of them to set PageAnon. So
here's a patch that tests the page on do_no_page and sets the flag
appropriately.
Dave McCracken
[-- Attachment #2: objfix-2.5.62-mm3-1.diff --]
[-- Type: text/plain, Size: 362 bytes --]
--- 2.5.62-mm3/mm/memory.c 2003-02-25 11:40:38.000000000 -0600
+++ 2.5.62-mm3-new/mm/memory.c 2003-02-25 15:54:51.000000000 -0600
@@ -1325,6 +1325,10 @@
if (!pte_chain)
goto oom;
+ /* See if nopage returned an anon page */
+ if (!new_page->mapping || PageSwapCache(new_page))
+ SetPageAnon(new_page);
+
/*
* Should we do an early C-O-W break?
*/
next prev parent reply other threads:[~2003-02-25 23:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 7:00 2.5.62-mm3 Andrew Morton
2003-02-24 12:26 ` 2.5.62-mm3 - no X for me Helge Hafting
2003-02-24 20:16 ` Andrew Morton
2003-02-25 9:45 ` Zilvinas Valinskas
2003-02-25 9:55 ` Andrew Morton
2003-02-25 17:57 ` Dave McCracken
2003-02-25 21:27 ` Andrew Morton
2003-02-25 21:46 ` Dave McCracken
2003-02-25 23:02 ` Dave McCracken [this message]
2003-02-26 6:14 ` [PATCH 2.5.62-mm3] objrmap fix for X Martin J. Bligh
2003-02-26 17:52 ` Martin J. Bligh
2003-02-26 18:03 ` Marc-Christian Petersen
2003-02-26 18:24 ` Martin J. Bligh
2003-03-01 9:31 ` Anton Blanchard
2003-02-25 18:49 ` 2.5.62-mm3 -Panics during dbt2 run Cliff White
2003-02-25 19:12 ` Andrew Morton
2003-02-25 22:37 ` 2.5.62-mm3 -DBT2 (was) " Cliff White
2003-02-24 18:04 ` 2.5.62-mm3 won't mount root Steven Cole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='453440000.1046214174@[10.1.1.5]' \
--to=dmccr@us.ibm.com \
--cc=akpm@digeo.com \
--cc=helgehaf@aitel.hist.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zilvinas@gemtek.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox