From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E1BC3ABC3 for ; Fri, 9 May 2025 12:49:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33BFE280023; Fri, 9 May 2025 08:49:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C3D8280018; Fri, 9 May 2025 08:49:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F184280023; Fri, 9 May 2025 08:49:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E143B280018 for ; Fri, 9 May 2025 08:49:05 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9643751986 for ; Fri, 9 May 2025 12:49:06 +0000 (UTC) X-FDA: 83423349492.24.66D01B8 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2048.outbound.protection.outlook.com [40.107.92.48]) by imf24.hostedemail.com (Postfix) with ESMTP id A676918000C for ; Fri, 9 May 2025 12:49:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="SC/W+XhV"; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.48 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1746794943; a=rsa-sha256; cv=pass; b=ARRJHLdSA0GOnZ1FREs5xHWAL/8gWwqRam9vfgWxsePgpefSbFqeyawNeBaxdWnwk9LjYN 8B7O/fif2Y5vxqmnOEwj89WSq3Ul1ORCUcYmENCaBd7UqnTvOpvCo928fwCnPUrAThJicK r7GK346HbNeC9ekt07zs4hed5XS0ycM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746794943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UAOOCDepC13IylbFUv09CMkr9pG8yYUy7apQDsHEh34=; b=m8fXf6O5UNdEIHuM/e5V/BxQGVlEk7Ok9Rn9eB2DCO1kOuUO/s4v874WsCA1NqfoDnQS62 AXODSwuu0CbY08TxgXpuHjUqBCfH+9vYxFcsU3aM/uzHLchZuZ/tRmL6icRLlZIcbRF5dd RQMbGMCm5rp4IyTAK1xc3Qs49aU9riI= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="SC/W+XhV"; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.48 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p2KJA6iBHpj9prpyJ+XbjPGclroF7noyKqDUxZQv4UK0E4bbJeQXavtmBwG+XjpYsbPnfUlYw9hWf00rmpoBp8F1Hg4YFbH1v4bEpOZBwXf4Bt6hqTrMtiwIwfbPDYv6t2+6dYmkbNE7wqYNkLGY39zoP/q0Ki1nmN387U6PCKjFJ2rJHVi456Xi6o9w5vymlfNGuUGXxFb8dz8XuXFEgH3w+rqoDvBKm3hbbOA5Om3oNOuy7hk5ZmPwxnldhyBHoIeHDfW5nlSAtSocJ8qWxIrrNZ74mrJUNg8VUWU9y9ajVyUb2EPgbKZJELkGWEjI8Nt8JjNsj0j+INlrQ1xdIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UAOOCDepC13IylbFUv09CMkr9pG8yYUy7apQDsHEh34=; b=cdacfTf3NaqRYkch52nYUZmJfsv/xfWZlko/2saIg1z3KM7tQLg1ig1yByufXX0pLCUDG0KXeO3HrOTiir8Biab2YM/5WSxgaqq34dkSAF/m5EqMwaeTJAiFXyhDmHQ1E/MaFmYUfDGmFlRMw9JYmZ2Nnld0iI/x1WcULwjD5kq2aQUDomRvgehQIz0AqA7FzI2qU2qCnA9ekhgY/VpRH/J3/i3rCNals2XoXj/sBXbHK0yqrzUZ2drCZ+yeSw+ctY7/QM00X0+Bn6Q8RZ1ePBRKQNsliQvUFHqx9H2QxJgFawGxhLWUg5REp0jbffqtS05rT/0czaB+ZRuZhRIulA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UAOOCDepC13IylbFUv09CMkr9pG8yYUy7apQDsHEh34=; b=SC/W+XhVhtX4EfRL/XWgpVXJJvrvfEt2ZIsgkdJmVfl3GmLOrR+POMNhWNOwyT9LYDfCm9qeJ+iwBLZ+Z9AS+jC2bN2TkN6PVZjRjuzjOFq8sHm8K42ZSWiVEudno+WW1C2i6yr8X4Mqvte1ABn0H4K3OVA9BkaDVPZqt962KeQE4LKxhStPNs4yngL3ydh5s+wh+PUA2i1YETRpES4fRObEjzcWQ/PRtlGolZpxtXnwoFFkQxIoIns7H+7ZuX43EKtep5Ab8N2lXj66kt2WqSTwturKhTqTppL3Sq9VuHdcbRIE+diR0XMvhpKfkNOTYpalEbFkiwTcILr2gsHecw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CH3PR12MB8880.namprd12.prod.outlook.com (2603:10b6:610:17b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.21; Fri, 9 May 2025 12:49:00 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 12:49:00 +0000 From: Zi Yan To: David Hildenbrand Cc: Johannes Weiner , Andrew Morton , linux-mm@kvack.org, Oscar Salvador , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] mm/page_isolation: make page isolation a standalone bit. Date: Fri, 09 May 2025 08:48:53 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: <452B09C8-3910-4DBF-8BED-108308C53B02@nvidia.com> In-Reply-To: References: <20250507211059.2211628-1-ziy@nvidia.com> <20250507211059.2211628-2-ziy@nvidia.com> <20250508052409.GB320498@cmpxchg.org> <13898284-B62B-412D-A592-856406F7D7C0@nvidia.com> <20250508204644.GB323143@cmpxchg.org> <10C2C1DD-A6E2-4745-8C2E-D09886F4104E@nvidia.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0490.namprd03.prod.outlook.com (2603:10b6:408:130::15) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CH3PR12MB8880:EE_ X-MS-Office365-Filtering-Correlation-Id: ca7e1f8d-da52-444d-41ff-08dd8ef7de83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?l+eQfbxk7kD6LOhXtJ7fTpeeerITcrLFupjl5zx4fIeGw5ZxiEXIcAsTNyfC?= =?us-ascii?Q?Qpx4FyeKrHe4eV85L428udVJ0DOO6VW386lm2fT0ly3zvtfgl2qySctwcpD0?= =?us-ascii?Q?5oNcrBRtncNBCtJ0oBHJXzKEsfi/w2ygjclvZbJvxhKLcd8uhYwWR4XJEOg0?= =?us-ascii?Q?0nN5RWAZmqih6WTT7Ne38VKXgvJN5KZXJ8uBidDV55PKPD/+scHPz5sBKq7L?= =?us-ascii?Q?cT63Gc8sUbQ2eLBayRv4f4KfYltRfnY9xaQ4e9/U11tVb+AwZKxCaDEzmTrd?= =?us-ascii?Q?2zNTQ6Ms45gaehdspYaCzgRYoZ0HvCdnnzI1xo0oX7uY8rSgUigCO0dCYa0r?= =?us-ascii?Q?HWauPS0MVPYX4dMLNfm36Dzk50UGBOqlCt1h2NqzZf+VYoplAb4eBp0Bc4zB?= =?us-ascii?Q?QcmP0L08ikodu+HZB4kFwuyqKEMikXFRmP2Yt1feuSRBPttlkqz3kf1PYN0K?= =?us-ascii?Q?LapnfzDhl/04LFdGx9H5Na+L+xy0Q+fY2bWodsWDJUBjxjnfbspRZc8MzT3x?= =?us-ascii?Q?11XpGj8jxP1pivBUJDDHhVegkLTj+qa1o8zuDGQBrXJG4ZuInowC+dL7AiPF?= =?us-ascii?Q?HlScq40Tkxy43t6vOBljOZNVVWdIC2BEPsRaLyZFe03t/Njr5Fzbejm9WCa7?= =?us-ascii?Q?OUwuzXH44w687DhoIEqxkytOhfGQEmEgD9UEGk5A27OMjFDWnBoW/BO0ok4S?= =?us-ascii?Q?yvRjI7Qs8v17UtAVMBjQ0IfV/BRSzcaK/D2vVP7p556lgRSL6k0N8lQvHAlb?= =?us-ascii?Q?zH4aN6I8w6fj3VexDPHoSHPy7OiEJfuVu2WKLmFwjuo6vueCcgReLdqpF1Rk?= =?us-ascii?Q?omVbbZwDb5StBTjlsbE4thfTYgV0jcvPXh/Dm1LNDDeuM1v+Mi84ir+zZMVj?= =?us-ascii?Q?rhxu8UN8NPS9CKL0QyM/H8cpMTQu2yU2lkB3jRHIYvZzSZqc+WDTkZ3CHykd?= =?us-ascii?Q?iEGVOWVngNn5M2keMM/utVqO7pF700E+/drhevkoB2/+zGPwZ9KPPqhhVj3G?= =?us-ascii?Q?N4FgkTZPGjJfmCnyecGPa0oOo95YMHnRxcpgiTix+k4DcYXAB5fBQzxuUJZJ?= =?us-ascii?Q?JM/TMulho1pNk6i3vuKOkax009bp6/xW8UFdrBzTqgwD0iMt0G4h/C0MalxA?= =?us-ascii?Q?0Sso7BwL0RA6dwLM2m/6gqq+dXRdZqIZ+nOfE8Bt/ZUW5h3XXLuQWkafCzoL?= =?us-ascii?Q?X8UFG7LMPKP89E55Yy3SXJg571PEYLup87Ocqursr4i+aqIa2pmfWnEpF5hH?= =?us-ascii?Q?LR3Y67Q51+wApbRupOPXtd0ud4Y+NZ/q0xw9u5nJHQ85O8QL1naLvVZFNiyx?= =?us-ascii?Q?Vp7vCB85yDT5g8zIZ2MaSTmuvGqucmVyq5osBzkRlHk1Scbn4EXrZdS5b20T?= =?us-ascii?Q?6HdQXfz3fSrfgSUfllhmGsYP2sSQebgGdbpCq2st5fHBcyuudOK2cKZnTSYH?= =?us-ascii?Q?+KIeF59z8rc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0kGEmttb0f96WBDod714/vEL55qYfV2u0Bfr+NtUxXYzEHuQjYYlOeQQl5jG?= =?us-ascii?Q?etcQEcNwjFUckPFi98hwTsHaMGpSdDkRBYn01h29TF2cfYQ9AffoxJYwV2eJ?= =?us-ascii?Q?qpWKFnduKKqi+fmRQia7tJz/0BMTQfgFnIOYib+0pYicb5DhXeXdmKsmds3W?= =?us-ascii?Q?Tx615ydpFD0M5v0njXCTAVoDZK35mXgCN8+zJN/CwpmjK36LTfclivBU3jQj?= =?us-ascii?Q?844SeolTceziVRXLeEolhRhL3Mt+xZH5xNgFqkPkEUnrHAqqs3V21PsjttDa?= =?us-ascii?Q?9Ccuv5wRL5JMvIRekiy3S4MyXVT9jVeU5rFONlglRka3yNEA6G2TNrWUeFMU?= =?us-ascii?Q?CgCOWZWmuT4vn4lvlg4IpcmbnlYgUtptapC9mQkR32/14G/N1QYb+RGvRZoL?= =?us-ascii?Q?XVbw/OM3cRNfnEtbheY9TxVL/62IJ/apLOHUwD5n8Rvpr8L3LzQtct5YYrWz?= =?us-ascii?Q?wmJMMFA2oOCJTrrWCuFnrKWRizar/PsCfviAqb0GcDM1vn7mC2GVjbCLI3cb?= =?us-ascii?Q?UaSo8D+CmyWpwLrQk0VKzZQ/ueezjhVtxr/cd6TeJdxC2FKSJYukfIZ02TMR?= =?us-ascii?Q?r2xTtvaiaMTayBvsW+sM2MCbzM8O2jW9AExTd2xMKL+VFWoG+/pc1DTyuTXJ?= =?us-ascii?Q?aN3EPAMb4s3s69ysFAD3hoeHk4gf0ZyCdaVZID5tl0mW73BN37Lca/E0qj7c?= =?us-ascii?Q?bvJCFsogIne1bUMlDtERt5o6QYF1nDqS3MizQPD7+aE+rC6wfBjyc0iFLN9/?= =?us-ascii?Q?V5QNSi+nroTJcL9X+NIaM7lOW/kvk5se+GnJKz35Q8pQX8thfpVX7su8ZXFB?= =?us-ascii?Q?YMAL4egsTNiVopwkBzOuCFWIVG/8QU5I+iWwShgbrUJyNF2jxpZ56j5z8V87?= =?us-ascii?Q?Q6Sa5olVhFYVKJqHhVgBYfUQwZeqpplmQxuNFVB9lIAKquXY0bZ+Nn3x0+q3?= =?us-ascii?Q?5UdExd6k5TM6qAcC4aMdug9m74ZL/NTQwZR+LcCVjlfWRbzNO0TfkbPDIbsq?= =?us-ascii?Q?nzsyQNzGlDylZNIoG1w03C2M5ohBDrZ37XNy/8B6BIS4oREAwHcTkGhoNNUk?= =?us-ascii?Q?WDS7yrSRt0E8PWTId2unvOn+4tt01p40UzarSbEgvWiwbRRdISVOGU9gopQC?= =?us-ascii?Q?JcQBnG3yiUoCahXWxsPTRB0MJ1wDelHLlVKoVVzbOC0U2rfboClvyC2XTNSb?= =?us-ascii?Q?j9Ot3aq1vpUT9MHhXjBdU90G39N4ePza3m4PvQumSpR+2D7JeHsPmhGNxzF/?= =?us-ascii?Q?wz9z99ZVHD/W73B+N7wsdlfekcZXoVPZmbZqXw5AikAWRanng77ano4NIbbq?= =?us-ascii?Q?ycMi5W9ScUYpf9Wbdvm/kn/m+Krzn9zFcfK5yyeo4y4l+lWWqbNBBJHdk5Xw?= =?us-ascii?Q?NvhVFXbX09nM4PAww31qN4eyE/S6C+a2hj3YXGCdrnrtCmdhIeGsjIEpRB+u?= =?us-ascii?Q?L5P+FFbirE99p+YHVk3Z0Cg5PLVmXqrKvawBRzNCVheFHRFlNex5hPloid0b?= =?us-ascii?Q?jBZLAdSpOnmPhhj7JLhyn73gn2dE5jMi1OuglAjIxzpAT2i8W7gchx9IfLkg?= =?us-ascii?Q?pmcplzbMZ5YxgulVONHR7sTqHpxt7yUEBASKj0Hc?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca7e1f8d-da52-444d-41ff-08dd8ef7de83 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 12:48:59.9235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4jp7RISVGmPRXdZGfh3W01V56Zt4aJWNIVu+vaT8kLYlLmrfDGQZuIVY3/PfhAsZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8880 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A676918000C X-Stat-Signature: gn8axwzshpu8rh3xzjn7p4yixfgfzrow X-Rspam-User: X-HE-Tag: 1746794943-71581 X-HE-Meta: U2FsdGVkX18sPUFGqIjx/Uqtx+utKCPfxrGNAhCHBXNZEwxRLuRHOOD+Q3vyUxQV8IQgUAbH9PeO3uDmQ2ENFa1joc8zwy28sSVjA1LLoJ0rwq7dWpbLU7Aavqs+ZfsnNJvuZ23qiNPgM57Yld0zEw1wnrqSEzP416/CGMo/oGR0Zs7Itvy/qsO/Uh3+DgMPbE0QJ7SHKDyfz+iz3umQGiRw1d1yBFaVeucaxLbVK7h8bPZiW7Be77pFNgnoKH4UhNjf7skEcwYeis06EWtaDN29tLOxzBp/bqBwlIk/EKo8iAOu9LcwlJLbM8Jz4hQxDpodBoOtqcWOj54RdEMahk0L6oRLsAwW+miTYLOBs8CiTEmGnsb4S7fvxJFmP2B7EFcc16t5f+TgmnGX078YrwzIxwLJv/x94FGg2meZZs5vUWdtw+bZR9X5A8JAAX17CRqlMQ0H51H7M8WRAOf67W9uo2MbjNa44yEeEX6kVUdx5YCeA/Y7rTGIuIYZWfxh59lRzrrT09MGOWvCY/V+oRl/skwRD7/haEqX9tlf3fTrj3CCIK4YwOlqf1F3jbcn+b2U5+h64i4EYgY1koDqxpbNgloGI3piLDJPDAl1lFYlJI5xnSQIzAaIM0gGYgEta/tSTr52Vq4qvcOtmEyoElIzMqn1SqmSgdqqktNB4R9zP1n3fYz3fjBKOSHVo/uiXQFWCCqkxYKBD7DHG2t1D/KS9y0yquSSD9B8qmR17RrDv5OOtL6yyUV+cdCuVqGGboFunyY13xk5ApprqQ+slixyyhQANRjk37fhEyALyLj32kfVg8Yfs6M9FayYsLip0AQfEGx6uMBcxUBBwcDPxJl3rbUB24tTpjciZU17T4oUkmG7b7wNdAmfTd2vUDeNqFdwN/mW+4xMkmp42Yl28DuR7ezkaHHoWp+67d+66fwEHZuNcsNpvLLxJzcIFbDBNHuu/LAsT5u3DggkrWw hGhGELoy jGU84ah7aazHowyX4EuQ1lZLXx135mIuzHQa47vnNjwuK/OTdpfsMgfz4Y4sxAzHtTfYxcO+VR8M3K1SlU9kr/1cJcnnWwF9WZVJiseBaVkVbpqGLP8c7WySRtClukgiSrDpgstLmCA2X38yfmoyIfGbuX40GWPk+Gs9pHRbtjiCFbgnG4nRMyiEIPJe1RlStlAM1ikgbALe8jUdeIKNurxwGVWY+Br9K/Rm2waS52ISF4J2xSMRGxCkQHfQ7D3m9Tduiq298TPfhHnF/wVG96i6hEvg0Icgu4T0O6S3R0T0FwRYpWEBsX/cV4tuyp3YeVUe+UQOwxdtJ5yp5xBx7iNww1xqUMDlh0KED3VIwBT0YkMTEMlO8Bk04jREhWdBOEtfe/p+HIp68XEnCPPv7TB8orqAUCC2NHGte X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8 May 2025, at 21:33, Zi Yan wrote: > On 8 May 2025, at 16:53, Zi Yan wrote: > >> On 8 May 2025, at 16:46, Johannes Weiner wrote: >> >>> On Thu, May 08, 2025 at 03:17:05PM -0400, Zi Yan wrote: >>>> >>>>>>> @@ -426,7 +460,12 @@ void set_pageblock_migratetype(struct page *= page, int migratetype) >>>>>>> migratetype < MIGRATE_PCPTYPES)) >>>>>>> migratetype =3D MIGRATE_UNMOVABLE; >>>>>>> >>>>>>> - set_pfnblock_flags_mask(page, (unsigned long)migratetype, >>>>>>> +#ifdef CONFIG_MEMORY_ISOLATION >>>>>>> + if (migratetype =3D=3D MIGRATE_ISOLATE) >>>>>>> + set_pageblock_isolate(page); >>>>>> >>>>>> Are there paths actually doing this after the second patch? >>>>>> >>>>>> There are many instances that want to *read* the migratetype or >>>>>> MIGRATE_ISOLATE, but only isolation code should be manipulating th= at >>>>>> bit through the dedicated set/toggle_pageblock_isolate API. >>>>>> >>>>>> If there isn't one, it might be good to enforce this with a VM_WAR= N >>>>>> instead. >>>>> >>>>> I checked all set_pageblock_migratetype() callers and do not see >>>>> one using it for pageblock isolation. Let me replace the code >>>>> with a VM_WARN and add a comment to tell users to use dedicated >>>>> pageblock isolation APIs. >>>>> >>>> >>>> Actually, move_freepages_block_isolate() calls __move_freepages_bloc= k() >>>> to move free pages to MIGRATE_ISOLATE pageblock and >>>> set_pageblock_migratetype() is used inside __move_freepages_block().= >>>> So the branch has to stay. Will use the suggestion below. >>> >>> Ah, good catch. But looking at the callers, it's: >>> >>> move_freepages_block() >>> move_freepages_block_isolate() >>> try_to_claim_block() >>> >>> The last one would benefit from having the set_pageblock_migratetype(= ) >>> there explicitly, as this is what this function is supposed to do. It= >>> also should never set the isolation bit. >>> >>> move_freepages_block_isolate() has two set_pageblock_migratetype() >>> calls already. And after the series, it should only manipulate the >>> isolate bit, not change the actual migratetype anymore, right? >>> >>> Maybe it makes the most sense to move it into the three callers? >>> >>> And then fortify set_pageblock_migratetype() after all. >> >> Sounds good to me. Let me update my fixups. > > Hmm, hit another roadblock. In online_pages() from mm/memory_hotplug.c,= > move_pfn_range_to_zone(MIGRATE_ISOLATE) calls memmap_init_range(), > which uses set_pageblock_migratetype(MIGRATE_ISOLATE). > > I could use set_pageblock_isolate() in memmap_init_range(), but > that requires move set_pageblock_isolate() out of mm/page_isolation.c. > The change might be too substantial for a fixup. > > I also would like to get some opinion from David on this. So I am > holding this fixup and will send it out as a separate patch when > I get more information. Hi David, I have some concern regarding online_pages() calling move_pfn_range_to_zone(MIGRATE_ISOLATE) code path after my patchset. During the process, all pageblocks are initialized to MIGRATE_ISOLATE, then undo_isolate_page_range() is called to unisolate all pageblocks. That means these pageblocks do not have proper migratetype, since they are not set to any type other than MIGRATE_ISOLATE. Maybe the code should be changed to move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_MOVABLE); start_isolate_page_range(pfn, pfn + nr_pages, ISOLATE_MODE_NONE, 0); =2E.. undo_isolate_page_range(pfn, pfn + nr_pages); so that these pageblocks have MIGRATE_MOVABLE type. -- Best Regards, Yan, Zi