From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <452AEC8B.2070008@yahoo.com.au> Date: Tue, 10 Oct 2006 10:42:51 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [patch 4/5] mm: add vm_insert_pfn helpler References: <20061009140354.13840.71273.sendpatchset@linux.site> <20061009140447.13840.20975.sendpatchset@linux.site> <1160427785.7752.19.camel@localhost.localdomain> In-Reply-To: <1160427785.7752.19.camel@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Benjamin Herrenschmidt Cc: Nick Piggin , Hugh Dickins , Linux Memory Management , Andrew Morton , Jes Sorensen , Linux Kernel , Ingo Molnar List-ID: Benjamin Herrenschmidt wrote: >>+ vma->vm_flags |= VM_PFNMAP; > > > I wouldn't do that here. I would keep that to the caller (and set it > before setting the PTE along with a wmb maybe to make sure it's visible > before the PTE no ?) Oops, good catch. You're right. We probably don't need a barrier because we take the ptl lock around setting the pte, and the only other readers who care should be ones that also take the same ptl lock. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org