From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 915B36B0313 for ; Tue, 4 Jul 2017 05:39:59 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id v60so45013269wrc.7 for ; Tue, 04 Jul 2017 02:39:59 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id z50si13966344wrz.25.2017.07.04.02.39.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 04 Jul 2017 02:39:58 -0700 (PDT) Subject: Re: "mm: use early_pfn_to_nid in page_ext_init" broken on some configurations? References: <20170630141847.GN22917@dhcp22.suse.cz> <54336b9a-6dc7-890f-1900-c4188fb6cf1a@suse.cz> <20170704052304.GC28589@js1304-desktop> From: Vlastimil Babka Message-ID: <45268b53-88dc-4129-725c-df5849e494db@suse.cz> Date: Tue, 4 Jul 2017 11:39:57 +0200 MIME-Version: 1.0 In-Reply-To: <20170704052304.GC28589@js1304-desktop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Michal Hocko , Yang Shi , Mel Gorman , Andrew Morton , linux-mm@kvack.org, LKML On 07/04/2017 07:23 AM, Joonsoo Kim wrote: > On Mon, Jul 03, 2017 at 04:18:01PM +0200, Vlastimil Babka wrote: >> allocated" looks much more sane there. But there's a warning nevertheless. > > Warning would comes from the fact that drain_all_pages() is called > before mm_percpu_wq is initialised. We could remove WARN_ON_ONCE() and add > drain_local_page(zone) to fix the problem. Wouldn't that still leave some period during boot where kernel already runs on multiple CPU's, but mm_percpu_wq is not yet initialized and somebody tries to use it? We want to catch such cases, right? > Thanks. > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org