From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50015C02198 for ; Mon, 10 Feb 2025 08:42:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAF6A6B007B; Mon, 10 Feb 2025 03:42:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5EE46B0083; Mon, 10 Feb 2025 03:42:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4D4C6B0085; Mon, 10 Feb 2025 03:42:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A6CE76B007B for ; Mon, 10 Feb 2025 03:42:22 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4FE5E120777 for ; Mon, 10 Feb 2025 08:42:22 +0000 (UTC) X-FDA: 83103393324.30.FB99DA2 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf30.hostedemail.com (Postfix) with ESMTP id 1BC3C80007 for ; Mon, 10 Feb 2025 08:42:18 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Ab38Dcwh; spf=pass (imf30.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739176940; a=rsa-sha256; cv=none; b=aHj4bstFzO9xcmCFvftLQL8qPoe6KSXADkX0G3B/DCDyjqmAIrH0IipQVjRcEgjOS/VNp8 wzmo+3q6s2VqjPoZ27Dj4lSz1h9Dn3ovr4wvmrVi8ZjH6xrZNEN/NYaoyY06IMP2ceYSun r7PZFlvoQ8lM0huzR4AmTwIAHkuX52U= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Ab38Dcwh; spf=pass (imf30.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739176940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5AVryFW7jIKC9PMx3aJa7fd2zlXZtgnjt/bCXgEFJA=; b=EOkpFwFuRg50A4hoGdLWlFGQVRKpsTM7QaJjurwF3EbUBr5tTwXvlq8RpUsEuKXs4XBk8L Tv7MKDnmRhhtK0iBuVUtvC91WggommAwaOP+ecG+9CjucYqczj4bxSnoHA/LIUHu4Z3A// Zxdf1tAQ0OzPoqYKCCP+YArDcrbNRKA= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21f818a980cso14857235ad.3 for ; Mon, 10 Feb 2025 00:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1739176938; x=1739781738; darn=kvack.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k5AVryFW7jIKC9PMx3aJa7fd2zlXZtgnjt/bCXgEFJA=; b=Ab38DcwhT71RDQD3jGOdReBVFcmwmz5usN9TZA+JoA7I5h1YsPzrSvc5js015cVuUj pqIcWbaCXgO7K0WZDE5ymWoHalmpimYlZ+yt/GjNuLxMCWHiDiApWc4AaI3EYa0/ZaL9 dpGGIgeN0GJNAwGWr+/sDi5nplBcVKQUPxgcb3Bwz0+ms4SDoWLr53/MG5RcIAVz8ufO K9KBHN5ytrttiWjPMNPm2Jd1vx5KKaRHPSjb+jnQdNONhDkY3C0XvwddjT/hFSrxnlxr gCx5DNjJi6tngFwmof+lT3J5dleGm/yRlhIba3O4wChXxaDrdRqnwpKWoyxbKrAw743r A/Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739176938; x=1739781738; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k5AVryFW7jIKC9PMx3aJa7fd2zlXZtgnjt/bCXgEFJA=; b=YYgSI7OSVY1FNEIUh1XAmckRVHdDqGlB9JRzVRmmKdopEDVEYYhD6wxPIiAZaYNJIu tkRFTQJx4eYzVCHcfzoJG5OpQ7vJGAAYE9c+Otqc+ilePOeObkGvQPGhly6vPKz+4NQa o6RQBzcOZwbO1/+VyGm95GIcUf5iOb4RmplrTsX+t3/IfGDzbDZQy5CX+rDJk/BpT0mf NsHbSqOO+UuEhFimrLKf6B5brpguQv+yM/Y0BXSi4bwXz5KWEp5rlkPQzgTiG8DBrw1b Hh40m4XmUBRj6sgZgSgZVhDwiA0nxwnCQ1I3Ahk+JWyJ7jr7VzHSHJHFge98HeNsI65z jpjw== X-Forwarded-Encrypted: i=1; AJvYcCXaMMSn11MbGrTrBvENdNUVpz416zwWR1P2zMSMbup0+gUNWxuN7TfqNajte4FbGch19rO7XZvXcw==@kvack.org X-Gm-Message-State: AOJu0Yx3A0Aw/tlQMPaTv/kznCe7Af+dkInRZgcyLJJpudFz8KXRFIol Y89AHhYp+2l+FvONtLoGxYMgXaQGnXQ1UuVu0eV65GhqRqRH122L0UmCbhKkrBw= X-Gm-Gg: ASbGncsq/Z9AvmoAgyRuT/Ij0MDKAa/ySDhcaEmp7LkkOYCSVCooiJI/kFa9fvcYoEm A4sFYrjNEfyfDyTK9M55Lvl2kQ2tk8LiI0TAu1RruraMM/vZO80kF/egfDHcd+65A4EoPzbzeOe APWmtDKjPvCwFPqA1njskzof++FB0FGQl+ZCZI39KDbifUTBLFjLDe2TIViQtSz43L1gMCGyP89 uny0xgsTbEMG8lGap1N7Jg2HvSKW3x79oGIobRLtjmKfmE27L1A/zjuVmC+LTZxiJN1nrzbdxLs jkUsADJyvtRe5uIZ4bWzB99lSDLhBHnneOiyN6edbA== X-Google-Smtp-Source: AGHT+IFrJ9iyF+ehnd+p5RcTFw9uzH3Jjv3cVTTZFS7lEPb+BTW4LASNKEREzJVE7UzugL6gSYLHqQ== X-Received: by 2002:a17:903:2311:b0:215:acb3:3786 with SMTP id d9443c01a7336-21f4e6e649dmr224221095ad.19.1739176937709; Mon, 10 Feb 2025 00:42:17 -0800 (PST) Received: from [10.84.150.121] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f368b6024sm73039775ad.231.2025.02.10.00.42.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 00:42:17 -0800 (PST) Message-ID: <4524511c-d685-4af6-9de9-4f15f7dcfe05@bytedance.com> Date: Mon, 10 Feb 2025 16:42:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: pgtable: Ensure pml spinlock gets unlock Content-Language: en-US From: Qi Zheng To: I Hsin Cheng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250208184928.219960-1-richard120310@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1BC3C80007 X-Stat-Signature: 5sidokjz4a4ugmh598znac4iyrns1618 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739176938-284366 X-HE-Meta: U2FsdGVkX18ks6bXc2KmlDb7Y8s4oTJtHXbCVPOQGnIKtEKeYXiSoMGSGZXfd+1KrdBa7pGX8PdApQ1u0G4UIL6B5vrK5jQC32ya/Buz7bkOvkeSrkisdhlOHRsIagDBS1cugaiVOALZ36gtbgdCEQD5dQ6u1qGZS65HUg09Cjc/lHLAAr9I5Wu6DcrRwQjhRWkYo7h+gE134FMqknzcoxhICHRBwKqxJED1Zz3pwNqw+5Cs+czrpnfzKGozoFu1DUL2LBwZRCFL2ePFlys4M2c8ZOHdnNhTDXK6alWoy7BP1pl414h0WjN0rTKG+NccYTyWFae3159HvSSQCQ6vxqUoQltxeJyAq894kJHURxhO+aglg0cybv6Ix7o/UBOj+cyBCsqRucG4pFAVxIiyBgqW5ee4lNi9/Ty8LWXTsUoDnOKJUNo9bArdfmGBziGNv2mBQ9SBu8IdX39AbcEEw9N5sI/pQojBN2wmXMH6SoonTDN86iz0Thq/q6N+qiCkvcu52R9lYYNcforRRD7VHcnFRMV/Jh4uwP2cRexu88Q7P0KfPJxdTgRfH3ALkEXL0kVBL2i+c8Oo5Ts5Ku4u58KA1C60zj/Ua9Q+RVvotSjQrQF1e2jC1ceaRts9ZrUI8iBJhqCaIPN3y8pgGZ6Jib3R2QpPE07Xti3p1tUMpzbQQtN8pBrp9rPkqC4UWYxARe+iUzOqZCb1L2wTQ+Zus6i6/90I+7Tb5So4mw8YZrJ43xhz+TMuHlfBF5NXn+pE8RCR4rtuJmz3DJUK/tWPjVBRktzBmAEFAa6G0v/kHVgNXXLMziQ6L8edNn3Nng1ljMcFdQyseIszq/+JOsR2GCg3+fmuRrGIAJVqQIhAlwWMGHVio5qIcEvMDOavfplj7kvqu8X/wn/IgbX+XYlHi2dxSgX5nDD6sdiMz3VkigIaVwfZTtAuyMgWhrEg95BWSm/A7spwgnAZjfOUhi9 NVJ5LgMt WiqzdtnG8byuSB6hIa8b7auuNUqt6KqHgmuDaizh8ZoezHxBAC/TJLfizbO7s6nvFG733bdZmrvAGNBOnTLuz/IbbkkRiQ7jyJegqzx8qk1Qui+qUS8zeyFuKH5V5YkpXR+XKnaPrSHfkYwEIClHHnIBSBlcy/+Kt7iwVkFjDbXeTQBKlv61i9B5KGjBwYdY7tFlSRn8VLV/r1NrKLAwXNLyjUSdaYNR+RH4tTdp1icEZI5ompO1ynhjTzXX06KSnHr2dIC5tWE3a/mzXf8VfCD4gMUb7f+aWlDGSFd+DqXW6fVA7cUCVvjTGHxqpOmwwq8WZaLD1WzbNEd99HllJr+dEFbIAAU5kJEIRkGvH7nuPgYQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.170372, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/10 16:31, Qi Zheng wrote: > [...] >>>> >>>> diff --git a/mm/pt_reclaim.c b/mm/pt_reclaim.c >>>> index 7e9455a18aae..163e38f1728d 100644 >>>> --- a/mm/pt_reclaim.c >>>> +++ b/mm/pt_reclaim.c >>>> @@ -43,7 +43,7 @@ void try_to_free_pte(struct mm_struct *mm, pmd_t >>>> *pmd, unsigned long addr, >>>>        pml = pmd_lock(mm, pmd); >>>>        start_pte = pte_offset_map_rw_nolock(mm, pmd, addr, &pmdval, >>>> &ptl); >>>>        if (!start_pte) Maybe we can return directly here: if (!start_pte) { spin_unlock(pml); return; } >>>> -        goto out_ptl; >>>> +        goto out_pte; >>>>        if (ptl != pml) >>>>            spin_lock_nested(ptl, SINGLE_DEPTH_NESTING); >>>> @@ -68,4 +68,8 @@ void try_to_free_pte(struct mm_struct *mm, pmd_t >>>> *pmd, unsigned long addr, >>>>            pte_unmap_unlock(start_pte, ptl); >>>>        if (ptl != pml) >>>>            spin_unlock(pml); >>>> +    return; >>>> + >>>> +out_pte: >>>> +    spin_unlock(pml); >>>>    } >>