From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45241135.6070608@RedHat.com> Date: Wed, 04 Oct 2006 15:53:25 -0400 From: Steve Dickson MIME-Version: 1.0 Subject: Re: Checking page_count(page) in invalidate_complete_page References: <4518333E.2060101@oracle.com> <20060928094023.e888d533.akpm@osdl.org> <451BFB84.5070903@oracle.com> <20060928100306.0b58f3c7.akpm@osdl.org> <451C01C8.7020104@oracle.com> <451C6AAC.1080203@yahoo.com.au> <451D8371.2070101@oracle.com> <1159562724.13651.39.camel@lappy> <451D89E7.7020307@oracle.com> <1159564637.13651.44.camel@lappy> <20060929144421.48f9f1bd.akpm@osdl.org> <451D94A7.9060905@oracle.com> <20060929152951.0b763f6a.akpm@osdl.org> <451F425F.8030609@oracle.com> <4520FFB6.3040801@RedHat.com> <1159795522.6143.7.camel@lade.trondhjem.org> <20061002095727.05cd052f.akpm@osdl.org> <4521460B.8000504@RedHat.com> <20061002112005.d02f84f7.akpm@osdl.o! rg> <45216233.5010602@RedHat.com> <4521C79A.6090102@oracle.com> <1159849117.5420.17.camel@lade.trondhjem.org> <4522B112.3030207@oracle.com> <1159902601.23752.11.camel@lade.trondhjem.org> <20061003143701.93a66b84.akpm@osdl.or! g> <45240B94.4070808@oracle.com> <20061004124356.97743697.akpm@osdl.org> In-Reply-To: <20061004124356.97743697.akpm@osdl.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: chuck.lever@oracle.com, Trond Myklebust , linux-mm@kvack.org List-ID: Andrew Morton wrote: >> A "WARN_ON(ret != 0);" placed at the end of >> invalidate_inode_pages2_range() should be sufficient and harmless. > > true. I think. I'll take a look at adding a WARN_ON_ONCE(). Something like that would be very good... imho... steved. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org