From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A04C3DA64 for ; Fri, 2 Aug 2024 02:40:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5956B007B; Thu, 1 Aug 2024 22:40:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA69A6B0083; Thu, 1 Aug 2024 22:40:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C94716B0085; Thu, 1 Aug 2024 22:40:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ABD6F6B007B for ; Thu, 1 Aug 2024 22:40:24 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2EE1BA0469 for ; Fri, 2 Aug 2024 02:40:24 +0000 (UTC) X-FDA: 82405751568.20.F64E884 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 53F58C0006 for ; Fri, 2 Aug 2024 02:40:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=HfNBf1xX; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722566393; a=rsa-sha256; cv=none; b=UJRu49GsuKeZxRNVh1ALMSG9+ajJJp1xNguASMTzw4FNyxzgh2LZDWw/oCqF0TuUU4R5E2 PoRnObdXLrLeDV9Ty9mdMr6OtbtcWUKhGLCRiKksY3zP3iytJ29NDaNYou5IQRwIrybF4/ roNmK4KuW9brBp3HW9pI6JnhcO6KRdg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=HfNBf1xX; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722566393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hd6CJCyd3urOh/DI2TNd78sNjcq0liHfgxY9AYZFncg=; b=eCZqzPPgGaiF0HVD9L+HOaXahVjSS0UxQ7GcKdCSIxMDd2rHcklGbfoZkH3h2YKgHgFdmL uxhSrFnVODGS31p1yJMgihOuyHPWccjpLS2NQBrmqaD6hhq/IorENgDQEqZJGWVrDGVwS4 Fr2GI9RF6HJ2DVrKYFOx5W6PLtHNf8A= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1722566417; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Hd6CJCyd3urOh/DI2TNd78sNjcq0liHfgxY9AYZFncg=; b=HfNBf1xXcRviyqRFlGpTGKFNmK+nZEjUe1adyzGnWWXSbaEmdEpDT/q5dtP61L7OpXNcqzLie/CH9iyckvxe5mF+4+RwS/LFKQXObwwWWJDPG8NMf32BUuSUJKKHZP6UZLcb7G2OL0TKr2NxVhYEkA3owpobCONRccTjC7BONtw= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R831e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045220184;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0WBviP6u_1722566415; Received: from 30.97.56.76(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WBviP6u_1722566415) by smtp.aliyun-inc.com; Fri, 02 Aug 2024 10:40:16 +0800 Message-ID: <45209c7b-55b1-45e8-a1dc-f5c9202e2e01@linux.alibaba.com> Date: Fri, 2 Aug 2024 10:40:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: consider CMA pages in watermark check for NUMA balancing target node To: kaiyang2@cs.cmu.edu, linux-mm@kvack.org Cc: akpm@linux-foundation.org, hannes@cmpxchg.org References: <20240801180456.25927-1-kaiyang2@cs.cmu.edu> From: Baolin Wang In-Reply-To: <20240801180456.25927-1-kaiyang2@cs.cmu.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: k7tuahfmi6dtamqsorxwe41ont8ki1cw X-Rspamd-Queue-Id: 53F58C0006 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722566420-321472 X-HE-Meta: U2FsdGVkX1/I2pHc/iBA7ovMwvHWmksFjjwRN7RZdlS/NySqtNZJRSx1JfQKyxpyxowWy6DPzVqjn5XJhCIY6/fr25+LNXXMYrwOGt7CyWYr6oK8W+u6K+/hBk1SI70hYJzHG/Q4DIn9ZKUzF12bO4TaLWleJ+Uvng1ExI7uX+6+ksYzmWGBBRqe+VlzqIboZ63LXv8/70B8LMw28Pp13um7vEqd855kAo715f7kKjosDbT2sygnjg36xB4+DCdN9GCe2qDzpqm4byngQ5fMMDDGZRZbTeNoUtu0Vig4I86Ew9+j8Y+FRWnTlD67V5AlhyBGRXuDDvw/sDDoTbeXRmMeLgR+c4JVDy6YJKKnEtGeDi3/7zp4aXuO1QGDy0gcG+ZFuOe+e6R20n9X5KNquHmeas+l60VYPmHpDKv1xLH0xVymPdpV92F0XCOXsBj1481KHP8gB8rREdAivPeeBDe8BOTc4f1teMhQnwYeRDSTTKP9n6N08Rp6ZGT3tjFgNWPKRrIk1GMuA0leNRYH5GFgjMXdcjCyBuy63m6+Pu6rJTKFfwppLNONUog1I1glhJ02WkruFBmacWnzwIjWYyxqRas2Z5+vSoaL0rCWo6xQI2JC0SG00LUeWxKZDHLOSz1Gn2gW2G48BPknOqorChw5YAIhjtErS+SKiiIssF5cntOGg9jjpdGiMtqWM6DEQUXHcSBJGSJBorAaU31mmTq/SJ7Qm8LRKsE3zoq9Aw8MH5U3Jmpxg6NLf4H1ogutqajseK/gZxrdn48SubWFAnUEiQh39VRYX5yRJh1qX4n1bfDbAr1OQ+3M2gbEML2s9dQzqKEL5vTAFwNQTYHeFMc1xVhJy+k/9BEpNx3RmZypQwiQAOyCPyweuL1ZUpWT7NZHiADbNr5kAiHY+oKG433zycEUbGYwX2rRqwW405DYtgEXh4KoOWfm77uEttzYsVFZU43Vjn0+8ynC6rb sKI7Z+in s+BelKHQQy+GLLFDtMxaf8ugDCWcRQql+nYQ0oQQRzIf2MdowTNpYAXZxgQgn6J0WdqykU5VPXIrEz7094Opi3ParZvUkfLwmlcvCVoFPlpibONz/6S9lYTmPJ2ZekTqkiB1wbvVh8Y6CIPDsH18AZ+ihYrf1fCrS2XF8Wm6TjzjPHfSnJRO4RtPwbk/OTs5VeIOItRvieirZN0JZqn4N+UjAYBe8YOIsdd2RVZ2h5qLU87ix2ZZ7JrGE/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/2 02:04, kaiyang2@cs.cmu.edu wrote: > From: Kaiyang Zhao > > Currently in migrate_balanced_pgdat(), ALLOC_CMA flag is not passed > when checking watermark on the migration target node. This does not > match the gfp in alloc_misplaced_dst_folio() which allows allocation > from CMA. > > This causes promotion failures when there are a lot of available CMA > memory in the system. > > Therefore, we change the alloc_flags passed to zone_watermark_ok() in > migrate_balanced_pgdat(). > > Signed-off-by: Kaiyang Zhao LGTM. Reviewed-by: Baolin Wang > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 8578a930cad1..aa482c954cb0 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2526,7 +2526,7 @@ static bool migrate_balanced_pgdat(struct pglist_data *pgdat, > if (!zone_watermark_ok(zone, 0, > high_wmark_pages(zone) + > nr_migrate_pages, > - ZONE_MOVABLE, 0)) > + ZONE_MOVABLE, ALLOC_CMA)) > continue; > return true; > }