linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ashwin Chaugule <ashwin.chaugule@codito.com>
To: linux-mm@kvack.org
Subject: [RFC][PATCH 1/2] Swap token re-tuned
Date: Thu, 28 Sep 2006 19:36:56 +0530	[thread overview]
Message-ID: <451BD700.4010106@codito.com> (raw)

Try to grab swap token before the VM selects pages for eviction.


Signed-off-by: Ashwin Chaugule <ashwin.chaugule@celunite.com>

-- 

diff --git a/mm/filemap.c b/mm/filemap.c
index afcdc72..190d2c1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1478,8 +1478,8 @@ no_cached_page:
     * We're only likely to ever get here if MADV_RANDOM is in
     * effect.
     */
+    grab_swap_token(); /* Contend for token _before_ we read-in */
    error = page_cache_read(file, pgoff);
-    grab_swap_token();

    /*
     * The page we want has now been added to the page cache.
diff --git a/mm/memory.c b/mm/memory.c
index 92a3ebd..52eb9b8 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1974,6 +1974,7 @@ static int do_swap_page(struct mm_struct
    delayacct_set_flag(DELAYACCT_PF_SWAPIN);
    page = lookup_swap_cache(entry);
    if (!page) {
+        grab_swap_token(); /* Contend for token _before_ we read-in */
         swapin_readahead(entry, address, vma);
         page = read_swap_cache_async(entry, vma, address);
        if (!page) {
@@ -1991,7 +1992,6 @@ static int do_swap_page(struct mm_struct
        /* Had to read the page from swap area: Major fault */
        ret = VM_FAULT_MAJOR;
        count_vm_event(PGMAJFAULT);
-        grab_swap_token();
    }

    delayacct_clear_flag(DELAYACCT_PF_SWAPIN);
-- 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2006-09-28 14:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28 14:06 Ashwin Chaugule [this message]
2006-09-28 14:09 Ashwin Chaugule
2006-09-28 16:58 Ashwin Chaugule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451BD700.4010106@codito.com \
    --to=ashwin.chaugule@codito.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox