From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45185EF6.9070908@RedHat.com> Date: Mon, 25 Sep 2006 18:57:58 -0400 From: Steve Dickson MIME-Version: 1.0 Subject: Re: Checking page_count(page) in invalidate_complete_page References: <4518333E.2060101@oracle.com> <20060925141036.73f1e2b3.akpm@osdl.org> <4518589E.1070705@oracle.com> In-Reply-To: <4518589E.1070705@oracle.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: chuck.lever@oracle.com Cc: Andrew Morton , Trond Myklebust , linux-mm@kvack.org List-ID: Chuck Lever wrote: > > It seems that the NFS client could now safely use a page cache > invalidator that would wait for other page users to ensure that every > page is invalidated properly, instead of skipping the pages that can't > be immediately invalidated. > > In my opinion that would be the correct fix here for NFS. I would have to agree with this... in debugging this I changed the invalidate_inode_pages2 in nfs_revalidate_mapping to truncate_inode_pages() for non-file inode which also seem to work... So it does beg the question as to why aren't we waiting for page to be invalidated? Is there some type of VM deadlock we are trying to avoid? steved. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org