Peter Zijlstra wrote: > On Sun, 2006-09-17 at 23:52 +1000, Nick Piggin wrote: > > >>What we could do then, is allocate pages in batches (we already do), >>but only check watermarks if we have to go to the buddly allocator >>(we don't currently do this, but really should anyway, considering >>that the watermark checks are based on pages in the buddy allocator >>rather than pages in buddy + pcp). > > > Signed-off-by: Peter Zijlstra Hi Peter, Thanks for the patch! I have a slight preference for the following version, which speculatively tests pcp->count without disabling interrupts (the chance of being preempted or scheduled in this window is basically the same as the chance of being preempted after checking watermarks). What do you think? -- SUSE Labs, Novell Inc.