From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB9F1C00A8F for ; Tue, 24 Oct 2023 02:43:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61F026B0173; Mon, 23 Oct 2023 22:43:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CEB16B0174; Mon, 23 Oct 2023 22:43:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BD706B0175; Mon, 23 Oct 2023 22:43:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 374C16B0173 for ; Mon, 23 Oct 2023 22:43:16 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0B052A0B90 for ; Tue, 24 Oct 2023 02:43:16 +0000 (UTC) X-FDA: 81378808392.12.854A618 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf27.hostedemail.com (Postfix) with ESMTP id 615F74000E for ; Tue, 24 Oct 2023 02:43:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=none (imf27.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698115394; a=rsa-sha256; cv=none; b=eEGhVHjZ/Pr7ZvnWDMciFw7iWTckiliPV9cappwgdF5Cf9FqeSM6LCUkVYJme/tbYhR+SC a3US97t6Lo4SXHrK6Sobu5s9SJBfNarQg4BDTy1WQuwSTFuh/N8hrjOKMNcDRvIONgXJza FIqm/9Qur3nBi67Fn8+v5//VKy1FKdY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=none (imf27.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698115394; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MyDuijnqnxo93dWmePi3oKK9YivpJ2KRFKjdQKhx8CE=; b=l1soSkAmBbQG41rKY5on/rkusF5+a8laI2dwzwPNDo2z/B51kziVgleEBwkqrgi6EtOHhj xXF5EasMx0nzZOQrutLH7EfsBmiaJn+LXnVzZ4ezWEtA5eWcUfOG/c3Pg1g160OEnggDWV rX9r4E28NlXlJU1XzZghQVVclzcHJFU= Received: from imladris.home.surriel.com ([10.0.13.28] helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qv7Nq-0003DF-1T; Mon, 23 Oct 2023 22:43:06 -0400 Message-ID: <450e102421c1c113552071964b88f1b2e14256a7.camel@surriel.com> Subject: Re: [PATCH v3 5/5] mm/khugepaged: Convert collapse_pte_mapped_thp() to use folios From: Rik van Riel To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Date: Mon, 23 Oct 2023 22:43:06 -0400 In-Reply-To: <20231020183331.10770-6-vishal.moola@gmail.com> References: <20231020183331.10770-1-vishal.moola@gmail.com> <20231020183331.10770-6-vishal.moola@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 615F74000E X-Stat-Signature: spitramaxzjg3apqth6q8cmaaak3ednm X-HE-Tag: 1698115394-561146 X-HE-Meta: U2FsdGVkX18p/gWhfCXbVYuBoc0e0KgI9PxqMxoj0eqQHdayUvV2qgAAGBadn8/MnMwU/0bE8ZykphP7UcpRv2NLcBKgXFp/1ZBOFmYIKO/wBSiy5fZNM2s6uzq50jX8yyXzIvHoXZJ6uzn9gYlJo3D8rVK7RJsxVAy69IZtRphPIMZehP58odxt8Y8GBJHFusnf2GCtC96VKGIZGBZRGSiQ8idBXPRNDn18N1o08WMt7wm6ErrXYfJqT5dut0nPbeJp/AJ4Vy15iHZnnGAB0SH2yta2wMRevGKdAkFlBN/W/0HLzO5P9z2/SSoaciQmIQ1yq6zrI31PyvQ2qswyKtkS8/2rfl3+EhExlW/9/Bf/mea+GOC4FqD7agSpYiCfez1H71XAq7PkbGS098gFOZahYzUI0uvbHHf/g5U6F4656M4soqPR7qVSMo11mcWDbPb7yADwDOC6Z0SrOxnapbn4gpOhro1lfa/CGXlFd9eWbYpKp7wBHRmGojM+zmp8OXRIgi27lFb5NBNv/HzrTeaoJ5C1FqhIoeFiK1kOL4KcNmctRsDqDkoczUBzvH5pfMIUn4RlxfgGrhwChRasX5+IrtQTPy0i5K8oAth5QhDLLrbYbnDUhEw6P89S2K3G20zysAXS1S80GG0ta8mIUX9gc3W5ik5ny9GsCcu6N5b/wwaF9jVYk1YJl6gVpD8Jws81+nDtePgyBxkN7wthwbkbhHXQjnWwaTkDnae2PG9cWwzdbPwTrXSHw8KZPRoqC5Eiglo+Amw5k3yrRjdP8fBqQ9XvwkUPk1I+sshmhrYgqNHvytnPCEG6l8K+l5sMzd1/Ao4gqWr0WLVo3xLN1mXOD2HiJs3sOK6+ObI0NkmON3u/H/6/BD0IFdd0oaWxqtpW7iW6IZCSB5KEVzrwJZ1bNUIOsvQA9XO9GJrdOkWmm01JD5U/vUTin1Iq6qivHVvlr6oj2GITern5iBB QtqJDIhv x35xqrp7qquOF2ilb2dtlKjvvPbzDeGEDsq/mAPySDCDolqzPxioD/5TIDEOeW7KH3rjFHL5nHeh0ZqmXrNjqXQ4PWsmtqoJ2F0qbosZSzR9FXrSvCz2avuo3SK62OVIOJObyNQjjfGdWg4sFQDtoEJuEfgDIKoYzV6b7aYTA3i6k6xx+UtD5n1JMdUDQLoI9VWWBEK1yYXpZ125RKroPjvyhVdIyqnSxQTzORUQg9RV+1tVqFNvGdkm6RbvLxUiGWLozZV79FvlXK38Q1Xp4hIvNpwQB6P1u8N5vzy0RJLVjob+/pme/ZwgmVTg0CLQVkKtwGkYpBQRtOohHzfnDyLP+YlvukmTsNoaSe9JLUvR0NmpvffaUalzLIuWpe8qdC5msV8Rs8c4tdh2R+lpaX7UwuLALKVfd224JAMA+eUJXkWrypl7VDX1F4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2023-10-20 at 11:33 -0700, Vishal Moola (Oracle) wrote: > This removes 2 calls to compound_head() and helps convert khugepaged > to > use folios throughout. >=20 > Previously, if the address passed to collapse_pte_mapped_thp() > corresponded to a tail page, the scan would fail immediately. Using > filemap_lock_folio() we get the corresponding folio back and try to > operate on the folio instead. >=20 > Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Rik van Riel --=20 All Rights Reversed.