From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02DCEE7718B for ; Fri, 27 Dec 2024 10:48:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77AFA6B0083; Fri, 27 Dec 2024 05:48:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72A456B0085; Fri, 27 Dec 2024 05:48:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CA256B0088; Fri, 27 Dec 2024 05:48:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3BF136B0083 for ; Fri, 27 Dec 2024 05:48:39 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D804081BBD for ; Fri, 27 Dec 2024 10:48:38 +0000 (UTC) X-FDA: 82940413836.06.1BF24FD Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf27.hostedemail.com (Postfix) with ESMTP id 3391940006 for ; Fri, 27 Dec 2024 10:47:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="pQP/lRW/"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf27.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735296476; a=rsa-sha256; cv=none; b=A3jsSnglSMIQPnkWFK64RjV34OZc7QRLzJ/8Ts/UR9KviD73DBRMeojP9AwR+0LStj70Pv sKSd12Tnx+XKDdq92ITRdCXvfmTWxgWZpuZnZcGgOCkd+NG18cX5D+ZAuA8VUoXYXxyRYX MA2bTHBfugJe+hrb+WImVOzXRkSWW1M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="pQP/lRW/"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf27.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735296476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qX1JwJFs4amPQV6ymBryid5NmZW7BXREfgiR4wYrmZQ=; b=ifZtAVAdxsQmNE6+nFVhGfYZJ9OsDPnqMA+Li0Yoy03e9IBfN+eR1HBiuL+qXNmehpyTCv Ewq29QjEwo2isLvQtJdkhsSnc2DtxFcxxYbTV4LoemQjw3Ed5ROk0MXmGHzp7IHgTgYVrW maO6fZdct/ZEesgqPDsk+HYGhmSLoJs= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BQMGYEJ024107; Fri, 27 Dec 2024 10:48:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=qX1JwJ Fs4amPQV6ymBryid5NmZW7BXREfgiR4wYrmZQ=; b=pQP/lRW/0D7ZD8YLkR2R4e GRMS2v66zjN08S+4fgnKpQiRskyaGNu66TGj9O3hIakH5megbenYxqwLVqNc4kbF gg321vHP1/vAlyd6EG11NGk9OgjVz78too/i9es0IU4JtgLWnecbJI7nog20LSE8 b2UozyrRW1osrqtdAUbEQY6mkoQubZjkqKcdf0JxHtnOi2FRcYvbWXRFWCsuZzAS tpt+/XDyc9LPModZnfkM/sKECQ+T29GrSIuR5Aq+Rtf6b1p8DMffPpDv5QSiNTFr alMIxfupvd0ydlAS2wXkSQv8aQB8lNyEnyIiXpzK0v0DPN1WpBKTJtn80uy1YijQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43s8m4ucy6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:48:34 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BRAmX78025692; Fri, 27 Dec 2024 10:48:33 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43s8m4ucy0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:48:33 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BR73weq002321; Fri, 27 Dec 2024 10:48:32 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43p80swq0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:48:32 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BRAmWfn26870416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Dec 2024 10:48:32 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A64558050; Fri, 27 Dec 2024 10:48:32 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A136358045; Fri, 27 Dec 2024 10:48:26 +0000 (GMT) Received: from [9.179.17.222] (unknown [9.179.17.222]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Dec 2024 10:48:26 +0000 (GMT) Message-ID: <4504da8d-a5e7-45a1-9feb-167f94210200@linux.ibm.com> Date: Fri, 27 Dec 2024 16:18:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints To: Gregory Price , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> Content-Language: en-US From: Donet Tom In-Reply-To: <20241210213744.2968-5-gourry@gourry.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: DUwLMLLUpwut_fwoqbkDgoDr4BzEzhiz X-Proofpoint-ORIG-GUID: C-t57Cr-vnzlHDqxym3u5cHb58PSL5Rl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 clxscore=1015 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412270082 X-Stat-Signature: yzysibg1x4b5h18i4paqk5cuhpt8494k X-Rspam-User: X-Rspamd-Queue-Id: 3391940006 X-Rspamd-Server: rspam08 X-HE-Tag: 1735296470-483128 X-HE-Meta: U2FsdGVkX18IRb2xsJ+3C8oMxyaVN83fCZYp0tZyMkGPijBGV+oJS5k7DBpKiQTykw4nL0ztFRfUjkUBN/kA+dMO0IRu1/MCWTNWfbWueiyL5dnGHetWJqZEninAEHTmcOfeMUME+ySONm8/h/kvAKjDEzxmScrBHAoyblIukSFRY61eNgIyVMT7otdGtPLENJmb2le6uykJP2hD0mGOUhgW3xo6xrB/SHzsU9dlt4OHeWduuOoOK18LITZPmxP+M/w/cb5rTOJEgHVQJ5Jos/ogMdSygTDiwbXX1vVb0cYb+KpEGHpXR1Oz88V1tjUfjxb1gu3PgPQVKbDq9DmWp4821jCSFU9THTl59CrQryKf6Wu3o3AEEVjDv0H7Dd/1ZrAAVQgZTfe+z680fVVfd0iz0L7cguzZEgqwFKZeS3T+XRDVJ90/jPKGaQNc7eZt9IohQz3nGpRISXJyX9JXpIupFIHyxAZEIeDx3tohGzLaBWiJ2nN+1LOY01Vt1IvTZMehFAVjNYbVZ6kD+XNDO0RSJ8sF1K0vhzRFGYz4M4cB7jT8qyeZFb2yi0RJxVp+QH3yK82GaTSSeAJgffCGJg7OJZYh2QOp5GQ3+nzvlBJGL0awnYIgJM37MHA3hjW/lwj8ZPCot0IIeyY+uM1gwGe2J5thrpt1VpXYt9WqVapRWx5thqXRjliVRoFzle7oEjN9KHeXJVrxcb9UkGcMCvIapj3hMtVImS/ugE/x6MPaoPFMmPN9RmugcYRfClBsSVUWKQLH87So/gfjqnlIeerYLtPj7k8hxoYbtgqB0dFjwr7Kv1M42mtpz2TmpZRXBeiWBGETvXbUiXPKvd5jN4pMOqgy139nE4HP/3HLVbQippGnelOWHzygAQ2gy9oSzS489XHcsDB7XMI+3Lxh2r4g0XLzFF1OfaJWOtFBjUExVS39/CBxwo64YjyUqW3iTOa7KmFBGpjo+LF5+Sg uDGMmKEa YjWMY3Rb1cQDcZKFWKBJQRZwfWgvakN4SNSlpt8A9daIJHuYhDQDNYyQLgeq3IDtBwMdbD7vA5+J3xTD2h5KHwBxq0bnuy5EO+nfBLwl3ytVQdmtyZExzO3N4qL8Hk5t34f1h7ueO4iRO50ugpmo9QrDW23Ks4DrY/W1Kw3WOeblVYyXovj5ghFHyg0o+z0gGDu0eApNOlKdqN7DaXTwX88FdQeJKkTJ2syAvFL/HdpsXxGGLC4bGsZe0reYZQRjYQU+aEOdWzq2rP8mRVMpZ9Tyvf8jSwRCK357FPpbdiTq7hdjNOWlBPrO74EUHm7B1lXpfRbsyB1PufscIC0ZhyCYs4E8Jfi+2DUR5P9DzDvq76GW1dIqVAQM4gAMcBHjoRLov X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/11/24 03:07, Gregory Price wrote: > Count non-page-fault events as page-cache numa hints instead of > fault hints in vmstat. Add a define to select the hint type to > keep the code clean. > > Signed-off-by: Gregory Price > --- > include/linux/vm_event_item.h | 8 ++++++++ > mm/memory.c | 6 +++--- > mm/vmstat.c | 2 ++ > 3 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index f70d0958095c..c5abb0f7cca7 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > NUMA_HUGE_PTE_UPDATES, > NUMA_HINT_FAULTS, > NUMA_HINT_FAULTS_LOCAL, > + NUMA_HINT_PAGE_CACHE, > + NUMA_HINT_PAGE_CACHE_LOCAL, > NUMA_PAGE_MIGRATE, > #endif > #ifdef CONFIG_MIGRATION > @@ -185,6 +187,12 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > NR_VM_EVENT_ITEMS > }; > > +#ifdef CONFIG_NUMA_BALANCING > +#define NUMA_HINT_TYPE(vmf) (vmf ? NUMA_HINT_FAULTS : NUMA_HINT_PAGE_CACHE) > +#define NUMA_HINT_TYPE_LOCAL(vmf) (vmf ? NUMA_HINT_FAULTS_LOCAL : \ > + NUMA_HINT_PAGE_CACHE_LOCAL) > +#endif > + > #ifndef CONFIG_TRANSPARENT_HUGEPAGE > #define THP_FILE_ALLOC ({ BUILD_BUG(); 0; }) > #define THP_FILE_FALLBACK ({ BUILD_BUG(); 0; }) > diff --git a/mm/memory.c b/mm/memory.c > index af7ba56a4e1e..620e2045af7b 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5578,10 +5578,10 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, > *last_cpupid = folio_last_cpupid(folio); > > #ifdef CONFIG_NUMA_BALANCING > - count_vm_numa_event(NUMA_HINT_FAULTS); > - count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1); > + count_vm_numa_event(NUMA_HINT_TYPE(vmf)); > + count_memcg_folio_events(folio, NUMA_HINT_TYPE(vmf), 1); > if (folio_nid(folio) == numa_node_id()) { > - count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); > + count_vm_numa_event(NUMA_HINT_TYPE_LOCAL(vmf)); I have tested this patch series on my system with my test program. I am able to see unmapped page cache pages are getting promoted. numa_hint_faults2269numa_hint_faults_local2245numa_hint_page_cache1244numa_hint_page_cache_local0numa_pages_migrated4501 In my test result numa_hint_page_cache_local is 0. I am seeing numa_hint_page_cache_local will only be incremented if the folio's node and the process's running node are the same. This condition does not occur in the current implementation, correct? Thanks Donet > *flags |= TNF_FAULT_LOCAL; > } > #endif > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4d016314a56c..bcd9be11e957 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1338,6 +1338,8 @@ const char * const vmstat_text[] = { > "numa_huge_pte_updates", > "numa_hint_faults", > "numa_hint_faults_local", > + "numa_hint_page_cache", > + "numa_hint_page_cache_local", > "numa_pages_migrated", > #endif > #ifdef CONFIG_MIGRATION