From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D40AC3DA64 for ; Wed, 31 Jul 2024 09:17:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC8186B0089; Wed, 31 Jul 2024 05:17:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C78036B008A; Wed, 31 Jul 2024 05:17:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF1826B008C; Wed, 31 Jul 2024 05:17:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 91BDB6B0089 for ; Wed, 31 Jul 2024 05:17:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 20AF21C10F0 for ; Wed, 31 Jul 2024 09:17:50 +0000 (UTC) X-FDA: 82399495500.21.C1D2EB9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id C5D2C1C001F for ; Wed, 31 Jul 2024 09:17:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EMZW1Gd2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722417463; a=rsa-sha256; cv=none; b=jSyhItHUmoOEtZA6nSAgkaZRP+8MqX05MqCWwt+wNxvsUofsZWeI+SwXv+X552ZM7/dsvR nrcMuo9Z8TVqfOGw39hsCByaDI4b10cWmF+EtpcCo16L8KaUYwf4fEaPQAi2rAKytF4krW UngjK1tqRW6yK/zXXW7UJVNhuc0ZZ/M= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EMZW1Gd2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722417463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BDE94ttAmSeZaBo4E5VKbvpN4U6EyPy1h2kJNjBGAF8=; b=lEXPN4vP9iTwOyqj8QeAN5cDBQM1DOe2zknp6TdxckMTwGxrgqnUp/VtY8fZDEAS+nyiIF gXltTsGZ+Pf9cDSB9hv30osKsr5PKSTatQrHouoZFDOCI+AuooiLW/Ctk4MUegs59kreEg k4Y/JHKze8tteiif0OeokO8kVLRxYn8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722417467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BDE94ttAmSeZaBo4E5VKbvpN4U6EyPy1h2kJNjBGAF8=; b=EMZW1Gd28eVZ84bNyhhSBxttRsjJsF2kTgF6tGgF8obFtqUU1T6szHqeDj2jjIlmbsmJFn c9yjW+WlAdyzZWJeVqJtZsMxPH4wwxF89EBGZKxag60IHdclTsqZl4EpZWnkeIUR8jINu6 I4nsdmCzTWEWsYxwkhEluGWfuT8QehE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-14-D0znHpl8MO2bYJWFXjzcSg-1; Wed, 31 Jul 2024 05:17:45 -0400 X-MC-Unique: D0znHpl8MO2bYJWFXjzcSg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3684ea1537fso2684080f8f.1 for ; Wed, 31 Jul 2024 02:17:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722417464; x=1723022264; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BDE94ttAmSeZaBo4E5VKbvpN4U6EyPy1h2kJNjBGAF8=; b=lVZRoF5puRljGA0LB8q1UfG+W//x5UhGop2Cjkw7FFG/5SQsNUV774ZBnTK8hRUm0i NsCT+Mo7SpBMI+m++RbNSdOQmDzsWUwB8Dvhof05vXK4Ndb7ruwbQGMUP5BqPomW9OEK V+AvrYzaYYFC8TVCDDZU6+iBfmwtg6BPqNt4zSAufA34TlzSxEclIdiwO/XGNEM8EBi4 DyQC24yLIgNJsorOhR9OLMI5Yj3M7wuNcuCUzr4YtE5czxgG1O815Kr26htzu34lKAyD Bxda0dK/sqdxqWn8l02RX6FUgP67kY/O/baptjfFSC3Va8rOOGg/MYS/xWVjC7AQwisH cOuA== X-Forwarded-Encrypted: i=1; AJvYcCUgWXBOCWWYMe4bF1SdIJFUlPijg2rdV5tURFubd3RAmg0j61x9riMIwkRaj1ksMTpHUBOjynaPrEa/XLCw3714Ji4= X-Gm-Message-State: AOJu0YyLJy18KUGrN2TRBfcLvo7AAuCx4QAbqOt4IEaQDKV46eX5lR39 NZleq8ZWJMNKYoKpmvMrGKyXnqqVVzsoNH1yianxcdqC9OuUHbadv6japBIHo8wj+41we4DtKvu sMn1qMYq10xrLMy7FHiRA0e+Tyd0zxAZxegv4/PFw4z+OvSHj X-Received: by 2002:adf:a188:0:b0:367:97b9:d5ed with SMTP id ffacd0b85a97d-36b5d0b0959mr9948697f8f.9.1722417464495; Wed, 31 Jul 2024 02:17:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXq4J7fR+jTjcwE40Onq8d8tUKj9c75MzvlyIdbr/reJom+fLTDjGVDxLA5sSJg4f53jQ0iQ== X-Received: by 2002:adf:a188:0:b0:367:97b9:d5ed with SMTP id ffacd0b85a97d-36b5d0b0959mr9948678f8f.9.1722417464049; Wed, 31 Jul 2024 02:17:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:5f00:9b61:28a2:eea1:fa49? (p200300cbc70b5f009b6128a2eea1fa49.dip0.t-ipconnect.de. [2003:cb:c70b:5f00:9b61:28a2:eea1:fa49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b36861b29sm16501584f8f.93.2024.07.31.02.17.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 02:17:43 -0700 (PDT) Message-ID: <450360af-9222-4251-8529-f44c4b8b498a@redhat.com> Date: Wed, 31 Jul 2024 11:17:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: shmem: avoid allocating huge pages larger than MAX_PAGECACHE_ORDER for shmem To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, gshan@redhat.com, ioworker0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <117121665254442c3c7f585248296495e5e2b45c.1722404078.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <117121665254442c3c7f585248296495e5e2b45c.1722404078.git.baolin.wang@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C5D2C1C001F X-Rspamd-Server: rspam01 X-Stat-Signature: x3hxbfx6wkray1rg7n1ubjx5uiikj9ek X-HE-Tag: 1722417467-858061 X-HE-Meta: U2FsdGVkX18BTO6kLjbr9g5vNg2H/RAYmjShjD9d80um+a0NCVi89IM2POtXsqGqq9zhVBAbBGAMDbkxBIOEP1nIsiEZcAIi4UY2S/jbhAsvJFxaDQOUG/6NEXR3L0Y42N7hCojSj0h7T1z0rikTlupvg9lvUuAGmLoY6XGqoMGaJmgvS+y9LyCKGxAoKCdHGHUSvDrCTvbi0vhg6vuOfcrhKJneYvcdLDZOhhdpWt4WkLGHVAF/kRcMLrfepV9aYBYyL/lSNE3Dvq5YjDJiHSUJELoOpZvumdUcfo8FBZW0xxcoL12HFq57VYp1bxRoNAkPJYQ+8w4jc5AL27019G5J1h+kahA0IgZkzfuyi8T4VYKdqdi2Rl4sCVqw+6weD4o69xZmfP5KmOXBFRtNawRox5Z070bBiU+nxlCSIRYMv8GatqoHHKt74kGmZAPqS5GMsY9kuAG4rSxzpTfkEwBbAB3B1PkuqgXog4CDF24lXGvEol2jYR7hBAKT0XYAiQWfCaU90tlLUXMVxGRKu2bkH5GGCa+0PDTooqNoMPsvM9DB0JCB5Lgkn1+QoBZ2PaXwqqIrTTramkMyq6ERkN5RWe1aYS56dhzw/we38UeS1VwWC4BMbBVcC9W1nISFrt6XaSfEOorvFvs/trHl7LDDtys5eA+uaNcky98a3gIe8zwhpeLTo/+eXoOV6yoVteU+MU4idyFubwTHYx3BNGe3Hal92o6Kk633FdQ4eXQtTwSenIg5cn9pES0RZ2QK9S4Po13Q+ls3X++9h/0NtckdozyutWMR3QG7aSkYLUJyJDWP27zrZ54gWsbReDQ6K6YkwgrocwzeysG5Uwlu25wD9O4Gzk3BCWh7zLyCaTSmv68mX4reInkAOwtajAHq0yiCTzoP7H3MP65sDlz6lg6dDp3AfcjXRtA5I1VpuEGX94fs3R5S/6wgsxim4Sx3gnXLziPhzT2f5EvsFQv NXG7aKx1 3thrWfeuNdYUQDu3aE8/7hMc7YVXpV8Xwosf+zuCVFR88md+4zNRIFjfYMxTGfigWxm4esDxWbmFiXL5mLWUPqCjfFyr9j9NGf4a2JJurve3ho9L4dE6AhvEGLa67pMZ7Xau3oekL0v64XHxWzMplLE5QEHJ24zAU7/N2mvLY/DyRfgfxntu9LSActhoM+DB4+0UB+XhvpIisvCcf/eqoUVcR9XyCQYO0wDtdveRMK7IJ1cA92HD0uju5IDyt7tESmDFki5vqg02xrWWyOrjX2X/h5jbFH3EbFTCVggJ/915m2OyudJOVQkgCi+049CS2kagXYWvakMKdvHrqxPwReXISBD1yewUp/8Ut0OCSmEFOyIY/XgEfRyeF8qMGBwujo89tE+Smx20Nss9GsUC0opobi3OsiikbwZG9N1Ybn3zLY+jN4RYzbPTju7/F/25xT/uHqGxaeCArj5dl8C8d+iv50g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.07.24 07:46, Baolin Wang wrote: > Similar to commit d659b715e94ac ("mm/huge_memory: avoid PMD-size page cache > if needed"), ARM64 can support 512MB PMD-sized THP when the base page size is > 64KB, which is larger than the maximum supported page cache size MAX_PAGECACHE_ORDER. > This is not expected. To fix this issue, use THP_ORDERS_ALL_FILE_DEFAULT for > shmem to filter allowable huge orders. > > Fixes: e7a2ab7b3bb5 ("mm: shmem: add mTHP support for anonymous shmem") > Signed-off-by: Baolin Wang > --- > mm/shmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 2faa9daaf54b..a4332a97558c 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1630,10 +1630,10 @@ unsigned long shmem_allowable_huge_orders(struct inode *inode, > unsigned long within_size_orders = READ_ONCE(huge_shmem_orders_within_size); > unsigned long vm_flags = vma->vm_flags; > /* > - * Check all the (large) orders below HPAGE_PMD_ORDER + 1 that > + * Check all the (large) orders below MAX_PAGECACHE_ORDER + 1 that > * are enabled for this vma. > */ > - unsigned long orders = BIT(PMD_ORDER + 1) - 1; > + unsigned long orders = THP_ORDERS_ALL_FILE_DEFAULT; > loff_t i_size; > int order; > Acked-by: David Hildenbrand -- Cheers, David / dhildenb